andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[#3945] Http2ConnectionHandler breaks channelReadComplete pipeline notification

Browse Source 
Motivation:

Http2ConnectionHandler missed to forward channelReadComplete(...) events.

Modifications:

Ensure we notify the next handler in the pipeline via ctx.fireChannelReadComplete().

Result:

Correctly forwarding of event.
This commit is contained in:
Norman Maurer 2015-07-07 17:14:12 +02:00
parent 972b4c6e48
commit e43fede591
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ConnectionHandler.java
View File

@ -421,7 +421,11 @@ public class Http2ConnectionHandler extends ByteToMessageDecoder implements Http
public void channelReadComplete(ChannelHandlerContext ctx) throws Exception { public void channelReadComplete(ChannelHandlerContext ctx) throws Exception {
// Trigger flush after read on the assumption that flush is cheap if there is nothing to write and that // Trigger flush after read on the assumption that flush is cheap if there is nothing to write and that
// for flow-control the read may release window that causes data to be written that can now be flushed. // for flow-control the read may release window that causes data to be written that can now be flushed.
flush(ctx); try {
flush(ctx);
} finally {
super.channelReadComplete(ctx);
}
} }
/** /**