andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Make sure the readerIndex is updated after the ChannelBuffer was sliced out. See #412

Browse Source
This commit is contained in:
Norman Maurer 2012-06-29 13:10:27 +02:00
parent 076a6a9239
commit e53be94773
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/main/java/org/jboss/netty/handler/codec/http/HttpMessageDecoder.java
View File

@ -461,7 +461,7 @@ public abstract class HttpMessageDecoder extends ReplayingDecoder<HttpMessageDec
}
/**
* Try todo an optimized "read" of len from the given {@link ChannelBuffer}.
* Try to do an optimized "read" of len from the given {@link ChannelBuffer}.
*
* This is part of #412 to safe byte copies
*
@ -469,7 +469,12 @@ public abstract class HttpMessageDecoder extends ReplayingDecoder<HttpMessageDec
private ChannelBuffer read(ChannelBuffer buffer, int len) {
ChannelBuffer internal = internalBuffer();
if (internal.readableBytes() >= len) {
return internal.slice(internal.readerIndex(), len);
int index = internal.readerIndex();
ChannelBuffer buf = internal.slice(index, len);
// update the readerindex so an the next read its on the correct position
buffer.readerIndex(index + len);
return buf;
} else {
return buffer.readBytes(len);
}