From e58095c4f22f5637d6eb90898ecbbbbb057490d4 Mon Sep 17 00:00:00 2001 From: "jiachun.fjc" Date: Wed, 3 May 2017 00:37:09 +0800 Subject: [PATCH] Simplify code Motivation: Code can be simplified Modification: Refactor code to remove extra branching Result: Cleaner code. --- .../io/netty/util/concurrent/DefaultThreadFactory.java | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/common/src/main/java/io/netty/util/concurrent/DefaultThreadFactory.java b/common/src/main/java/io/netty/util/concurrent/DefaultThreadFactory.java index 42f32f663e..18c6e29c46 100644 --- a/common/src/main/java/io/netty/util/concurrent/DefaultThreadFactory.java +++ b/common/src/main/java/io/netty/util/concurrent/DefaultThreadFactory.java @@ -107,14 +107,8 @@ public class DefaultThreadFactory implements ThreadFactory { public Thread newThread(Runnable r) { Thread t = newThread(new DefaultRunnableDecorator(r), prefix + nextId.incrementAndGet()); try { - if (t.isDaemon()) { - if (!daemon) { - t.setDaemon(false); - } - } else { - if (daemon) { - t.setDaemon(true); - } + if (t.isDaemon() != daemon) { + t.setDaemon(daemon); } if (t.getPriority() != priority) {