andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix ServerCookieDecoder javadoc (#11372)

Browse Source 
Motivation:
When decoding the cookies on the server, the "Cookie" HTTP request header value should be considered.
The "Set-Cookie" HTTP response header is used to send cookies from the server to the user agent.

Modification:
- Specify in javadoc that the "Cookie" HTTP request header value should be considered and
not the "Set-Cookie" HTTP response header value.

Result:
Correct ServerCookieDecoder javadoc
This commit is contained in:
Violeta Georgieva 2021-06-08 02:33:31 +03:00 committed by GitHub
parent d5d6c3d3cf
commit e69107ceaf
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
codec-http/src/main/java/io/netty/handler/codec/http/cookie/ServerCookieDecoder.java
View File

@ -60,8 +60,8 @@ public final class ServerCookieDecoder extends CookieDecoder {
}
/**
* Decodes the specified Set-Cookie HTTP header value into a {@link Cookie}. Unlike {@link #decode(String)}, this
* includes all cookie values present, even if they have the same name.
* Decodes the specified {@code Cookie} HTTP header value into a {@link Cookie}. Unlike {@link #decode(String)},
* this includes all cookie values present, even if they have the same name.
*
* @return the decoded {@link Cookie}
*/
@ -72,7 +72,7 @@ public final class ServerCookieDecoder extends CookieDecoder {
}
/**
* Decodes the specified Set-Cookie HTTP header value into a {@link Cookie}.
* Decodes the specified {@code Cookie} HTTP header value into a {@link Cookie}.
*
* @return the decoded {@link Cookie}
*/
@ -83,9 +83,7 @@ public final class ServerCookieDecoder extends CookieDecoder {
}
/**
* Decodes the specified Set-Cookie HTTP header value into a {@link Cookie}.
*
* @return the decoded {@link Cookie}
* Decodes the specified {@code Cookie} HTTP header value into a {@link Cookie}.
*/
private void decode(Collection<? super Cookie> cookies, String header) {
final int headerLen = checkNotNull(header, "header").length();