From e7631867d30e26961e121ca05f5e3c078345984f Mon Sep 17 00:00:00 2001 From: Scott Mitchell Date: Wed, 16 Nov 2016 09:55:38 -0800 Subject: [PATCH] LzmaFrameEncoderTest double release Motivation: 2c78902ebc7a81caa0ee6e3892438455f06dec9c ensured buffers were released in the general case but didn't clean up an extra release in LzmaFrameEncoderTest#testCompressionOfBatchedFlowOfData which lead to a double release. Modifications: LzmaFrameEncoderTest#testCompressionOfBatchedFlowOfData should not explicitly release the buffer because decompress will release the buffer Result: No more reference count exception and failed test. --- .../io/netty/handler/codec/compression/LzmaFrameEncoderTest.java | 1 - 1 file changed, 1 deletion(-) diff --git a/codec/src/test/java/io/netty/handler/codec/compression/LzmaFrameEncoderTest.java b/codec/src/test/java/io/netty/handler/codec/compression/LzmaFrameEncoderTest.java index 8aa9bb438c..08c67101e4 100644 --- a/codec/src/test/java/io/netty/handler/codec/compression/LzmaFrameEncoderTest.java +++ b/codec/src/test/java/io/netty/handler/codec/compression/LzmaFrameEncoderTest.java @@ -69,7 +69,6 @@ public class LzmaFrameEncoderTest extends AbstractEncoderTest { while ((msg = channel.readOutbound()) != null) { ByteBuf decompressedMsg = decompress(msg, originalLengths.get(i++)); decompressed.addComponent(true, decompressedMsg); - msg.release(); } assertEquals(originalLengths.size(), i); assertEquals(data, decompressed);