andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix ByteBuf leaks in HaProxyMessageEncoderTest (#10704)

Browse Source 
Motivation:

We need to ensure we not leak in tests. We did see some leaks reported related to HaProxyMessageEncoderTest on our CI.

Modifications:

- Use readSlice(...) and so not create new ByteBuf instances that need to be released

Result:

No more leaks
This commit is contained in:
Norman Maurer 2020-10-18 14:10:12 +02:00
parent 8dffd0914f
commit e7e19b9917
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
codec-haproxy/src/test/java/io/netty/handler/codec/haproxy/HaProxyMessageEncoderTest.java
View File

@ -254,13 +254,13 @@ public class HaProxyMessageEncoderTest {
assertEquals(alpnTlv.typeByteValue(), tlv.readByte());
short bufLength = tlv.readShort();
assertEquals(helloWorld.array().length, bufLength);
assertEquals(helloWorld, tlv.readBytes(bufLength));
assertEquals(helloWorld, tlv.readSlice(bufLength));
// authority tlv
assertEquals(authorityTlv.typeByteValue(), tlv.readByte());
bufLength = tlv.readShort();
assertEquals(arbitrary.array().length, bufLength);
assertEquals(arbitrary, tlv.readBytes(bufLength));
assertEquals(arbitrary, tlv.readSlice(bufLength));
byteBuf.release();
assertFalse(ch.finish());
@ -309,13 +309,13 @@ public class HaProxyMessageEncoderTest {
assertEquals(alpnTlv.typeByteValue(), tlv.readByte());
bufLength = tlv.readShort();
assertEquals(helloWorld.array().length, bufLength);
assertEquals(helloWorld, tlv.readBytes(bufLength));
assertEquals(helloWorld, tlv.readSlice(bufLength));
// authority tlv
assertEquals(authorityTlv.typeByteValue(), tlv.readByte());
bufLength = tlv.readShort();
assertEquals(arbitrary.array().length, bufLength);
assertEquals(arbitrary, tlv.readBytes(bufLength));
assertEquals(arbitrary, tlv.readSlice(bufLength));
byteBuf.release();
assertFalse(ch.finish());