From e94db103c96587d00429dcd68e7dcc4489fc80e8 Mon Sep 17 00:00:00 2001 From: Norman Maurer Date: Mon, 12 Sep 2016 16:10:08 -0700 Subject: [PATCH] Ensure flowController().writePendingBytes() is triggered when writing response in example Motivation: We called ctx.flush() which is not correct as it will not call flowController().writePendingBytes(). Modifications: Call flush(ChannelHandlerContext) and so also call flowController().writePendingBytes(). Result: Correct http2 example --- .../http2/helloworld/server/HelloWorldHttp2Handler.java | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/example/src/main/java/io/netty/example/http2/helloworld/server/HelloWorldHttp2Handler.java b/example/src/main/java/io/netty/example/http2/helloworld/server/HelloWorldHttp2Handler.java index 76cd3fdb04..a148c3a9b3 100644 --- a/example/src/main/java/io/netty/example/http2/helloworld/server/HelloWorldHttp2Handler.java +++ b/example/src/main/java/io/netty/example/http2/helloworld/server/HelloWorldHttp2Handler.java @@ -78,7 +78,11 @@ public final class HelloWorldHttp2Handler extends Http2ConnectionHandler impleme Http2Headers headers = new DefaultHttp2Headers().status(OK.codeAsText()); encoder().writeHeaders(ctx, streamId, headers, 0, false, ctx.newPromise()); encoder().writeData(ctx, streamId, payload, 0, true, ctx.newPromise()); - ctx.flush(); + try { + flush(ctx); + } catch (Throwable cause) { + onError(ctx, cause); + } } @Override