andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix a bug where HttpContents are freed too early

Browse Source
This commit is contained in:
Trustin Lee 2013-01-17 00:50:43 +09:00
parent 4ee11cd36f
commit e95d3de1ff
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
codec-http/src/main/java/io/netty/handler/codec/http/HttpObjectAggregator.java
View File

@ -158,6 +158,7 @@ public class HttpObjectAggregator extends MessageToMessageDecoder<HttpObject> {
CompositeByteBuf content = (CompositeByteBuf) currentMessage.data(); CompositeByteBuf content = (CompositeByteBuf) currentMessage.data();
if (content.readableBytes() > maxContentLength - chunk.data().readableBytes()) { if (content.readableBytes() > maxContentLength - chunk.data().readableBytes()) {
chunk.free();
// TODO: Respond with 413 Request Entity Too Large // TODO: Respond with 413 Request Entity Too Large
// and discard the traffic or close the connection. // and discard the traffic or close the connection.
// No need to notify the upstream handlers - just log. // No need to notify the upstream handlers - just log.
@ -208,6 +209,11 @@ public class HttpObjectAggregator extends MessageToMessageDecoder<HttpObject> {
} }
} }
@Override
protected void freeInboundMessage(HttpObject msg) throws Exception {
// decode() frees HttpContents.
}
@Override @Override
public void beforeAdd(ChannelHandlerContext ctx) throws Exception { public void beforeAdd(ChannelHandlerContext ctx) throws Exception {
this.ctx = ctx; this.ctx = ctx;