andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Reduce objects by directly implement interface in internal implementations of DefaultHttp2RemoteFlowController

Browse Source 
Motivation:

We can just implement the interfaces directly and so reduce object creation in DefaultHttp2RemoteFlowController.

Modifications:

Directly implement the interfaces.

Result:

Less object creation.
This commit is contained in:
Norman Maurer 2018-01-27 03:33:58 +01:00 committed by Scott Mitchell
parent 49d1db4113
commit e975c5f6fe
1 changed files with 18 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

39
codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2RemoteFlowController.java
View File

@ -15,7 +15,6 @@
package io.netty.handler.codec.http2; package io.netty.handler.codec.http2;
import io.netty.channel.ChannelHandlerContext; import io.netty.channel.ChannelHandlerContext;
import io.netty.handler.codec.http2.StreamByteDistributor.Writer;
import io.netty.util.internal.UnstableApi; import io.netty.util.internal.UnstableApi;
import io.netty.util.internal.logging.InternalLogger; import io.netty.util.internal.logging.InternalLogger;
import io.netty.util.internal.logging.InternalLoggerFactory; import io.netty.util.internal.logging.InternalLoggerFactory;
@ -543,15 +542,14 @@ public class DefaultHttp2RemoteFlowController implements Http2RemoteFlowControll
/** /**
* Abstract class which provides common functionality for writability monitor implementations. * Abstract class which provides common functionality for writability monitor implementations.
*/ */
private class WritabilityMonitor { private class WritabilityMonitor implements StreamByteDistributor.Writer {
private boolean inWritePendingBytes; private boolean inWritePendingBytes;
private long totalPendingBytes; private long totalPendingBytes;
private final Writer writer = new StreamByteDistributor.Writer() {
@Override @Override
public void write(Http2Stream stream, int numBytes) { public final void write(Http2Stream stream, int numBytes) {
state(stream).writeAllocatedBytes(numBytes); state(stream).writeAllocatedBytes(numBytes);
} }
};
/** /**
* Called when the writability of the underlying channel changes. * Called when the writability of the underlying channel changes.
@ -630,7 +628,7 @@ public class DefaultHttp2RemoteFlowController implements Http2RemoteFlowControll
// Make sure we always write at least once, regardless if we have bytesToWrite or not. // Make sure we always write at least once, regardless if we have bytesToWrite or not.
// This ensures that zero-length frames will always be written. // This ensures that zero-length frames will always be written.
for (;;) { for (;;) {
if (!streamByteDistributor.distribute(bytesToWrite, writer) || if (!streamByteDistributor.distribute(bytesToWrite, this) ||
(bytesToWrite = writableBytes()) <= 0 || (bytesToWrite = writableBytes()) <= 0 ||
!isChannelWritable0()) { !isChannelWritable0()) {
break; break;
@ -675,23 +673,22 @@ public class DefaultHttp2RemoteFlowController implements Http2RemoteFlowControll
* isChannelWritable() * isChannelWritable()
* </pre> * </pre>
*/ */
private final class ListenerWritabilityMonitor extends WritabilityMonitor { private final class ListenerWritabilityMonitor extends WritabilityMonitor implements Http2StreamVisitor {
private final Listener listener; private final Listener listener;
private final Http2StreamVisitor checkStreamWritabilityVisitor = new Http2StreamVisitor() {
@Override
public boolean visit(Http2Stream stream) throws Http2Exception {
FlowState state = state(stream);
if (isWritable(state) != state.markedWritability()) {
notifyWritabilityChanged(state);
}
return true;
}
};
ListenerWritabilityMonitor(Listener listener) { ListenerWritabilityMonitor(Listener listener) {
this.listener = listener; this.listener = listener;
} }
@Override
public boolean visit(Http2Stream stream) throws Http2Exception {
FlowState state = state(stream);
if (isWritable(state) != state.markedWritability()) {
notifyWritabilityChanged(state);
}
return true;
}
@Override @Override
void windowSize(FlowState state, int initialWindowSize) { void windowSize(FlowState state, int initialWindowSize) {
super.windowSize(state, initialWindowSize); super.windowSize(state, initialWindowSize);
@ -771,7 +768,7 @@ public class DefaultHttp2RemoteFlowController implements Http2RemoteFlowControll
private void checkAllWritabilityChanged() throws Http2Exception { private void checkAllWritabilityChanged() throws Http2Exception {
// Make sure we mark that we have notified as a result of this change. // Make sure we mark that we have notified as a result of this change.
connectionState.markedWritability(isWritableConnection()); connectionState.markedWritability(isWritableConnection());
connection.forEachActiveStream(checkStreamWritabilityVisitor); connection.forEachActiveStream(this);
} }
} }
} }