From e9b28e76a366dadaf6da4375c503f670ec3e3ae4 Mon Sep 17 00:00:00 2001 From: Aayush Atharva Date: Thu, 29 Oct 2020 15:10:49 +0530 Subject: [PATCH] Change variable name of Http2Headers (#10743) Motivation: `addHttp2ToHttpHeaders(int streamId, Http2Headers sourceHeaders, FullHttpMessage destinationMessage, boolean addToTrailer)` should match `addHttp2ToHttpHeaders(int streamId, Http2Headers inputHeaders, HttpHeaders outputHeaders, HttpVersion httpVersion, boolean isTrailer, boolean isRequest)`. However, the `Http2Headers` variable name is different. Modification: Changed `sourceHeaders` to `inputHeaders`. Result: Variable and JavaDoc naming now correct. --- .../io/netty/handler/codec/http2/HttpConversionUtil.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/HttpConversionUtil.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/HttpConversionUtil.java index 924361435d..b0c544be88 100644 --- a/codec-http2/src/main/java/io/netty/handler/codec/http2/HttpConversionUtil.java +++ b/codec-http2/src/main/java/io/netty/handler/codec/http2/HttpConversionUtil.java @@ -331,15 +331,15 @@ public final class HttpConversionUtil { * Translate and add HTTP/2 headers to HTTP/1.x headers. * * @param streamId The stream associated with {@code sourceHeaders}. - * @param sourceHeaders The HTTP/2 headers to convert. + * @param inputHeaders The HTTP/2 headers to convert. * @param destinationMessage The object which will contain the resulting HTTP/1.x headers. * @param addToTrailer {@code true} to add to trailing headers. {@code false} to add to initial headers. * @throws Http2Exception If not all HTTP/2 headers can be translated to HTTP/1.x. * @see #addHttp2ToHttpHeaders(int, Http2Headers, HttpHeaders, HttpVersion, boolean, boolean) */ - public static void addHttp2ToHttpHeaders(int streamId, Http2Headers sourceHeaders, + public static void addHttp2ToHttpHeaders(int streamId, Http2Headers inputHeaders, FullHttpMessage destinationMessage, boolean addToTrailer) throws Http2Exception { - addHttp2ToHttpHeaders(streamId, sourceHeaders, + addHttp2ToHttpHeaders(streamId, inputHeaders, addToTrailer ? destinationMessage.trailingHeaders() : destinationMessage.headers(), destinationMessage.protocolVersion(), addToTrailer, destinationMessage instanceof HttpRequest); }