andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

DefaultChannelHandlerInvoker should work with non AbstractChannelHandlerContext sub-classes.

Browse Source 
Motivation:

DefaultChannelHandlerInvoker currently blindly cast to AbstractChannelHandlerContext without checking if the ChannelHandlerContext is really a sub-type of it. It should check it first and if not just use slow-path implementation.

Modifications:

Do instanceof check first and if it fails just create a new Runnable instance of used the cached.

Result:

DefaultChannelHandlerInvoker works with any ChannelHandlerContext implementations.
This commit is contained in:
Norman Maurer 2016-04-01 14:42:39 +02:00
parent 4e779cd6b0
commit ea94336689
1 changed files with 56 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

72
transport/src/main/java/io/netty/channel/DefaultChannelHandlerInvoker.java
View File

@ -167,10 +167,20 @@ public class DefaultChannelHandlerInvoker implements ChannelHandlerInvoker {
if (executor.inEventLoop()) {
invokeChannelReadCompleteNow(ctx);
} else {
AbstractChannelHandlerContext dctx = (AbstractChannelHandlerContext) ctx;
Runnable task = dctx.invokeChannelReadCompleteTask;
if (task == null) {
dctx.invokeChannelReadCompleteTask = task = new Runnable() {
Runnable task;
if (ctx instanceof AbstractChannelHandlerContext) {
AbstractChannelHandlerContext dctx = (AbstractChannelHandlerContext) ctx;
task = dctx.invokeChannelReadCompleteTask;
if (task == null) {
dctx.invokeChannelReadCompleteTask = task = new Runnable() {
@Override
public void run() {
invokeChannelReadCompleteNow(ctx);
}
};
}
} else {
task = new OneTimeTask() {
@Override
public void run() {
invokeChannelReadCompleteNow(ctx);
@ -186,10 +196,20 @@ public class DefaultChannelHandlerInvoker implements ChannelHandlerInvoker {
if (executor.inEventLoop()) {
invokeChannelWritabilityChangedNow(ctx);
} else {
AbstractChannelHandlerContext dctx = (AbstractChannelHandlerContext) ctx;
Runnable task = dctx.invokeChannelWritableStateChangedTask;
if (task == null) {
dctx.invokeChannelWritableStateChangedTask = task = new Runnable() {
Runnable task;
if (ctx instanceof AbstractChannelHandlerContext) {
AbstractChannelHandlerContext dctx = (AbstractChannelHandlerContext) ctx;
task = dctx.invokeChannelWritableStateChangedTask;
if (task == null) {
dctx.invokeChannelWritableStateChangedTask = task = new Runnable() {
@Override
public void run() {
invokeChannelWritabilityChangedNow(ctx);
}
};
}
} else {
task = new OneTimeTask() {
@Override
public void run() {
invokeChannelWritabilityChangedNow(ctx);
@ -309,10 +329,20 @@ public class DefaultChannelHandlerInvoker implements ChannelHandlerInvoker {
if (executor.inEventLoop()) {
invokeReadNow(ctx);
} else {
AbstractChannelHandlerContext dctx = (AbstractChannelHandlerContext) ctx;
Runnable task = dctx.invokeReadTask;
if (task == null) {
dctx.invokeReadTask = task = new Runnable() {
Runnable task;
if (ctx instanceof AbstractChannelHandlerContext) {
AbstractChannelHandlerContext dctx = (AbstractChannelHandlerContext) ctx;
task = dctx.invokeReadTask;
if (task == null) {
dctx.invokeReadTask = task = new Runnable() {
@Override
public void run() {
invokeReadNow(ctx);
}
};
}
} else {
task = new OneTimeTask() {
@Override
public void run() {
invokeReadNow(ctx);
@ -350,10 +380,20 @@ public class DefaultChannelHandlerInvoker implements ChannelHandlerInvoker {
if (executor.inEventLoop()) {
invokeFlushNow(ctx);
} else {
AbstractChannelHandlerContext dctx = (AbstractChannelHandlerContext) ctx;
Runnable task = dctx.invokeFlushTask;
if (task == null) {
dctx.invokeFlushTask = task = new Runnable() {
Runnable task;
if (ctx instanceof AbstractChannelHandlerContext) {
AbstractChannelHandlerContext dctx = (AbstractChannelHandlerContext) ctx;
task = dctx.invokeFlushTask;
if (task == null) {
dctx.invokeFlushTask = task = new Runnable() {
@Override
public void run() {
invokeFlushNow(ctx);
}
};
}
} else {
task = new OneTimeTask() {
@Override
public void run() {
invokeFlushNow(ctx);