andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Merge pull request #114 from chavdar/113-fix

Browse Source 
113 fix
This commit is contained in:
Norman Maurer 2011-12-11 00:15:35 -08:00
commit eb4773d209
2 changed files with 33 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/main/java/org/jboss/netty/channel/DefaultChannelPipeline.java
View File

@ -277,8 +277,8 @@ public class DefaultChannelPipeline implements ChannelPipeline {
if (!sameName) { if (!sameName) {
name2ctx.remove(ctx.getName()); name2ctx.remove(ctx.getName());
name2ctx.put(newName, newCtx);
} }
name2ctx.put(newName, newCtx);
ChannelHandlerLifeCycleException removeException = null; ChannelHandlerLifeCycleException removeException = null;
ChannelHandlerLifeCycleException addException = null; ChannelHandlerLifeCycleException addException = null;

32
src/test/java/org/jboss/netty/channel/TestDefaultChannelPipeline.java Normal file
View File

@ -0,0 +1,32 @@
package org.jboss.netty.channel;
import static org.junit.Assert.*;
import org.junit.Test;
public class TestDefaultChannelPipeline {
@Test
public void testReplaceChannelHandler() {
DefaultChannelPipeline pipeline = new DefaultChannelPipeline();
SimpleChannelHandler handler1 = new SimpleChannelHandler();
pipeline.addLast("handler1", handler1);
pipeline.addLast("handler2", handler1);
pipeline.addLast("handler3", handler1);
assertTrue(pipeline.get("handler1") == handler1);
assertTrue(pipeline.get("handler2") == handler1);
assertTrue(pipeline.get("handler3") == handler1);
SimpleChannelHandler newHandler1 = new SimpleChannelHandler();
pipeline.replace("handler1", "handler1", newHandler1);
assertTrue(pipeline.get("handler1") == newHandler1);
SimpleChannelHandler newHandler3 = new SimpleChannelHandler();
pipeline.replace("handler3", "handler3", newHandler3);
assertTrue(pipeline.get("handler3") == newHandler3);
SimpleChannelHandler newHandler2 = new SimpleChannelHandler();
pipeline.replace("handler2", "handler2", newHandler2);
assertTrue(pipeline.get("handler2") == newHandler2);
}
}