From ec20902613a0384300584a4900a11e118bcecf69 Mon Sep 17 00:00:00 2001 From: nmittler Date: Mon, 21 Sep 2015 16:21:23 -0700 Subject: [PATCH] Don't set HTTP/2 flow controller ctx to null Motivation: We currently set the flow controller ChannelHandlerContexts to null when the channel becomes inactive. This is bad :) Modifications: Just remove that code in Http2ConnectionHandler Result: Fixes #4240 --- .../io/netty/handler/codec/http2/Http2ConnectionHandler.java | 2 -- 1 file changed, 2 deletions(-) diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ConnectionHandler.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ConnectionHandler.java index bf7e6435f8..2eb280b694 100644 --- a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ConnectionHandler.java +++ b/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ConnectionHandler.java @@ -428,8 +428,6 @@ public class Http2ConnectionHandler extends ByteToMessageDecoder implements Http // Call super class first, as this may result in decode being called. super.channelInactive(ctx); if (byteDecoder != null) { - encoder.flowController().channelHandlerContext(null); - decoder.flowController().channelHandlerContext(null); byteDecoder.channelInactive(ctx); byteDecoder = null; }