andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

We should re-use the same handler instance as its sharable in the example

Browse Source 
Motivation:

We should re-use the same handler instance as its sharable. 

Modification:

Re-use instance

Result:

More correct example
This commit is contained in:
pifuant 2018-05-30 15:09:18 +08:00 committed by Norman Maurer
parent 4b728cd5bc
commit ec91c40bf7
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
example/src/main/java/io/netty/example/echo/EchoServer.java
View File

@ -51,6 +51,7 @@ public final class EchoServer {
// Configure the server. // Configure the server.
EventLoopGroup bossGroup = new NioEventLoopGroup(1); EventLoopGroup bossGroup = new NioEventLoopGroup(1);
EventLoopGroup workerGroup = new NioEventLoopGroup(); EventLoopGroup workerGroup = new NioEventLoopGroup();
final EchoServerHandler serverHandler = new EchoServerHandler();
try { try {
ServerBootstrap b = new ServerBootstrap(); ServerBootstrap b = new ServerBootstrap();
b.group(bossGroup, workerGroup) b.group(bossGroup, workerGroup)
@ -65,7 +66,7 @@ public final class EchoServer {
p.addLast(sslCtx.newHandler(ch.alloc())); p.addLast(sslCtx.newHandler(ch.alloc()));
} }
//p.addLast(new LoggingHandler(LogLevel.INFO)); //p.addLast(new LoggingHandler(LogLevel.INFO));
p.addLast(new EchoServerHandler()); p.addLast(serverHandler);
} }
}); });

3
example/src/main/java/io/netty/example/sctp/SctpEchoServer.java
View File

@ -37,6 +37,7 @@ public final class SctpEchoServer {
// Configure the server. // Configure the server.
EventLoopGroup bossGroup = new NioEventLoopGroup(1); EventLoopGroup bossGroup = new NioEventLoopGroup(1);
EventLoopGroup workerGroup = new NioEventLoopGroup(); EventLoopGroup workerGroup = new NioEventLoopGroup();
final SctpEchoServerHandler serverHandler = new SctpEchoServerHandler();
try { try {
ServerBootstrap b = new ServerBootstrap(); ServerBootstrap b = new ServerBootstrap();
b.group(bossGroup, workerGroup) b.group(bossGroup, workerGroup)
@ -48,7 +49,7 @@ public final class SctpEchoServer {
public void initChannel(SctpChannel ch) throws Exception { public void initChannel(SctpChannel ch) throws Exception {
ch.pipeline().addLast( ch.pipeline().addLast(
//new LoggingHandler(LogLevel.INFO), //new LoggingHandler(LogLevel.INFO),
new SctpEchoServerHandler()); serverHandler);
} }
}); });