andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fixed slow write performance on some circumstance

Browse Source
This commit is contained in:
Trustin Lee 2008-08-20 02:14:52 +00:00
parent e9e1b0ebe6
commit edd969b384
1 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/main/java/org/jboss/netty/channel/socket/nio/NioWorker.java
View File

@ -57,6 +57,7 @@ class NioWorker implements Runnable {
private final AtomicBoolean started = new AtomicBoolean();
volatile Thread thread;
volatile Selector selector;
final AtomicBoolean wakenUp = new AtomicBoolean();
final Object selectorGuard = new Object();
NioWorker(int bossId, int id, Executor executor) {
@ -137,6 +138,7 @@ class NioWorker implements Runnable {
boolean shutdown = false;
Selector selector = this.selector;
for (;;) {
wakenUp.set(false);
synchronized (selectorGuard) {
// This empty synchronization block prevents the selector
// from acquiring its lock.
@ -379,6 +381,10 @@ class NioWorker implements Runnable {
if ((interestOps & SelectionKey.OP_WRITE) == 0) {
interestOps |= SelectionKey.OP_WRITE;
key.interestOps(interestOps);
if (Thread.currentThread() != worker.thread &&
worker.wakenUp.compareAndSet(false, true)) {
selector.wakeup();
}
changed = true;
}
break;
@ -438,6 +444,10 @@ class NioWorker implements Runnable {
if ((interestOps & SelectionKey.OP_WRITE) != 0) {
interestOps &= ~SelectionKey.OP_WRITE;
key.interestOps(interestOps);
if (Thread.currentThread() != worker.thread &&
worker.wakenUp.compareAndSet(false, true)) {
selector.wakeup();
}
changed = true;
}
break;
@ -550,6 +560,10 @@ class NioWorker implements Runnable {
case 0:
if (key.interestOps() != interestOps) {
key.interestOps(interestOps);
if (Thread.currentThread() != worker.thread &&
worker.wakenUp.compareAndSet(false, true)) {
selector.wakeup();
}
changed = true;
}
break;