andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fixing broken HTTP/2 benchmark

Browse Source 
Motivation:

The `NoPriorityByteDistibbutionBenchmark` was broken with a recent commit.

Modifications:

Fixed the benchmark to use the new HTTP2 handler builder.

Result:

It builds.
This commit is contained in:
nmittler 2015-12-18 09:39:20 -08:00
parent 9b171beb92
commit ee56a4a5c6
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
microbench/src/main/java/io/netty/microbench/http2/NoPriorityByteDistributionBenchmark.java
View File

@ -20,6 +20,7 @@ import io.netty.handler.codec.http2.DefaultHttp2Connection;
import io.netty.handler.codec.http2.DefaultHttp2RemoteFlowController; import io.netty.handler.codec.http2.DefaultHttp2RemoteFlowController;
import io.netty.handler.codec.http2.Http2Connection; import io.netty.handler.codec.http2.Http2Connection;
import io.netty.handler.codec.http2.Http2ConnectionHandler; import io.netty.handler.codec.http2.Http2ConnectionHandler;
import io.netty.handler.codec.http2.Http2ConnectionHandlerBuilder;
import io.netty.handler.codec.http2.Http2Exception; import io.netty.handler.codec.http2.Http2Exception;
import io.netty.handler.codec.http2.Http2FrameAdapter; import io.netty.handler.codec.http2.Http2FrameAdapter;
import io.netty.handler.codec.http2.Http2RemoteFlowController; import io.netty.handler.codec.http2.Http2RemoteFlowController;
@ -69,7 +70,6 @@ public class NoPriorityByteDistributionBenchmark extends AbstractMicrobenchmark
private Http2RemoteFlowController controller; private Http2RemoteFlowController controller;
private StreamByteDistributor distributor; private StreamByteDistributor distributor;
private AdditionalCounters counters; private AdditionalCounters counters;
private Http2ConnectionHandler handler;
private ChannelHandlerContext ctx; private ChannelHandlerContext ctx;
public NoPriorityByteDistributionBenchmark() { public NoPriorityByteDistributionBenchmark() {
@ -137,10 +137,11 @@ public class NoPriorityByteDistributionBenchmark extends AbstractMicrobenchmark
} }
controller = new DefaultHttp2RemoteFlowController(connection, new ByteCounter(distributor)); controller = new DefaultHttp2RemoteFlowController(connection, new ByteCounter(distributor));
connection.remote().flowController(controller); connection.remote().flowController(controller);
handler = new Http2ConnectionHandler.Builder() Http2ConnectionHandler handler = new Http2ConnectionHandlerBuilder()
.encoderEnforceMaxConcurrentStreams(false).validateHeaders(false) .encoderEnforceMaxConcurrentStreams(false).validateHeaders(false)
.frameListener(new Http2FrameAdapter()) .frameListener(new Http2FrameAdapter())
.build(connection); .connection(connection)
.build();
ctx = new EmbeddedChannelWriteReleaseHandlerContext( ctx = new EmbeddedChannelWriteReleaseHandlerContext(
PooledByteBufAllocator.DEFAULT, handler) { PooledByteBufAllocator.DEFAULT, handler) {
@Override @Override