andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Drop first flag that's no longer used

Browse Source 
Motivation:

Pull request for RFC6265 support had some unused flag first in ClientCookieDecoder.

Modification:

Remove unused flag first.

Result:

Cleaner code.
This commit is contained in:
Stephane Landelle 2015-01-21 15:02:21 +01:00 committed by Norman Maurer
parent c4a5c3966c
commit f0181a35ef
1 changed files with 2 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
codec-http/src/main/java/io/netty/handler/codec/http/ClientCookieDecoder.java
View File

@ -73,7 +73,6 @@ public final class ClientCookieDecoder {
int newNameStart = i;
int newNameEnd = i;
String value, rawValue;
boolean first = true;
if (i == headerLen) {
value = rawValue = null;
@ -85,7 +84,6 @@ public final class ClientCookieDecoder {
// NAME; (no value till ';')
newNameEnd = i;
value = rawValue = null;
first = false;
break keyValLoop;
} else if (curChar == '=') {
// NAME=VALUE
@ -94,7 +92,6 @@ public final class ClientCookieDecoder {
if (i == headerLen) {
// NAME= (empty value, i.e. nothing after '=')
value = rawValue = "";
first = false;
break keyValLoop;
}
@ -115,8 +112,7 @@ public final class ClientCookieDecoder {
value = newValueBuf.toString();
// only need to compute raw value for cookie
// value which is in first position
rawValue = first ? header.substring(rawValueStart, rawValueEnd) : null;
first = false;
rawValue = header.substring(rawValueStart, rawValueEnd);
break keyValLoop;
}
if (hadBackslash) {
@ -137,8 +133,7 @@ public final class ClientCookieDecoder {
// only need to compute raw value for
// cookie value which is in first
// position
rawValue = first ? header.substring(rawValueStart, rawValueEnd) : null;
first = false;
rawValue = header.substring(rawValueStart, rawValueEnd);
break keyValLoop;
}
newValueBuf.append(c);
@ -166,7 +161,6 @@ public final class ClientCookieDecoder {
if (i == headerLen) {
// NAME (no value till the end of string)
newNameEnd = i;
first = false;
value = rawValue = null;
break;
}