From f1e14d0cb2a7a7cb574428df4a9b561b413af8bc Mon Sep 17 00:00:00 2001 From: Norman Maurer Date: Mon, 10 Jul 2017 14:42:01 +0200 Subject: [PATCH] Only add / to uri if really needed. Motivation: We not need to include the start index in the check. See https://github.com/netty/netty/pull/6924#discussion_r125263918 Modifications: Change <= to < Result: More correct code. --- .../java/io/netty/handler/codec/http/HttpRequestEncoder.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/HttpRequestEncoder.java b/codec-http/src/main/java/io/netty/handler/codec/http/HttpRequestEncoder.java index 6cfd58a129..a7658d32c9 100644 --- a/codec-http/src/main/java/io/netty/handler/codec/http/HttpRequestEncoder.java +++ b/codec-http/src/main/java/io/netty/handler/codec/http/HttpRequestEncoder.java @@ -56,11 +56,11 @@ public class HttpRequestEncoder extends HttpObjectEncoder { // See https://github.com/netty/netty/issues/2732 int index = uri.indexOf(QUESTION_MARK, start); if (index == -1) { - if (uri.lastIndexOf(SLASH) <= start) { + if (uri.lastIndexOf(SLASH) < start) { needSlash = true; } } else { - if (uri.lastIndexOf(SLASH, index) <= start) { + if (uri.lastIndexOf(SLASH, index) < start) { uriCharSequence = new StringBuilder(uri).insert(index, SLASH); } }