From f20e95b41b2d8e455e368626dbf61021e046adcb Mon Sep 17 00:00:00 2001 From: Jason Tedor Date: Mon, 28 Nov 2016 18:20:23 -0500 Subject: [PATCH] Do not eagerly initialize the logger factory Motivation: For applications that set their own logger factory, they want that logger factory to be the one logger factory. Yet, Netty eagerly initializes this and then triggers initialization of other classes before the application has had a chance to set its preferred logger factory. Modifications: With this commit there are two key changes: - Netty does not attempt to eagerly initialize the default logger factory, only doing so if the application layer above Netty has not already set a logger factory - do not eagerly initialize unrelated classes from the logger factory; while the motivation behind this was to initialize ThreadLocalRandom as soon as possible in case it has to block reading from /dev/random, this can be worked around for applications where it is problematic by setting securerandom.source=file:/dev/urandom in their Java system security policy (no, it is not less secure; do not even get me started on myths about /dev/random) Result: Netty uses the logger factory that the application prefers, and does not initialize unrelated classes. --- .../netty/util/internal/logging/InternalLoggerFactory.java | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/common/src/main/java/io/netty/util/internal/logging/InternalLoggerFactory.java b/common/src/main/java/io/netty/util/internal/logging/InternalLoggerFactory.java index 49f337df49..323f1238e6 100644 --- a/common/src/main/java/io/netty/util/internal/logging/InternalLoggerFactory.java +++ b/common/src/main/java/io/netty/util/internal/logging/InternalLoggerFactory.java @@ -31,8 +31,7 @@ package io.netty.util.internal.logging; * as possible and shouldn't be called more than once. */ public abstract class InternalLoggerFactory { - private static volatile InternalLoggerFactory defaultFactory = - newDefaultFactory(InternalLoggerFactory.class.getName()); + private static volatile InternalLoggerFactory defaultFactory; @SuppressWarnings("UnusedCatchParameter") private static InternalLoggerFactory newDefaultFactory(String name) { @@ -57,6 +56,9 @@ public abstract class InternalLoggerFactory { * {@link JdkLoggerFactory}. */ public static InternalLoggerFactory getDefaultFactory() { + if (defaultFactory == null) { + defaultFactory = newDefaultFactory(InternalLoggerFactory.class.getName()); + } return defaultFactory; } @@ -88,4 +90,5 @@ public abstract class InternalLoggerFactory { * Creates a new logger instance with the specified name. */ protected abstract InternalLogger newInstance(String name); + }