andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Satisfy write promise when writing an Http2WindowUpdateFrame to Http2FrameCodec.

Browse Source 
Motivation:

When writing an Http2WindowUpdateFrame to an Http2FrameCodec, the
ChannelPromise is never satisfied, so callers cannot generically rely on the
write future being satisfied on success.

Modifications:

When writing Http2WindowUpdateFrame, Http2FrameCodec now satisfies the
ChannelPromise immediately.

Result:

The write future is satisfied on successful writes.

Fixes netty/netty#5530.
This commit is contained in:
Oliver Gould 2016-07-13 18:36:58 +00:00 committed by Norman Maurer
parent 9de90d07a9
commit f2ce28bf18
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
codec-http2/src/main/java/io/netty/handler/codec/http2/Http2FrameCodec.java
View File

@ -142,6 +142,7 @@ public class Http2FrameCodec extends ChannelDuplexHandler {
if (msg instanceof Http2WindowUpdateFrame) { if (msg instanceof Http2WindowUpdateFrame) {
Http2WindowUpdateFrame frame = (Http2WindowUpdateFrame) msg; Http2WindowUpdateFrame frame = (Http2WindowUpdateFrame) msg;
consumeBytes(frame.streamId(), frame.windowSizeIncrement()); consumeBytes(frame.streamId(), frame.windowSizeIncrement());
promise.setSuccess();
} else if (msg instanceof Http2StreamFrame) { } else if (msg instanceof Http2StreamFrame) {
writeStreamFrame((Http2StreamFrame) msg, promise); writeStreamFrame((Http2StreamFrame) msg, promise);
} else if (msg instanceof Http2GoAwayFrame) { } else if (msg instanceof Http2GoAwayFrame) {