andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix SslContextBuilder swapping client and server

Browse Source 
The 'forClient' boolean was swapped to 'forServer' in code review of #3531.
Not all locations were updated.
This commit is contained in:
Eric Anderson 2015-04-20 15:58:51 -07:00 committed by Scott Mitchell
parent 8b1f247a1a
commit f467d695be
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
handler/src/main/java/io/netty/handler/ssl/SslContextBuilder.java
View File

@ -31,7 +31,7 @@ public final class SslContextBuilder {
* Creates a builder for new client-side {@link SslContext}.
*/
public static SslContextBuilder forClient() {
return new SslContextBuilder(true);
return new SslContextBuilder(false);
}
/**
@ -41,7 +41,7 @@ public final class SslContextBuilder {
* @param keyFile a PKCS#8 private key file in PEM format
*/
public static SslContextBuilder forServer(File keyCertChainFile, File keyFile) {
return new SslContextBuilder(false).keyManager(keyCertChainFile, keyFile);
return new SslContextBuilder(true).keyManager(keyCertChainFile, keyFile);
}
/**
@ -54,7 +54,7 @@ public final class SslContextBuilder {
*/
public static SslContextBuilder forServer(
File keyCertChainFile, File keyFile, String keyPassword) {
return new SslContextBuilder(false).keyManager(keyCertChainFile, keyFile, keyPassword);
return new SslContextBuilder(true).keyManager(keyCertChainFile, keyFile, keyPassword);
}
private final boolean forServer;