andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Preliminary fix for the file descriptor starvation problem

Browse Source
This commit is contained in:
Trustin Lee 2009-10-27 06:01:13 +00:00
parent 20798ee429
commit f4a71f92ce
1 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/main/java/org/jboss/netty/channel/socket/nio/NioWorker.java
View File

@ -76,6 +76,7 @@ class NioWorker implements Runnable {
private final Object startStopLock = new Object(); private final Object startStopLock = new Object();
private final Queue<Runnable> registerTaskQueue = new LinkedTransferQueue<Runnable>(); private final Queue<Runnable> registerTaskQueue = new LinkedTransferQueue<Runnable>();
private final Queue<Runnable> writeTaskQueue = new LinkedTransferQueue<Runnable>(); private final Queue<Runnable> writeTaskQueue = new LinkedTransferQueue<Runnable>();
private volatile int cancelledKeys;
NioWorker(int bossId, int id, Executor executor) { NioWorker(int bossId, int id, Executor executor) {
this.bossId = bossId; this.bossId = bossId;
@ -189,6 +190,7 @@ class NioWorker implements Runnable {
selector.wakeup(); selector.wakeup();
} }
cancelledKeys = 0;
processRegisterTaskQueue(); processRegisterTaskQueue();
processWriteTaskQueue(); processWriteTaskQueue();
processSelectedKeys(selector.selectedKeys()); processSelectedKeys(selector.selectedKeys());
@ -570,6 +572,15 @@ class NioWorker implements Runnable {
SelectionKey key = channel.socket.keyFor(selector); SelectionKey key = channel.socket.keyFor(selector);
if (key != null) { if (key != null) {
key.cancel(); key.cancel();
int cancelledKeys = (++ worker.cancelledKeys);
if (cancelledKeys >= 128) { // FIXME hardcoded value
worker.cancelledKeys = 0;
// Reclaim the associated file descriptors immediately.
// Otherwise the process will experience sudden spike
// in the number of open files, with high chance of getting
// the 'too many open files' error.
selector.selectNow();
}
} }
channel.socket.close(); channel.socket.close();
} }