Fixed all SPDY echo tests / Handle closed old I/O channels correctly

codec-http/src/test/java/io/netty/handler/codec/spdy/NioNioSocketSpdyEchoTest.java

@@ -26,18 +26,15 @@ public class NioNioSocketSpdyEchoTest extends AbstractSocketSpdyEchoTest {
 
     @Override
     protected ChannelBootstrap newClientBootstrap() {
-        ChannelBootstrap b = new ChannelBootstrap();
+        return new ChannelBootstrap()
-        b.eventLoop(new SelectorEventLoop());
+                .eventLoop(new SelectorEventLoop())
-        b.channel(new NioSocketChannel());
+                .channel(new NioSocketChannel());
-        return b;
     }
 
     @Override
     protected ServerChannelBootstrap newServerBootstrap() {
-        ServerChannelBootstrap b = new ServerChannelBootstrap();
+        return new ServerChannelBootstrap()
-        b.eventLoop(new SelectorEventLoop(), new SelectorEventLoop());
+                .eventLoop(new SelectorEventLoop(), new SelectorEventLoop())
-        b.channel(new NioServerSocketChannel());
+                .channel(new NioServerSocketChannel());
-        return b;
     }
-
 }

codec-http/src/test/java/io/netty/handler/codec/spdy/NioOioSocketSpdyEchoTest.java

@@ -16,20 +16,26 @@
 package io.netty.handler.codec.spdy;
 
 
-import io.netty.channel.ChannelFactory;
+import io.netty.channel.ChannelBootstrap;
-import io.netty.channel.socket.nio.NioClientSocketChannelFactory;
+import io.netty.channel.ServerChannelBootstrap;
-import io.netty.channel.socket.oio.OioServerSocketChannelFactory;
+import io.netty.channel.socket.nio.NioSocketChannel;
+import io.netty.channel.socket.nio.SelectorEventLoop;
+import io.netty.channel.socket.oio.BlockingChannelEventLoop;
+import io.netty.channel.socket.oio.OioServerSocketChannel;
 
 public class NioOioSocketSpdyEchoTest extends AbstractSocketSpdyEchoTest {
 
     @Override
-    protected ChannelFactory newClientBootstrap() {
+    protected ChannelBootstrap newClientBootstrap() {
-        return new NioClientSocketChannelFactory(executor);
+        return new ChannelBootstrap()
+                .eventLoop(new SelectorEventLoop())
+                .channel(new NioSocketChannel());
     }
 
     @Override
-    protected ChannelFactory newServerBootstrap() {
+    protected ServerChannelBootstrap newServerBootstrap() {
-        return new OioServerSocketChannelFactory(executor, executor);
+        return new ServerChannelBootstrap()
+                .eventLoop(new BlockingChannelEventLoop(), new BlockingChannelEventLoop())
+                .channel(new OioServerSocketChannel());
     }
-
 }

codec-http/src/test/java/io/netty/handler/codec/spdy/OioNioSocketSpdyEchoTest.java

@@ -16,20 +16,26 @@
 package io.netty.handler.codec.spdy;
 
 
-import io.netty.channel.ChannelFactory;
+import io.netty.channel.ChannelBootstrap;
-import io.netty.channel.socket.nio.NioServerSocketChannelFactory;
+import io.netty.channel.ServerChannelBootstrap;
-import io.netty.channel.socket.oio.OioClientSocketChannelFactory;
+import io.netty.channel.socket.nio.NioServerSocketChannel;
+import io.netty.channel.socket.nio.SelectorEventLoop;
+import io.netty.channel.socket.oio.BlockingChannelEventLoop;
+import io.netty.channel.socket.oio.OioSocketChannel;
 
 public class OioNioSocketSpdyEchoTest extends AbstractSocketSpdyEchoTest {
 
     @Override
-    protected ChannelFactory newClientBootstrap() {
+    protected ChannelBootstrap newClientBootstrap() {
-        return new OioClientSocketChannelFactory(executor);
+        return new ChannelBootstrap()
+                .eventLoop(new BlockingChannelEventLoop())
+                .channel(new OioSocketChannel());
     }
 
     @Override
-    protected ChannelFactory newServerBootstrap() {
+    protected ServerChannelBootstrap newServerBootstrap() {
-        return new NioServerSocketChannelFactory(executor);
+        return new ServerChannelBootstrap()
+                .eventLoop(new SelectorEventLoop(), new SelectorEventLoop())
+                .channel(new NioServerSocketChannel());
     }
-
 }

codec-http/src/test/java/io/netty/handler/codec/spdy/OioOioSocketSpdyEchoTest.java

@@ -16,20 +16,25 @@
 package io.netty.handler.codec.spdy;
 
 
-import io.netty.channel.ChannelFactory;
+import io.netty.channel.ChannelBootstrap;
-import io.netty.channel.socket.oio.OioClientSocketChannelFactory;
+import io.netty.channel.ServerChannelBootstrap;
-import io.netty.channel.socket.oio.OioServerSocketChannelFactory;
+import io.netty.channel.socket.oio.BlockingChannelEventLoop;
+import io.netty.channel.socket.oio.OioServerSocketChannel;
+import io.netty.channel.socket.oio.OioSocketChannel;
 
 public class OioOioSocketSpdyEchoTest extends AbstractSocketSpdyEchoTest {
 
     @Override
-    protected ChannelFactory newClientBootstrap() {
+    protected ChannelBootstrap newClientBootstrap() {
-        return new OioClientSocketChannelFactory(executor);
+        return new ChannelBootstrap()
+                .eventLoop(new BlockingChannelEventLoop())
+                .channel(new OioSocketChannel());
     }
 
     @Override
-    protected ChannelFactory newServerBootstrap() {
+    protected ServerChannelBootstrap newServerBootstrap() {
-        return new OioServerSocketChannelFactory(executor, executor);
+        return new ServerChannelBootstrap()
+                .eventLoop(new BlockingChannelEventLoop(), new BlockingChannelEventLoop())
+                .channel(new OioServerSocketChannel());
     }
-
 }

transport/src/main/java/io/netty/channel/socket/oio/OioServerSocketChannel.java

@@ -153,6 +153,10 @@ public class OioServerSocketChannel extends AbstractServerChannel
 
     @Override
     protected int doRead(Queue<Object> buf) throws Exception {
+        if (socket.isClosed()) {
+            return -1;
+        }
+
         Socket s = null;
         try {
             s = socket.accept();

transport/src/main/java/io/netty/channel/socket/oio/OioSocketChannel.java

@@ -193,6 +193,9 @@ public class OioSocketChannel extends AbstractChannel
 
     @Override
     protected int doRead(ChannelBuffer buf) throws Exception {
+        if (socket.isClosed()) {
+            return -1;
+        }
         try {
             int readBytes = buf.writeBytes(is, buf.writableBytes());
             return readBytes;