From f7606ffc315eca1af8576aa28dfa1587ad275e07 Mon Sep 17 00:00:00 2001 From: Trustin Lee Date: Thu, 17 Dec 2009 09:05:46 +0000 Subject: [PATCH] Fixed a bug where the first handler's life cycle listener is not called --- .../netty/channel/DefaultChannelPipeline.java | 18 ++---------------- 1 file changed, 2 insertions(+), 16 deletions(-) diff --git a/src/main/java/org/jboss/netty/channel/DefaultChannelPipeline.java b/src/main/java/org/jboss/netty/channel/DefaultChannelPipeline.java index c948268f26..e2d7cc2cf2 100644 --- a/src/main/java/org/jboss/netty/channel/DefaultChannelPipeline.java +++ b/src/main/java/org/jboss/netty/channel/DefaultChannelPipeline.java @@ -327,10 +327,6 @@ public class DefaultChannelPipeline implements ChannelPipeline { return; } - if (!isAttached()) { - return; - } - LifeCycleAwareChannelHandler h = (LifeCycleAwareChannelHandler) ctx.getHandler(); @@ -348,10 +344,6 @@ public class DefaultChannelPipeline implements ChannelPipeline { return; } - if (!isAttached()) { - return; - } - LifeCycleAwareChannelHandler h = (LifeCycleAwareChannelHandler) ctx.getHandler(); @@ -383,10 +375,6 @@ public class DefaultChannelPipeline implements ChannelPipeline { return; } - if (!isAttached()) { - return; - } - LifeCycleAwareChannelHandler h = (LifeCycleAwareChannelHandler) ctx.getHandler(); @@ -404,10 +392,6 @@ public class DefaultChannelPipeline implements ChannelPipeline { return; } - if (!isAttached()) { - return; - } - LifeCycleAwareChannelHandler h = (LifeCycleAwareChannelHandler) ctx.getHandler(); @@ -642,9 +626,11 @@ public class DefaultChannelPipeline implements ChannelPipeline { private void init(String name, ChannelHandler handler) { DefaultChannelHandlerContext ctx = new DefaultChannelHandlerContext(null, null, name, handler); + callBeforeAdd(ctx); head = tail = ctx; name2ctx.clear(); name2ctx.put(name, ctx); + callAfterAdd(ctx); } private void checkDuplicateName(String name) {