andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Cleanup : removed unused empty arrays and simplified initialization

Browse Source
This commit is contained in:
Dmitriy Dumanskiy 2016-08-02 00:08:29 +03:00 committed by Norman Maurer
parent b427a8c8bd
commit f769bb3376
2 changed files with 18 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
buffer/src/test/java/io/netty/buffer/UnpooledTest.java
View File

@ -482,7 +482,7 @@ public class UnpooledTest {
assertFalse(buffer.isReadable()); assertFalse(buffer.isReadable());
assertEquals(0, copyInt(null).capacity()); assertEquals(0, copyInt(null).capacity());
assertEquals(0, copyInt(EMPTY_INTS).capacity()); assertEquals(0, copyInt(new int[] {}).capacity());
} }
@Test @Test
@ -502,7 +502,7 @@ public class UnpooledTest {
assertFalse(buffer.isReadable()); assertFalse(buffer.isReadable());
assertEquals(0, copyShort((short[]) null).capacity()); assertEquals(0, copyShort((short[]) null).capacity());
assertEquals(0, copyShort(EMPTY_SHORTS).capacity()); assertEquals(0, copyShort(new short[] {}).capacity());
} }
@Test @Test
@ -514,7 +514,7 @@ public class UnpooledTest {
assertFalse(buffer.isReadable()); assertFalse(buffer.isReadable());
assertEquals(0, copyShort((int[]) null).capacity()); assertEquals(0, copyShort((int[]) null).capacity());
assertEquals(0, copyShort(EMPTY_INTS).capacity()); assertEquals(0, copyShort(new int[] {}).capacity());
} }
@Test @Test
@ -534,7 +534,7 @@ public class UnpooledTest {
assertFalse(buffer.isReadable()); assertFalse(buffer.isReadable());
assertEquals(0, copyMedium(null).capacity()); assertEquals(0, copyMedium(null).capacity());
assertEquals(0, copyMedium(EMPTY_INTS).capacity()); assertEquals(0, copyMedium(new int[] {}).capacity());
} }
@Test @Test
@ -554,7 +554,7 @@ public class UnpooledTest {
assertFalse(buffer.isReadable()); assertFalse(buffer.isReadable());
assertEquals(0, copyLong(null).capacity()); assertEquals(0, copyLong(null).capacity());
assertEquals(0, copyLong(EMPTY_LONGS).capacity()); assertEquals(0, copyLong(new long[] {}).capacity());
} }
@Test @Test
@ -574,7 +574,7 @@ public class UnpooledTest {
assertFalse(buffer.isReadable()); assertFalse(buffer.isReadable());
assertEquals(0, copyFloat(null).capacity()); assertEquals(0, copyFloat(null).capacity());
assertEquals(0, copyFloat(EMPTY_FLOATS).capacity()); assertEquals(0, copyFloat(new float[] {}).capacity());
} }
@Test @Test
@ -594,7 +594,7 @@ public class UnpooledTest {
assertFalse(buffer.isReadable()); assertFalse(buffer.isReadable());
assertEquals(0, copyDouble(null).capacity()); assertEquals(0, copyDouble(null).capacity());
assertEquals(0, copyDouble(EMPTY_DOUBLES).capacity()); assertEquals(0, copyDouble(new double[] {}).capacity());
} }
@Test @Test
@ -606,7 +606,7 @@ public class UnpooledTest {
assertFalse(buffer.isReadable()); assertFalse(buffer.isReadable());
assertEquals(0, copyBoolean(null).capacity()); assertEquals(0, copyBoolean(null).capacity());
assertEquals(0, copyBoolean(EMPTY_BOOLEANS).capacity()); assertEquals(0, copyBoolean(new boolean[] {}).capacity());
} }
@Test @Test

27
common/src/main/java/io/netty/util/internal/EmptyArrays.java
View File

@ -22,23 +22,16 @@ import java.security.cert.X509Certificate;
public final class EmptyArrays { public final class EmptyArrays {
public static final byte[] EMPTY_BYTES = new byte[0]; public static final byte[] EMPTY_BYTES = {};
public static final char[] EMPTY_CHARS = new char[0]; public static final char[] EMPTY_CHARS = {};
public static final boolean[] EMPTY_BOOLEANS = new boolean[0]; public static final Object[] EMPTY_OBJECTS = {};
public static final double[] EMPTY_DOUBLES = new double[0]; public static final Class<?>[] EMPTY_CLASSES = {};
public static final float[] EMPTY_FLOATS = new float[0]; public static final String[] EMPTY_STRINGS = {};
public static final int[] EMPTY_INTS = new int[0]; public static final StackTraceElement[] EMPTY_STACK_TRACE = {};
public static final short[] EMPTY_SHORTS = new short[0]; public static final ByteBuffer[] EMPTY_BYTE_BUFFERS = {};
public static final long[] EMPTY_LONGS = new long[0]; public static final Certificate[] EMPTY_CERTIFICATES = {};
public static final Object[] EMPTY_OBJECTS = new Object[0]; public static final X509Certificate[] EMPTY_X509_CERTIFICATES = {};
public static final Class<?>[] EMPTY_CLASSES = new Class[0]; public static final javax.security.cert.X509Certificate[] EMPTY_JAVAX_X509_CERTIFICATES = {};
public static final String[] EMPTY_STRINGS = new String[0];
public static final StackTraceElement[] EMPTY_STACK_TRACE = new StackTraceElement[0];
public static final ByteBuffer[] EMPTY_BYTE_BUFFERS = new ByteBuffer[0];
public static final Certificate[] EMPTY_CERTIFICATES = new Certificate[0];
public static final X509Certificate[] EMPTY_X509_CERTIFICATES = new X509Certificate[0];
public static final javax.security.cert.X509Certificate[] EMPTY_JAVAX_X509_CERTIFICATES =
new javax.security.cert.X509Certificate[0];
private EmptyArrays() { } private EmptyArrays() { }
} }