diff --git a/transport/src/main/java/io/netty/channel/socket/nio/NioDatagramChannel.java b/transport/src/main/java/io/netty/channel/socket/nio/NioDatagramChannel.java index 8fbc9a6e82..c2619aba88 100644 --- a/transport/src/main/java/io/netty/channel/socket/nio/NioDatagramChannel.java +++ b/transport/src/main/java/io/netty/channel/socket/nio/NioDatagramChannel.java @@ -82,9 +82,7 @@ public final class NioDatagramChannel return newSocket(); } - if (PlatformDependent.javaVersion() < 7) { - throw new UnsupportedOperationException(); - } + checkJavaVersion(); try { return DatagramChannel.open(ProtocolFamilyConverter.convert(ipFamily)); @@ -93,6 +91,12 @@ public final class NioDatagramChannel } } + private static void checkJavaVersion() { + if (PlatformDependent.javaVersion() < 7) { + throw new UnsupportedOperationException("Only supported on java 7+."); + } + } + /** * Create a new instance which will use the Operation Systems default {@link InternetProtocolFamily}. */ @@ -349,39 +353,39 @@ public final class NioDatagramChannel public ChannelFuture joinGroup( InetAddress multicastAddress, NetworkInterface networkInterface, InetAddress source, ChannelPromise promise) { - if (PlatformDependent.javaVersion() >= 7) { - if (multicastAddress == null) { - throw new NullPointerException("multicastAddress"); - } - if (networkInterface == null) { - throw new NullPointerException("networkInterface"); - } + checkJavaVersion(); - try { - MembershipKey key; - if (source == null) { - key = javaChannel().join(multicastAddress, networkInterface); - } else { - key = javaChannel().join(multicastAddress, networkInterface, source); - } - - synchronized (this) { - List keys = memberships.get(multicastAddress); - if (keys == null) { - keys = new ArrayList(); - memberships.put(multicastAddress, keys); - } - keys.add(key); - } - - promise.setSuccess(); - } catch (Throwable e) { - promise.setFailure(e); - } - } else { - throw new UnsupportedOperationException(); + if (multicastAddress == null) { + throw new NullPointerException("multicastAddress"); } + + if (networkInterface == null) { + throw new NullPointerException("networkInterface"); + } + + try { + MembershipKey key; + if (source == null) { + key = javaChannel().join(multicastAddress, networkInterface); + } else { + key = javaChannel().join(multicastAddress, networkInterface, source); + } + + synchronized (this) { + List keys = memberships.get(multicastAddress); + if (keys == null) { + keys = new ArrayList(); + memberships.put(multicastAddress, keys); + } + keys.add(key); + } + + promise.setSuccess(); + } catch (Throwable e) { + promise.setFailure(e); + } + return promise; } @@ -424,9 +428,8 @@ public final class NioDatagramChannel public ChannelFuture leaveGroup( InetAddress multicastAddress, NetworkInterface networkInterface, InetAddress source, ChannelPromise promise) { - if (PlatformDependent.javaVersion() < 7) { - throw new UnsupportedOperationException(); - } + checkJavaVersion(); + if (multicastAddress == null) { throw new NullPointerException("multicastAddress"); } @@ -478,36 +481,34 @@ public final class NioDatagramChannel public ChannelFuture block( InetAddress multicastAddress, NetworkInterface networkInterface, InetAddress sourceToBlock, ChannelPromise promise) { - if (PlatformDependent.javaVersion() < 7) { - throw new UnsupportedOperationException(); - } else { - if (multicastAddress == null) { - throw new NullPointerException("multicastAddress"); - } - if (sourceToBlock == null) { - throw new NullPointerException("sourceToBlock"); - } + checkJavaVersion(); - if (networkInterface == null) { - throw new NullPointerException("networkInterface"); - } - synchronized (this) { - if (memberships != null) { - List keys = memberships.get(multicastAddress); - for (MembershipKey key: keys) { - if (networkInterface.equals(key.networkInterface())) { - try { - key.block(sourceToBlock); - } catch (IOException e) { - promise.setFailure(e); - } + if (multicastAddress == null) { + throw new NullPointerException("multicastAddress"); + } + if (sourceToBlock == null) { + throw new NullPointerException("sourceToBlock"); + } + + if (networkInterface == null) { + throw new NullPointerException("networkInterface"); + } + synchronized (this) { + if (memberships != null) { + List keys = memberships.get(multicastAddress); + for (MembershipKey key: keys) { + if (networkInterface.equals(key.networkInterface())) { + try { + key.block(sourceToBlock); + } catch (IOException e) { + promise.setFailure(e); } } } } - promise.setSuccess(); - return promise; } + promise.setSuccess(); + return promise; } /**