andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

NETTY-182 NIO server socket sometimes does not shut down

Browse Source 
* Swallow ClosedSelectorException
* channel.isBound() check for each loop
This commit is contained in:
Trustin Lee 2009-06-24 02:49:26 +00:00
parent d963f4c046
commit fa51403eb2
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/main/java/org/jboss/netty/channel/socket/nio/NioServerSocketPipelineSink.java
View File

@ -30,6 +30,7 @@ import java.net.SocketAddress;
import java.net.SocketTimeoutException;
import java.nio.channels.CancelledKeyException;
import java.nio.channels.ClosedChannelException;
import java.nio.channels.ClosedSelectorException;
import java.util.concurrent.Executor;
import java.util.concurrent.atomic.AtomicInteger;
@ -207,7 +208,7 @@ class NioServerSocketPipelineSink extends AbstractChannelSink {
}
public void run() {
for (;;) {
while (channel.isBound()) {
try {
// We do not call ServerSocketChannel.accept() directly
// because SocketTimeoutException is not raised on some
@ -238,6 +239,10 @@ class NioServerSocketPipelineSink extends AbstractChannelSink {
// raised.
} catch (CancelledKeyException e) {
// Raised by accept() when the server socket was closed.
break;
} catch (ClosedSelectorException e) {
// Raised by accept() when the server socket was closed.
break;
} catch (ClosedChannelException e) {
// Closed as requested.
break;