Make sure calling ExecutionHandler.releaseExternalResource() does not lead to a dead-lock when calling from a ChannelEventRunnable. See #200

src/test/java/org/jboss/netty/handler/execution/ExecutionHandlerTest.java

@@ -0,0 +1,128 @@
+/*
+ * Copyright 2012 The Netty Project
+ *
+ * The Netty Project licenses this file to you under the Apache License,
+ * version 2.0 (the "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at:
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ */
+package org.jboss.netty.handler.execution;
+
+import static org.junit.Assert.assertTrue;
+
+import org.jboss.netty.channel.Channel;
+import org.jboss.netty.channel.ChannelEvent;
+import org.jboss.netty.channel.ChannelFuture;
+import org.jboss.netty.channel.ChannelHandler;
+import org.jboss.netty.channel.ChannelHandlerContext;
+import org.jboss.netty.channel.ChannelPipeline;
+
+import java.util.concurrent.CountDownLatch;
+import java.util.concurrent.TimeUnit;
+
+import org.junit.Test;
+
+public class ExecutionHandlerTest {
+
+    @Test
+    public void testReleaseExternalResourceViaUpstreamEvent() throws Exception {
+        final CountDownLatch latch = new CountDownLatch(1);
+        
+        OrderedMemoryAwareThreadPoolExecutor executor = new OrderedMemoryAwareThreadPoolExecutor(10, 0L, 0L);
+        final ExecutionHandler handler = new ExecutionHandler(executor, true, true);
+        handler.handleUpstream(new TestChannelHandlerContext(handler, latch), new DummyChannelEvent());
+
+        assertTrue(latch.await(5, TimeUnit.SECONDS));
+    }
+    
+    @Test
+    public void testReleaseExternalResourceViaDownstreamEvent() throws Exception {
+        final CountDownLatch latch = new CountDownLatch(1);
+        
+        OrderedMemoryAwareThreadPoolExecutor executor = new OrderedMemoryAwareThreadPoolExecutor(10, 0L, 0L);
+        final ExecutionHandler handler = new ExecutionHandler(executor, true, true);
+        handler.handleDownstream(new TestChannelHandlerContext(handler, latch), new DummyChannelEvent());
+
+        assertTrue(latch.await(5, TimeUnit.SECONDS));
+    }
+    
+    private static final class DummyChannelEvent implements ChannelEvent {
+
+        public Channel getChannel() {
+            return null;
+        }
+
+        public ChannelFuture getFuture() {
+            return null;
+        }
+        
+    }
+    
+    private static final class TestChannelHandlerContext implements ChannelHandlerContext {
+
+        private final CountDownLatch latch;
+        private final ExecutionHandler handler;
+
+        public TestChannelHandlerContext(ExecutionHandler handler, CountDownLatch latch) {
+            this.latch = latch;
+            this.handler = handler;
+        }
+        
+        
+        public Channel getChannel() {
+            return null;
+        }
+
+        public ChannelPipeline getPipeline() {
+            return null;
+        }
+
+        public String getName() {
+            return handler.getClass().getName();
+        }
+
+        public ChannelHandler getHandler() {
+            return handler;
+        }
+
+        public boolean canHandleUpstream() {
+            return true;
+        }
+
+        public boolean canHandleDownstream() {
+            return true;
+        }
+
+        public void sendUpstream(ChannelEvent e) {
+            try {
+                handler.releaseExternalResources();
+            } catch (IllegalStateException ex) {
+                latch.countDown();
+            }
+        }
+
+        public void sendDownstream(ChannelEvent e) {
+            try {
+                handler.releaseExternalResources();
+            } catch (IllegalStateException ex) {
+                latch.countDown();
+            }
+        }
+
+        public Object getAttachment() {
+            return null;
+        }
+
+        public void setAttachment(Object attachment) {
+            
+        }
+        
+    }
+}