Reset markers when obtain PooledByteBuf.

Motivation:

When allocate a PooledByteBuf we need to ensure to also reset the markers for the readerIndex and writerIndex.

Modifications:

- Correct reset the markers
- Add test-case for it

Result:

Correctly reset markers.
This commit is contained in:
Norman Maurer 2015-05-11 10:10:31 +02:00
parent 04a9b834e4
commit ff295176b3
7 changed files with 90 additions and 47 deletions

View File

@ -1151,4 +1151,8 @@ public abstract class AbstractByteBuf extends ByteBuf {
throw new IllegalReferenceCountException(0);
}
}
void discardMarks() {
markedReaderIndex = markedWriterIndex = 0;
}
}

View File

@ -52,6 +52,7 @@ abstract class PooledByteBuf<T> extends AbstractReferenceCountedByteBuf {
this.length = length;
this.maxLength = maxLength;
setIndex(0, 0);
discardMarks();
tmpNioBuf = null;
initThread = Thread.currentThread();
}

View File

@ -0,0 +1,72 @@
/*
* Copyright 2015 The Netty Project
*
* The Netty Project licenses this file to you under the Apache License,
* version 2.0 (the "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at:
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
* License for the specific language governing permissions and limitations
* under the License.
*/
package io.netty.buffer;
import org.junit.Test;
import static org.junit.Assert.*;
public abstract class AbstractPooledByteBufTest extends AbstractByteBufTest {
private ByteBuf buffer;
protected abstract ByteBuf alloc(int length);
@Override
protected ByteBuf newBuffer(int length) {
buffer = alloc(length);
assertEquals(0, buffer.writerIndex());
assertEquals(0, buffer.readerIndex());
return buffer;
}
@Override
protected ByteBuf[] components() {
return new ByteBuf[] { buffer };
}
@Test
public void testDiscardMarks() {
ByteBuf buf = newBuffer(4);
buf.writeShort(1);
buf.skipBytes(1);
buf.markReaderIndex();
buf.markWriterIndex();
assertTrue(buf.release());
ByteBuf buf2 = newBuffer(4);
assertSame(unwrapIfNeeded(buf), unwrapIfNeeded(buf2));
buf2.writeShort(1);
buf2.resetReaderIndex();
buf2.resetWriterIndex();
assertEquals(0, buf2.readerIndex());
assertEquals(0, buf2.writerIndex());
assertTrue(buf2.release());
}
private static ByteBuf unwrapIfNeeded(ByteBuf buf) {
if (buf instanceof AdvancedLeakAwareByteBuf || buf instanceof SimpleLeakAwareByteBuf) {
return buf.unwrap();
}
return buf;
}
}

View File

@ -22,20 +22,12 @@ import static org.junit.Assert.*;
/**
* Tests big-endian direct channel buffers
*/
public class PooledBigEndianDirectByteBufTest extends AbstractByteBufTest {
private ByteBuf buffer;
public class PooledBigEndianDirectByteBufTest extends AbstractPooledByteBufTest {
@Override
protected ByteBuf newBuffer(int length) {
buffer = PooledByteBufAllocator.DEFAULT.directBuffer(length);
protected ByteBuf alloc(int length) {
ByteBuf buffer = PooledByteBufAllocator.DEFAULT.directBuffer(length);
assertSame(ByteOrder.BIG_ENDIAN, buffer.order());
assertEquals(0, buffer.writerIndex());
return buffer;
}
@Override
protected ByteBuf[] components() {
return new ByteBuf[] { buffer };
}
}

View File

@ -15,24 +15,13 @@
*/
package io.netty.buffer;
import static org.junit.Assert.*;
/**
* Tests big-endian heap channel buffers
*/
public class PooledBigEndianHeapByteBufTest extends AbstractByteBufTest {
private ByteBuf buffer;
public class PooledBigEndianHeapByteBufTest extends AbstractPooledByteBufTest {
@Override
protected ByteBuf newBuffer(int length) {
buffer = PooledByteBufAllocator.DEFAULT.heapBuffer(length);
assertEquals(0, buffer.writerIndex());
return buffer;
}
@Override
protected ByteBuf[] components() {
return new ByteBuf[] { buffer };
protected ByteBuf alloc(int length) {
return PooledByteBufAllocator.DEFAULT.heapBuffer(length);
}
}

View File

@ -22,20 +22,12 @@ import static org.junit.Assert.*;
/**
* Tests little-endian direct channel buffers
*/
public class PooledLittleEndianDirectByteBufTest extends AbstractByteBufTest {
private ByteBuf buffer;
public class PooledLittleEndianDirectByteBufTest extends AbstractPooledByteBufTest {
@Override
protected ByteBuf newBuffer(int length) {
buffer = PooledByteBufAllocator.DEFAULT.directBuffer(length).order(ByteOrder.LITTLE_ENDIAN);
protected ByteBuf alloc(int length) {
ByteBuf buffer = PooledByteBufAllocator.DEFAULT.directBuffer(length).order(ByteOrder.LITTLE_ENDIAN);
assertSame(ByteOrder.LITTLE_ENDIAN, buffer.order());
assertEquals(0, buffer.writerIndex());
return buffer;
}
@Override
protected ByteBuf[] components() {
return new ByteBuf[] { buffer };
}
}

View File

@ -22,19 +22,12 @@ import static org.junit.Assert.*;
/**
* Tests little-endian heap channel buffers
*/
public class PooledLittleEndianHeapByteBufTest extends AbstractByteBufTest {
private ByteBuf buffer;
public class PooledLittleEndianHeapByteBufTest extends AbstractPooledByteBufTest {
@Override
protected ByteBuf newBuffer(int length) {
buffer = PooledByteBufAllocator.DEFAULT.heapBuffer(length).order(ByteOrder.LITTLE_ENDIAN);
assertEquals(0, buffer.writerIndex());
protected ByteBuf alloc(int length) {
ByteBuf buffer = PooledByteBufAllocator.DEFAULT.heapBuffer(length).order(ByteOrder.LITTLE_ENDIAN);
assertSame(ByteOrder.LITTLE_ENDIAN, buffer.order());
return buffer;
}
@Override
protected ByteBuf[] components() {
return new ByteBuf[] { buffer };
}
}