From ff9ac4997d7f097620e32647e99cc20b48ea9489 Mon Sep 17 00:00:00 2001 From: Scott Mitchell Date: Mon, 17 Aug 2015 22:40:19 -0700 Subject: [PATCH] HttpResponseStatus reasonPhrase equals usage Motivation: HttpResponseStatus.reasonPhrase returns an AsciiString, but was compared using equals to a String. Other usages of the reasonPhrase also use the toString() method when not necessary. Modifications: - Use the contentEquals method Result: Correct comparison, and no toString() when not needed. --- .../java/io/netty/handler/codec/http/HttpResponseStatus.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/HttpResponseStatus.java b/codec-http/src/main/java/io/netty/handler/codec/http/HttpResponseStatus.java index bf4921d448..424b1e37ac 100644 --- a/codec-http/src/main/java/io/netty/handler/codec/http/HttpResponseStatus.java +++ b/codec-http/src/main/java/io/netty/handler/codec/http/HttpResponseStatus.java @@ -455,7 +455,7 @@ public class HttpResponseStatus implements Comparable { int code = Integer.parseInt(status.substring(0, space)); String reasonPhrase = status.substring(space + 1); HttpResponseStatus responseStatus = valueOf(code); - if (responseStatus.reasonPhrase().toString().equals(reasonPhrase)) { + if (responseStatus.reasonPhrase().contentEquals(reasonPhrase)) { return responseStatus; } else { return new HttpResponseStatus(code, reasonPhrase); @@ -507,7 +507,7 @@ public class HttpResponseStatus implements Comparable { status = valueOf(code); if (codeEnd < string.length()) { String actualReason = string.toString(codeEnd + 1, string.length()); - if (!status.reasonPhrase().equals(actualReason)) { + if (!status.reasonPhrase().contentEquals(actualReason)) { status = new HttpResponseStatus(code, actualReason); } }