184 Commits

Author SHA1 Message Date
Trustin Lee
611364e47c Suppressed unnecessary autoboxing 2009-03-13 16:28:20 +00:00
Trustin Lee
bbf32cae51 * Prettier cookie attribute names
* Removed an unused method
2009-03-13 15:49:35 +00:00
Trustin Lee
3e6f638449 Removed the unnecessary last semicolon 2009-03-13 15:48:23 +00:00
Trustin Lee
efd5af9313 Brought back the encode() method of CookieEncoder 2009-03-13 15:46:41 +00:00
Trustin Lee
b6cfc24127 Handles client-side cookie much better now 2009-03-13 15:29:54 +00:00
Trustin Lee
510a270cb4 CookieEncoder should not use a Map but use a Set because cookie name might be duplicate 2009-03-13 15:17:11 +00:00
Trustin Lee
e3f3e8ce5a Cookies can have the same name but different paths or domains - updated DefaultCookie.equals and compareTo 2009-03-13 15:15:24 +00:00
Trustin Lee
7677aafc1e * CookieDecoder is more tolerant to quoted values
* CookieDecoder now understands the first $Version attribute
2009-03-13 15:06:13 +00:00
Trustin Lee
d1bafbc65f * Fixed a problem where 'Expires' cookie attribute is misinterpreted
* CookieEncoder now uses Cookie.getVersion() to determine the cookie version instead of constructor parameter
2009-03-13 14:45:43 +00:00
Trustin Lee
32ddc4541d Updated author tags 2009-03-13 13:57:24 +00:00
Trustin Lee
f04003abbe CookieEncoder / CookieDecoder should not urlencode/urldecode attributes except for the value 2009-03-13 13:53:53 +00:00
Trustin Lee
0da3fcbe51 Fixed a bug where CookieEncoder generates a cookie with 'version=2' 2009-03-13 12:59:29 +00:00
Trustin Lee
199088a7c5 Two FIXMEs 2009-03-13 12:55:38 +00:00
Trustin Lee
a26d1e4392 Fixed a problem where CookieDecoder doesn't strip surrounding quotes for certain values 2009-03-13 12:48:23 +00:00
Trustin Lee
ede8316642 Fixed a problem where the value of commentURL and port is not double-quoted 2009-03-13 12:39:22 +00:00
Trustin Lee
9c8106948e Made CookieHeaderNames package private 2009-03-13 12:35:30 +00:00
Trustin Lee
b796a1d97b * Renamed Cookie.portList to Cookie.ports and its type from int[] to Set<Integer>
* Renamed CookieHeaderNames.PORTLIST to CookieHeaderNames.PORT
2009-03-13 12:32:47 +00:00
Andy Taylor
b8f03d60e4 added cookie v1 and v2 decoding support 2009-03-13 11:58:29 +00:00
Trustin Lee
df3ac447ff * Replaced Cookie.setPortList(int[]) with Cookie.setPortList(int...)
* Improved DefaultCooke.setPortList() integrity check
* DefaultCookie.getPortList() returns a copy
2009-03-13 11:51:19 +00:00
Andy Taylor
395d57b6eb added cookie v1 and v2 encoding support 2009-03-13 10:12:51 +00:00
Trustin Lee
35b08df70a * ChannelBuffer.writeBytes(InputStream, ...) must return an integer
* Fixed a problem where DynamicChannelBuffer doesn't expand itself for some writeBytes() calls
2009-03-12 06:40:36 +00:00
Trustin Lee
e523b8ec0f Added default constructors with sensible default values 2009-03-10 08:57:02 +00:00
Trustin Lee
4e989e20d4 Added HttpChunkAggregator 2009-03-10 08:42:19 +00:00
Trustin Lee
23a73f20d6 Fixed a bug where HttpMessage's content becomes an EMPTY_BUFFER after messageReceive event is already fired to process chunked encoding 2009-03-10 08:37:45 +00:00
Trustin Lee
445be963ae Oops. Silly mistake when creating a new string builder 2009-03-10 07:57:36 +00:00
Trustin Lee
3235c154a3 Implemented hashCode, compareTo, equals, and toString for HttpResponseStatus 2009-03-10 07:56:53 +00:00
Trustin Lee
a5ebbfb111 * all limit parameters are mandatory to create HTTP decoders now for better security
* chunks are not merged anymore for better security
* modified HTTP client example to handle HTTP chunks
2009-03-10 07:53:15 +00:00
Trustin Lee
4a72aafd56 Resolved issue: NETTY-133 Limit the length of HTTP header lines.
* Added maxHeaderSize option
* Added maxInitialLineLength option
* Overall HTTP code cleanup
2009-03-10 07:20:27 +00:00
Trustin Lee
c9b3122b6c More strict validation on HTTP headers to defend against HTTP response splitting atack 2009-03-09 21:05:49 +00:00
Trustin Lee
832ed0c198 Fixed NETTY-130 (Chunked encoding emulation for a large non-chunked HTTP request)
* Replaced mergeChunks option with maxChunkSize
* if maxChunkSize is greater than 0 and any content or chunk larger than maxChunkSize is received, it's split into multiple chunks as if a chunked request is received.
* Added unfold option to FrameDecoder and ReplayingDecoder
2009-03-09 08:50:24 +00:00
Trustin Lee
1781e0e1dd Fixed find bugs warnings 2009-03-04 14:15:59 +00:00
Trustin Lee
6ce3eebc55 Fixed find bugs warnings 2009-03-04 14:14:06 +00:00
Trustin Lee
4979cb6a21 A little bit of code clean up 2009-03-04 13:50:19 +00:00
Trustin Lee
b676175882 Actually it was being taken care of.. reverted back 2009-03-04 13:45:40 +00:00
Trustin Lee
0847720e41 Took care of the case where a message implements both HttpMessage and HttpChunk 2009-03-04 13:44:58 +00:00
Trustin Lee
39cc4bc3fb Better exception handling 2009-03-04 10:15:14 +00:00
Trustin Lee
5fdce19902 Reverted the unnecessary changes related with shutting FindBug up 2009-02-26 09:10:59 +00:00
Trustin Lee
6200d39bdd Reverted the unnecessary changes related with shutting FindBug up 2009-02-26 09:08:34 +00:00
Trustin Lee
5e64bb66e8 * Fixed a problem where CookieEncoder trims the value (it should not)
* Made sure the cookie values follow the URI encoding
2009-02-26 08:44:58 +00:00
Trustin Lee
9550c0759d Strict cookie name validation 2009-02-26 08:35:38 +00:00
Trustin Lee
b71d2d3d7f Updated fixmes for ataylor regarding cookie encoding/decoding 2009-02-26 08:06:07 +00:00
Trustin Lee
b8bc78a7d0 * Renamed HttpCookie to Cookie
* Split Cookie into an interface and its implementation (DefaultCookie)
* Renamed HttpCookieEncoder/Decoder to CookieEncoderDecoder
* Added all optional fields to Cookie
* Made Cookie.value mutable
* Revised DefaultCookie.toString
2009-02-26 07:59:37 +00:00
Trustin Lee
29b0af4f07 * Fixed a problem where query parameter components are not correctly encoded / decoded
* Changed the default charset of the query parameters to UTF-8
* Allowed a user to specify the charset of QueryStringEncoder/Decoder
2009-02-26 06:34:07 +00:00
Trustin Lee
cd6fce50bc * Extracted common code from various ChannelConfig implementations to DefaultChannelConfig and DefaultServerChannelConfig 2009-02-21 19:08:08 +00:00
Trustin Lee
874b043297 Added more TODOs 2009-02-20 13:07:03 +00:00
Trustin Lee
95b6558068 Fixed author tags 2009-02-20 12:56:44 +00:00
Trustin Lee
d550109796 Implemented Comparable, hashCode, equals, and toString for HttpCookie 2009-02-20 12:49:54 +00:00
Trustin Lee
df05ba3733 * Made CaseIgnoringComparator a singleton
* Changed HttpCookieDecoder to return a Map instead of a Set
* Optimized imports
2009-02-20 12:41:59 +00:00
Andy Taylor
fea082e689 fixed cookie support 2009-02-17 17:13:13 +00:00
Trustin Lee
1f9c8256d8 HttpMessageEncoder.getCookieHeaderName() must be protected 2009-02-17 09:50:10 +00:00