Michael Nitschinger
65ee10fbd0
[codec-memcache] Avoid NPE on channelInactive.
...
Motivation:
When no currentMessage has been set and the channel is inactive, a NPE is raised.
Modification:
Make sure that a currentMessage is available before checking the extras.
Result:
No more NPE raised potentially.
2014-04-23 11:41:44 +02:00
Michael Nitschinger
37ee6ef79a
[codec-memcache] Simplify object hierachy and remove Headers.
...
This changeset removes the separate message headers and merges the
field directly into the messages. This greatly simplifies the
object hierachy and also saves header allocations in the pipeline.
2014-03-04 13:05:30 +01:00
Michael Nitschinger
cd6b5def8d
Always upstream full memcache messages.
...
This changeset is related to #2182 , which exposes the failure in
the http codec, but the memcache codec works very similar. In addition,
better failure handling in the decoder has been added.
2014-02-24 10:42:17 +01:00
Trustin Lee
7e1db4feb7
Deprecate CombinedChannelDuplexHandler in favor of ChannelHandlerAppender
...
- Fixes #2233
2014-02-13 19:20:25 -08:00
Trustin Lee
ac70dc4546
Update the version to 4.1.0.Alpha1-SNAPSHOT
2014-02-13 18:32:26 -08:00
Trustin Lee
8837afddf8
Enable a user specify an arbitrary information with ReferenceCounted.touch()
...
- Related: #2163
- Add ResourceLeakHint to allow a user to provide a meaningful information about the leak when touching it
- DefaultChannelHandlerContext now implements ResourceLeakHint to tell where the message is going.
- Cleaner resource leak report by excluding noisy stack trace elements
2014-02-13 18:16:25 -08:00
Trustin Lee
45e70d9935
Add ReferenceCounted.touch() / Add missing retain() overrides
...
- Fixes #2163
- Inspector warnings
2014-02-13 18:10:11 -08:00
Trustin Lee
df346a023b
Change the return type of EmbeddedChannel.read*() from Object to an ad-hoc type parameter
...
.. so that there's no need to explicitly down-cast.
Fixes #2067
2014-02-13 17:19:26 -08:00
Michael Nitschinger
b17a765615
codec-memcache: prefix abstract classes with Abstract.
2014-02-13 17:09:21 -08:00
Michael Nitschinger
fcb32a77b9
codec-memcache: No need to allocate a buffer if no extra is used.
2014-02-13 17:09:13 -08:00
Trustin Lee
9840de82f0
Fix another buffer leak in BinaryMemcacheDecoderTest
2014-02-13 17:05:25 -08:00
Trustin Lee
b592a18cd1
Fix buffer leaks in BinaryMemcacheDecoderTest
2014-02-13 17:05:19 -08:00
Trustin Lee
ccd231b8f4
Fix a buffer leak in BinaryMemcacheDecoder
2014-02-13 17:05:05 -08:00
Trustin Lee
acf7dbf811
Fix buffer leaks in BinaryMemcacheEncoderTest
2014-02-13 17:04:58 -08:00
Trustin Lee
fab56bae94
Fix a buffer leak in BinaryMemcacheObjectAggregatorTest
2014-02-13 17:03:05 -08:00
Trustin Lee
d417e3dbd0
Fix a buffer leak in BinaryMemcacheObjectAggregatorTest
2014-02-13 17:02:58 -08:00
Trustin Lee
0ff98c98e2
readableBytes() ==0 -> !isReadable()
2014-02-13 16:56:35 -08:00
Trustin Lee
d31a3e4120
Hide protocol detail from users
2014-02-13 16:56:22 -08:00
Michael Nitschinger
215e75c7d9
codec-memcache: increase default buffer size and only encode extras if set.
2014-02-13 16:55:46 -08:00
Michael Nitschinger
f03c32e137
[codec-memcache] encode key directly, no need to use unpooled.
2014-02-13 16:51:51 -08:00
Michael Nitschinger
a1526bedd3
codec-memcache: removed println in test case.
2014-02-13 16:51:45 -08:00
Michael Nitschinger
183bfe8f9f
codec-memcache: fix decoding issue for value parts.
...
This changeset fixes an issue when decoding would stop if the value
comes separated in two or more packets, leading to invalid bytes read.
2014-02-13 16:51:37 -08:00
Michael Nitschinger
c78544cfaa
Avoid memory leak when encoding the key
2014-02-13 16:36:09 -08:00
Trustin Lee
d748113c7d
Abstract classes' names should start with 'Abstract'
2014-02-13 15:39:05 -08:00
Trustin Lee
71b6439c66
Fixed various inspector warnings
2014-02-13 15:38:52 -08:00
Trustin Lee
3dd7fba320
Moved constant classes out of util
2014-02-13 15:38:20 -08:00
Trustin Lee
a327a25a6c
Use StringUtil.simpleClassName(..) instead of Class.getSimpleName() where necessary
...
- Class.getSimpleName() doesn't render anonymous classes very well
- + some minor cleanup
2014-02-13 15:37:16 -08:00
Michael Nitschinger
20f6f7e018
Implementing the Binary Memcache protocol
...
This changeset implements the full memcache binary protocol spec, including
a first batch of tests. Ascii protocol and more coverage and helper classes
will follow.
2014-02-13 15:29:38 -08:00
