Commit Graph

154 Commits

Author SHA1 Message Date
Trustin Lee
e5972a7453 Use String.CASE_INSENSITIVE_ORDER instead of custom Comparator 2012-07-07 14:30:26 +09:00
norman
d6f1a82c31 Fix checkstyle 2012-07-07 14:30:25 +09:00
norman
ae2906de1e Correctly format cookies. This fix some bug which lead to expiring of cookies to not work. See #426 2012-07-07 14:30:25 +09:00
norman
8595d85e4a Port fix for #433 2012-07-07 14:30:25 +09:00
norman
166d8d9436 Minimize byte copies by using a CompositeByteBuf to concat the chunks. See #413 2012-07-07 14:30:25 +09:00
Norman Maurer
8224c95e05 Port enhancement to reduce memory copy if possible. See #412 2012-07-07 14:30:25 +09:00
Cruz Julian Bishop
20062de0d9 Changed "Gets the" to "Returns the" - Requested by @trustin 2012-07-07 14:30:25 +09:00
Cruz Julian Bishop
4379a86c4c Documentation redone for Cookie 2012-07-07 14:30:25 +09:00
Cruz Julian Bishop
e08c4ea3e0 Documentation and slight internal refactoring of HttpCodecUtil 2012-07-07 14:30:25 +09:00
Cruz Julian Bishop
c8d13e03e0 Make HttpResponse's javadoc a bit easier to read 2012-07-07 14:30:25 +09:00
Cruz Julian Bishop
d975ab365c Make HttpRequest's documentation easier to read 2012-07-07 14:30:25 +09:00
Cruz Julian Bishop
98c61e4128 Made the documentation in HttpMessage a bit easier to understand 2012-07-07 14:30:25 +09:00
Cruz Julian Bishop
eaa99efd30 Redid documentation for WebSocketUtil 2012-07-07 14:30:25 +09:00
Cruz Julian Bishop
7e35cc1ebb Fixes a bit of javadoc that was broken by a failed merge 2012-07-07 14:30:25 +09:00
Norman Maurer
a280928731 Fix SpdyHttpHeaders.setScheme setting the wrong header. See #417 2012-07-07 14:30:25 +09:00
Trustin Lee
9cc9f4e1ec Add more cookie decoding test case 2012-07-07 14:30:25 +09:00
Trustin Lee
de20883517 Add missing license headers 2012-07-07 14:30:25 +09:00
Trustin Lee
88e83462b0 Remove a method of no use 2012-07-07 14:30:25 +09:00
Trustin Lee
0c55c85d06 Make CookieEncoder and CookieDecoder stateless
- Also: CookieEncoder is split into ServerCookieEncoder and
  ClientCookieEncoder
2012-07-07 14:30:25 +09:00
Trustin Lee
217f8ce1fd Fix #218: CookieDecoder.decode() throws StackOverflowError
- Rewrote key-value decoder not using a regular expression
2012-07-07 14:30:24 +09:00
Trustin Lee
7596ad8d58 Fix #397: Allow all cookie names that conform to the RFC
- Lenient flag is not needed anymore
2012-07-07 14:30:24 +09:00
Trustin Lee
79425895e2 Fix test failures 2012-07-07 14:30:24 +09:00
Trustin Lee
1ef371b625 Fix #405: CookieEncoder should refuse to encode more than one cookie
.. if on server mode
2012-07-07 14:30:24 +09:00
Trustin Lee
a5bb2c7f77 Add ChannelMetadata and remove unnecessary disconnect() impls
- Add Channel.metadata() and remove Channel.bufferType()
- DefaultPipeline automatically redirects disconnect() request to
  close() if the channel has no disconnect operation
- Remove unnecessary disconnect() implementations
2012-07-07 14:30:24 +09:00
Trustin Lee
32188f83ac Forward-port JDK ZlibEncoder patch (#404)
- Rename ZlibEncoder/Decoder to JZlibEncoder/Decoder
- Define a new ZlibEncoder/Decoder class
- Add JdkZlibEncoder
- All JZlib* and JdkZlib* extends ZlibEncoder/Decoder
- Add ZlibCodecFactory and use it everywhere
2012-07-07 14:30:24 +09:00
Trustin Lee
91fe9f4b38 serverID -> serverId (#393 Ensure all fields follow naming convention) 2012-06-12 21:20:27 +09:00
Trustin Lee
a35aeb8cd9 StreamID -> StreamId (#393 Ensure all fields follow naming convention) 2012-06-12 21:06:45 +09:00
Trustin Lee
9bf0ad8329 ID -> Id (#393 Ensure all fields follow our naming convention) 2012-06-12 20:29:06 +09:00
Trustin Lee
60de50d89e ID -> Id (#393 Ensure all fields follow our naming convention) 2012-06-12 20:25:21 +09:00
Trustin Lee
154198a385 ID -> Id (#393 Ensure all fields follow our naming convention) 2012-06-12 20:20:24 +09:00
Trustin Lee
676b81a4cd getPersist(ed) -> isPersist(ed) (#393) 2012-06-12 20:05:12 +09:00
Trustin Lee
fdb66b6294 Add 'is' prefix to boolean getters if their meaning is ambiguous
- plus minor code cleanup
- ID -> Id or id
2012-06-12 17:58:22 +09:00
Trustin Lee
ecd0ae5406 Prefer MessageBuf over Queue where possible
- Also replaced thread safe queues with non-thread-safe ones where
  possible
- Unpooled.wrappedBuffer(Queue<T>) does not wrap MessageBuf anymore
2012-06-12 17:02:00 +09:00
Trustin Lee
e1faea035e Automatic clean-up with Eclipse
- Mostly import organization & whitespace removal
2012-06-11 23:04:04 +09:00
Trustin Lee
6211e53e86 Code clean-up based on IntelliJ code analysis 2012-06-11 22:54:28 +09:00
Trustin Lee
754392aaa9 Add ByteBuf.order(ByteOrder) method to simplify little endian access
- Removed all methods that requires ByteOrder as a parameter
  from Unpooled (formerly ByteBufs/ChannelBuffers)
  - Instead, a user calls order(ByteOrder) to get a little endian
    version of the user's buffer
  - This gives less overwhelming number of methods in Unpooled.
2012-06-11 20:24:44 +09:00
Trustin Lee
876847fd20 Merge MessageBufs and ByteBufs into Unpooled
- e.g. Unpooled.messageBuffer()
- It will make much more sense once we introduce pooling:
  - i.e. Pooled.buffer()
2012-06-11 17:02:29 +09:00
Trustin Lee
7d36f936c8 Fix failing tests 2012-06-11 11:35:07 +09:00
Trustin Lee
574d84e98e Remove ChannelBufferHolder / Add more handler interfaces for type safety
- ChannelInboundHandler and ChannelOutboundHandler does not have a type
  parameter anymore.  
- User should implement ChannelInboundMessageHandler or
  ChannelOutboundMessageHandler.
2012-06-10 12:22:32 +09:00
Trustin Lee
a849d11877 ChannelBuffers -> ByteBufs / Add MessageBuf & ChannelBuf
- Add MessageBuf which replaces java.util.Queue
- Add ChannelBuf which is common type of ByteBuf and ChannelBuf
- ChannelBuffers was renamed to ByteBufs
- Add MessageBufs
- All these changes are going to replace ChannelBufferHolder.
2012-06-10 11:31:39 +09:00
Trustin Lee
5164d91255 Rename ChannelBuffer to ByteBuf as discussed before
- ChannelBuffer gives a perception that it's a buffer of a
  channel, but channel's buffer is now a byte buffer or a message
  buffer.  Therefore letting it be as is is going to be confusing.
2012-06-10 11:08:43 +09:00
Trustin Lee
e376888d48 Replace 'Stream' with 'Byte'
- In computing, 'stream' means both byte stream and message stream,
  which is confusing.
- Also, we were already mixing stream and byte in some places and
  it's better use the terms consistently.
  (e.g. inboundByteBuffer & inbound stream)
2012-06-09 21:05:59 +09:00
Trustin Lee
468a3228a4 Fit every line into 120 columns 2012-06-08 19:28:12 +09:00
Trustin Lee
748de5ea83 Fix a compilation error 2012-06-08 10:02:44 +09:00
Trustin Lee
92cbe6f980 Support long Expires dates and commas in cookie values (#96)
- Contribution by @valodzka
2012-06-08 09:25:39 +09:00
Trustin Lee
4a23c2a6eb Fix checkstyle errors 2012-06-07 22:01:59 +09:00
Trustin Lee
10f7a31908 Fixed SpdySessionHandlerTest / Fixed NPE in EmbeddedChannel
- Some tests like SpdySessionHandlerTest accesses outbound buffer
  even before the outbound buffer is initialized by
  AbstractEmbeddedChannel's subclasses, leading to NPE at <init>.
  To fix this problem, subclasses now pass the outbound buffer as
  a constructor parameter to AbstractEmbeddedChannel.
2012-06-07 21:33:31 +09:00
Trustin Lee
994038975a Port HttpContentEncoder/Decoder to use EmbeddedStreamChannel / Cleanup
- Removed unused constructor parameter in AbstractChannel
- Re-enabled GZIP encoding in HTTP snoop example
2012-06-07 21:06:56 +09:00
Trustin Lee
8701e24b9a Add back Channel(Inbound|Outbound)(Message|Stream)HandlerAdapter
- they are useful when creating an anonymous class
- Also added back CombinedChannelHandler with extra constraints
2012-06-07 17:49:45 +09:00
Trustin Lee
ea0c9cfe79 Post-overhaul fixes / Split LoggingHandler into three
- LoggingHandler now only logs state and operations
- StreamLoggingHandler and MessageLoggingHandler log the buffer content
- Added ChannelOperationHandlerAdapter
  - Used by WriteTimeoutHandler
2012-06-07 16:56:21 +09:00