Norman Maurer
d34daebeca
[ #1238 ] Correctly log the content of the MessageBuf and not depend on MessageBuf.toString()
...
Add an extra static method to BufUtil which will convert the content of any MessaBuf implementation to a String
2013-04-08 09:45:00 +02:00
Norman Maurer
2a162eb140
Rename method to better reflect usage
2013-04-08 08:06:46 +02:00
Norman Maurer
2508c76e97
[ #1246 ] Fix cpu-spinning regression in HashedWheelTimer
...
Also remove the usage of System.currentTimeMillis() completely here to make it more consistent and correct
2013-04-08 07:01:08 +02:00
Norman Maurer
ded09fc778
No need t let SpdyOrHttpChooser extends ChannelDuplexHandler
2013-04-08 06:45:10 +02:00
Norman Maurer
3305a7df82
Also provide implementation for flush out of the box
2013-04-07 11:54:13 +02:00
Norman Maurer
b36e815026
[ #1241 ] Fix NPE in AbstractTrafficShapingHandler and the logic
2013-04-07 11:02:32 +02:00
Norman Maurer
8632d9011e
[ #1239 ] Fix possible NPE while fail flush futures during close
2013-04-05 19:23:49 +02:00
Trustin Lee
d299eeb485
Fix a bug in AbstractTrafficShapingHandler.getTimeToWait() where it doesn't work OK when system time goes back.
2013-04-05 13:44:51 +09:00
Trustin Lee
7ccbcb90af
Upgrade to netty-build-19
2013-04-05 05:38:24 +09:00
Andrei Pozolotin
a3e760a003
fix #1234 - duplicate package-info.java errors in eclipse requires release of netty-build v 19 and netty-parent update.
2013-04-05 05:38:05 +09:00
Trustin Lee
0ac31ae846
Make Unpooled*ByteBuf public so that ByteBufAllocator implementor can extend it
2013-04-04 17:26:14 +09:00
Trustin Lee
05bc0ba17f
Fix checkstyle
2013-04-04 16:47:10 +09:00
Trustin Lee
6dfa455f9e
Fix compiler warnings
2013-04-04 16:31:41 +09:00
Norman Maurer
4505e7f1b3
Make sure OP_WRITE is correctly cleared when using FileRegion and other NioTasks
2013-04-04 08:38:58 +02:00
Trustin Lee
c03179c81c
Clean up try/catch blocks / Prefer 'throw' to 'fireExceptionCaught'
2013-04-04 15:00:07 +09:00
Trustin Lee
3b9994455a
Saner field order
2013-04-04 14:53:32 +09:00
Trustin Lee
03955428bc
Ensure BufUtil.release() is called even if writeBytes() fails in writeAndRelease()
2013-04-04 14:50:25 +09:00
Trustin Lee
015e60b00f
Clean up catch blocks
...
- No need to have nested try blocks because the catch block catches everything and rethrows it
- No need to do instanceof-checks
2013-04-04 14:48:30 +09:00
Trustin Lee
c25fd78ca0
No need to have nested try blocks
...
.. because the catch block catches everything and rethrows it
2013-04-04 14:44:52 +09:00
Trustin Lee
788b88b7af
Make sure to release the buffer when it's written to the next byte buffer
...
.. otherwise it will leak.
2013-04-04 14:37:54 +09:00
Trustin Lee
46540578fc
Optimize OutputMessageBuf.drainToNextInbound/Outbound()
...
- Return early when the buffer is empty
- Keep only the number of byte buffers
- Remove unnecessary null check in the loop (because we know buffer is not empty at certain point)
2013-04-04 14:32:48 +09:00
Trustin Lee
8a672c2800
Proper assertion instead of blindly clearing the OutputMessageBuf
2013-04-04 14:11:24 +09:00
Norman Maurer
7ee2adb587
Move drain logic to OutputMessageBuf and optimize it as far as possible
2013-04-03 18:52:57 +02:00
Norman Maurer
1675e61f5b
Share same ThreadLocal for all decoder/encoders to minimize memory usage
2013-04-03 18:19:35 +02:00
Norman Maurer
94ef7dc1b9
Optimize to minimize volatile reads to access next buffer in codec framework
2013-04-03 18:03:55 +02:00
Norman Maurer
9828267165
Fix performance regression which was caused by calling the fireInboundBufferUpdated() a way to often
...
* Also use a ThreadLocal for the decoder buffer to safe space as it is cheap
2013-04-03 17:07:52 +02:00
Trustin Lee
c3559ddbda
Fix misleading example in ByteBuf
2013-04-03 22:18:38 +09:00
Trustin Lee
baf9ecfe7b
Fix IndexOutOfBoundsException raised when numHeapArenas and numDirectArenas differ
...
- Fixes #1227
2013-04-03 22:15:34 +09:00
Trustin Lee
8fef511390
Fix typo
2013-04-03 22:08:43 +09:00
Norman Maurer
af4b71a00e
Remove special handling of Object[] in codec framework (a.k.a unfolding)
...
- Fixes #1229
- Primarily written by @normanmaurer and revised by @trustin
This commit removes the notion of unfolding from the codec framework
completely. Unfolding was introduced in Netty 3.x to work around the
shortcoming of the codec framework where encode() and decode() did not
allow generating multiple messages.
Such a shortcoming can be fixed by changing the signature of encode()
and decode() instead of introducing an obscure workaround like
unfolding. Therefore, we changed the signature of them in 4.0.
The change is simple, but backward-incompatible. encode() and decode()
do not return anything. Instead, the codec framework will pass a
MessageBuf<Object> so encode() and decode() can add the generated
messages into the MessageBuf.
2013-04-03 21:44:54 +09:00
Trustin Lee
cd0b5ec2db
Keep Socket/SctpTestPermutation from creating too many event loops
...
- Also made the event loops created by *TestPermutation use daemon threads for simplicity (i.e. no need to shut down the event loops)
2013-04-03 18:06:46 +09:00
Trustin Lee
117ad8acd7
Add MultithreadEventLoopGroup.DEFAULT_EVENT_LOOP_THREADS / Add DefaultThreadFactory
...
- Allow overriding the default thread factory when a user specified no thread factory
2013-04-03 17:49:30 +09:00
Trustin Lee
312a35dfed
Remove MultithreadEventExecutorGroup.DEFAULT_POOL_SIZE
...
- We should never define a default nThread for MultithreadEventExecutorGroup because we don't know what a user do with it.
2013-04-03 17:15:25 +09:00
Trustin Lee
b7797917ab
Deprecate Bootstrap.shutdown() and use EventLoopGroup.shutdown() wherever possible
...
There are still some tests that use Bootstrap.shutdown() though. They need non-trivial refactoring, which will come soon.
2013-04-03 16:15:33 +09:00
Andrew Cox
3f8a830963
Fix DefaultChannelPipeline.first() so that it returns null when only the sentinel handlers remain (this is how DefaultChannelPipeline.last() works already)
2013-04-03 06:55:55 +02:00
Trustin Lee
2ffa083d3c
Allow overriding the default allocator properties and log them / Prettier log
2013-04-03 12:08:01 +09:00
Trustin Lee
0f3dc0409a
Log various properties at startup time for easier diagnosis
2013-04-03 11:44:30 +09:00
Norman Maurer
bcb0b83b44
Use unfoldAndAdd(..) for now
2013-04-02 13:58:15 +02:00
Trustin Lee
f95dbb7a4d
Make HttpPostRequestDecoder.addHttpData() and getFileUpload() protected
...
.. so that a user can extend it to get notified when changes are made
2013-04-02 16:07:31 +09:00
George Cao
436380c41e
Fix Javadoc issues. Replace Upstream with Inbound and Downstream with Outbound.
2013-04-02 15:13:39 +09:00
Norman Maurer
2e3b8f13ea
Revert "Let ProtobufEncoder extend MessageToByteEncoder which makes more sense. Related to [ #1222 ]"
...
This reverts commit 6a9d055f57
.
2013-04-02 07:56:49 +02:00
Norman Maurer
d9ac6638f4
[ #1221 ] Make sure HttpObjectAggregator 100-Continue buffer is not released
2013-04-02 07:38:46 +02:00
Norman Maurer
6a9d055f57
Let ProtobufEncoder extend MessageToByteEncoder which makes more sense. Related to [ #1222 ]
2013-04-02 07:17:45 +02:00
Norman Maurer
a0fca93128
[ #1222 ] Correctly handle the case when a MessageToMessageEncoder encodes to ByteBuf and the next outbound buffer is of type ByteBuf
2013-04-02 07:17:10 +02:00
Norman Maurer
96bf71e814
Let EventExecutorGroup extend ScheduledExecutorService as it shares quite some semantic
2013-04-01 13:56:46 +02:00
Prajwal Tuladhar
05850da863
enable checkstyle for test source directory and fix checkstyle errors
2013-03-30 13:18:57 +01:00
Adam Vandenberg
8e23ab6886
Fix typo in BufType javadoc
2013-03-29 21:47:55 +09:00
Prajwal Tuladhar
c2cd99d90c
upgrade to maven 3.0.5
...
As Netty is using its own CI now
2013-03-28 21:49:36 +01:00
Jeff Pinner
b4b0be4e53
SPDY: allow multiple notification of closeSessionFuture
2013-03-28 15:15:09 +01:00
Norman Maurer
5a7f049fe2
[ #1202 ] Fix javadoc
2013-03-28 10:01:26 +01:00