Trustin Lee
fbfebb1fd9
Code cleanup
2009-03-04 14:08:31 +00:00
Trustin Lee
4979cb6a21
A little bit of code clean up
2009-03-04 13:50:19 +00:00
Trustin Lee
b676175882
Actually it was being taken care of.. reverted back
2009-03-04 13:45:40 +00:00
Trustin Lee
0847720e41
Took care of the case where a message implements both HttpMessage and HttpChunk
2009-03-04 13:44:58 +00:00
Trustin Lee
35ac9ef38e
Fixed a bug: NETTY-129 CompositeChannelBuffer.getBytes(offset, GatheringByteChannel, length) doesn't respect offset and length parameter
2009-03-04 13:43:56 +00:00
Trustin Lee
cd3859b002
proper handling of cancelled keys
2009-03-04 13:04:28 +00:00
Trustin Lee
4d95e233bc
* Removed an unnecessary override in MemoryAwareThreadPoolExecutor
...
* Updated Find Bugs filter
2009-03-04 10:54:55 +00:00
Trustin Lee
f04ca5b970
Shut eclipse compiler up
2009-03-04 10:54:00 +00:00
Trustin Lee
39ec19078c
Code clean up
2009-03-04 10:35:55 +00:00
Trustin Lee
3a8b92929e
Reduced too broad catch block
2009-03-04 10:26:34 +00:00
Trustin Lee
9e623c9cb1
Fixed inconsistent synchronization
2009-03-04 10:24:27 +00:00
Trustin Lee
7d00231a60
Fixed inconsistent synchronization
2009-03-04 10:24:13 +00:00
Trustin Lee
39cc4bc3fb
Better exception handling
2009-03-04 10:15:14 +00:00
Trustin Lee
2dc5463e93
Fixed issue: NETTY-128 Unable to run netty client with a Security Manager
2009-03-03 09:54:34 +00:00
Trustin Lee
9bbce4a223
Fixed a bug where a dynamic buffer's readerIndex goes out of sync on expansion
2009-02-26 11:28:21 +00:00
Trustin Lee
86bc09159d
Fixed APIviz errors
2009-02-26 11:02:43 +00:00
Trustin Lee
2321499c8c
There was no need to introduce a thread local to avoid event recursion
2009-02-26 10:51:03 +00:00
Trustin Lee
903c530ae0
Fixed a problem where NioWorker.writeNow() doesn't work when it's called recursively
...
* Added a boolean thread local variable to check if writeNow() has been called by itself
2009-02-26 10:32:33 +00:00
Trustin Lee
1ff58978a2
Fixed a bug where DefaultChannelFuture.isSuccess() returns true even if the future is not done yet
2009-02-26 09:28:37 +00:00
Trustin Lee
ae7fb55d62
Removed printlns
2009-02-26 09:14:33 +00:00
Trustin Lee
284fc4db44
Removed println
2009-02-26 09:13:26 +00:00
Trustin Lee
5fdce19902
Reverted the unnecessary changes related with shutting FindBug up
2009-02-26 09:10:59 +00:00
Trustin Lee
6200d39bdd
Reverted the unnecessary changes related with shutting FindBug up
2009-02-26 09:08:34 +00:00
Trustin Lee
0132b00091
Fixed a couple findbugs warnings
2009-02-26 09:05:01 +00:00
Trustin Lee
a8d51cfad8
* Forgot to check in the http example code which was affected by the recent refactoring on Cookies
...
* Removed a FIXME in LocalTransportRegister - it's just an example.
2009-02-26 09:02:47 +00:00
Trustin Lee
5e64bb66e8
* Fixed a problem where CookieEncoder trims the value (it should not)
...
* Made sure the cookie values follow the URI encoding
2009-02-26 08:44:58 +00:00
Trustin Lee
9550c0759d
Strict cookie name validation
2009-02-26 08:35:38 +00:00
Trustin Lee
b71d2d3d7f
Updated fixmes for ataylor regarding cookie encoding/decoding
2009-02-26 08:06:07 +00:00
Trustin Lee
b8bc78a7d0
* Renamed HttpCookie to Cookie
...
* Split Cookie into an interface and its implementation (DefaultCookie)
* Renamed HttpCookieEncoder/Decoder to CookieEncoderDecoder
* Added all optional fields to Cookie
* Made Cookie.value mutable
* Revised DefaultCookie.toString
2009-02-26 07:59:37 +00:00
Trustin Lee
29b0af4f07
* Fixed a problem where query parameter components are not correctly encoded / decoded
...
* Changed the default charset of the query parameters to UTF-8
* Allowed a user to specify the charset of QueryStringEncoder/Decoder
2009-02-26 06:34:07 +00:00
Trustin Lee
63cb4a023f
Implemented AbstractXnioChannels.handleWritable() properly (needs cleanup and optimization though)
2009-02-26 01:38:29 +00:00
Trustin Lee
49c0f33461
Improved AbstractXnioChannelHandler to use ReceiveBufferSizePredictor
2009-02-26 01:29:11 +00:00
Trustin Lee
23b13eeafe
More interfaces for the XNIO transport
2009-02-25 15:19:54 +00:00
Trustin Lee
d2274f75da
Introduced more interfaces to the XNIO transport
2009-02-25 15:11:26 +00:00
Trustin Lee
13c68c7643
* Made ChannelConfig.setOption() public
2009-02-25 14:53:31 +00:00
Trustin Lee
988fff225f
Better exception handling on a connection attempt
2009-02-25 14:47:27 +00:00
Trustin Lee
94e8f31bfa
Added more todo for the xnio transport
2009-02-25 10:43:03 +00:00
Trustin Lee
fe220d42ec
2009-02-25 10:40:26 +00:00
Trustin Lee
214a26b529
Fixed a problem where XNIO transport doesn't work for the serverside
2009-02-25 10:34:17 +00:00
Trustin Lee
c3bd292f73
Fixed a problem where XnioChannelRegistry fails to find a server channel if IPv6 local address is specified
2009-02-25 10:21:35 +00:00
Trustin Lee
9043fdb622
Related issue: NETTY-75 XNIO transport
...
* The preliminary initial implementation of the XNIO transport
2009-02-25 10:10:03 +00:00
Trustin Lee
0c27f015bf
* Better exception handling on bind failure in ServerBootstrap
...
* Fixed a problem where UnfailingChannelFuture doesn't tell what exception cause the IllegalStateException
2009-02-24 04:58:19 +00:00
Trustin Lee
ae22b0aaa1
Fixed failing tests
2009-02-21 19:34:22 +00:00
Trustin Lee
547af08bc6
* Made sure ServerBootstrap accepts only ServerChannelFactory
...
* Validation first, state check later
2009-02-21 19:32:32 +00:00
Trustin Lee
f6ee08090a
* Added ServerChannelFactory
...
* All ChannelFactories that creates a ServerChannel now implements ServerChannelFactory
2009-02-21 19:29:38 +00:00
Trustin Lee
cd341609fa
* Renamed Local*ChannelFactory to DefaultLocal*ChannelFactory
...
* Local*ChannelFactories are now interfaces
2009-02-21 19:24:49 +00:00
Trustin Lee
b56bdd89dd
Marked some classes as final in the http tunneling socket transport
2009-02-21 19:21:12 +00:00
Trustin Lee
3d7214ba61
* Renamed LocalServerChannel to DefaultLocalServerChannel
...
* Added LocalServerChannel interface
* Covariant return types for Local*ChannelFactory
2009-02-21 19:15:30 +00:00
Trustin Lee
0e443c3a02
Added ThreadLocalBoolean and replaced unnecessary anonymous classes
2009-02-21 19:12:03 +00:00
Trustin Lee
cd6fce50bc
* Extracted common code from various ChannelConfig implementations to DefaultChannelConfig and DefaultServerChannelConfig
2009-02-21 19:08:08 +00:00
Trustin Lee
fdd74f252b
* Renamed AbstractLocalChannel to DefaultLocalChannel
...
* Removed unnecessary subclasses of DefaultLocalChannel
* Added LocalChannel interface
2009-02-21 18:41:21 +00:00
Trustin Lee
e1b5806560
* Removed AbstractServerChannel.getLocalAddress() to enforce the use of covariant return types in its subclasses
...
* Renamed LocalChannel to AbstractLocalChannel
2009-02-21 18:34:27 +00:00
Trustin Lee
2ab02caa67
Implemented two more methods in AbstractServerChannel
2009-02-21 09:32:29 +00:00
Trustin Lee
874b043297
Added more TODOs
2009-02-20 13:07:03 +00:00
Trustin Lee
8872294728
FIXME
2009-02-20 12:57:51 +00:00
Trustin Lee
95b6558068
Fixed author tags
2009-02-20 12:56:44 +00:00
Trustin Lee
d550109796
Implemented Comparable, hashCode, equals, and toString for HttpCookie
2009-02-20 12:49:54 +00:00
Trustin Lee
df05ba3733
* Made CaseIgnoringComparator a singleton
...
* Changed HttpCookieDecoder to return a Map instead of a Set
* Optimized imports
2009-02-20 12:41:59 +00:00
Andy Taylor
fea082e689
fixed cookie support
2009-02-17 17:13:13 +00:00
Trustin Lee
aa36f446f5
Forgot to commit
2009-02-17 10:07:25 +00:00
Trustin Lee
1f9c8256d8
HttpMessageEncoder.getCookieHeaderName() must be protected
2009-02-17 09:50:10 +00:00
Trustin Lee
6671cd34fa
Indentation
...
Made HttpTunnelingSocketChannelConfig invisible to a user
2009-02-17 09:47:28 +00:00
Trustin Lee
3922fb8a44
HttpTunnelClientSocket -> HttpTunnelingClientSocket
...
HttpTunnelSocket -> HttpTunnelingSocket
2009-02-17 09:45:32 +00:00
Trustin Lee
4bd06dfdb1
Fixed indentation
2009-02-17 07:17:03 +00:00
Trustin Lee
5281ef6aa7
Added HttpTunnelAddress.toString()
2009-02-17 07:14:23 +00:00
Trustin Lee
a77664bf8f
* Fixed compiler warnings
...
* HttpTunnelAddress should have proper hashCode, equals, and compareTo
2009-02-17 07:13:47 +00:00
Trustin Lee
5eb3a748c2
Fixed compiler warnings
...
Renamed reConnect to reconnect
2009-02-17 07:09:18 +00:00
Trustin Lee
b174d2f2e0
Padding for ID string
2009-02-16 14:32:40 +00:00
Andy Taylor
c05f70bdcf
renamed servlets
2009-02-16 13:27:27 +00:00
Andy Taylor
e977bbf9fe
renamed servlets
2009-02-16 13:27:06 +00:00
Trustin Lee
121c88d7e2
* Removed TimeBasedUuidGenerator
...
* Fixed a bug where DefaultChannelGroup doesn't recognize the new Integer ID
2009-02-16 12:02:06 +00:00
Trustin Lee
149d97d013
* Fixed issue: NETTY-125 (Backward incompatible) Use an integer as a Channel ID instead of UUID
...
* More concise Channel.toString() and ChannelEvent.toString() implementations
2009-02-16 11:59:33 +00:00
Andy Taylor
9e60db4078
added TunnelAddress
2009-02-16 11:40:37 +00:00
Andy Taylor
2b7427de4f
renamed to HttpTunnel.....
2009-02-16 10:33:43 +00:00
Andy Taylor
1a96b48026
added ClientSocketChannelFactory to ServletClientSocketChannelFactory constructor
2009-02-16 10:21:44 +00:00
Trustin Lee
4f391f5bbc
ReplayingDecoder should not throw an IllegalStateException even if a decoder implementation returns null when state transition occurred at least.
2009-02-15 12:47:12 +00:00
Trustin Lee
6370d06fb3
Lowered the shared resource explosion detection threshold and changed the log level from warn to debug just in case it's false positive
2009-02-13 13:28:35 +00:00
Trustin Lee
3d355eb48a
Added misuse detection to MemoryAwareThreadPoolExecutor and HashedWheelTimer, where a user can create too many instances
2009-02-13 12:41:46 +00:00
Trustin Lee
065218fd10
Forgot to mark one more volatile member transient
2009-02-13 11:53:05 +00:00
Trustin Lee
06d5f5264e
LocalChannelREgistry should use ConcurrentHashMap
2009-02-13 11:51:53 +00:00
Trustin Lee
5f2f072d69
Fixed a couple bugs in IdleStateHandler, caused by blind copy and paste
2009-02-13 11:33:22 +00:00
Trustin Lee
c153fd5bd0
Fixed an infinite recursion in Base64
2009-02-13 10:37:10 +00:00
Trustin Lee
db18337762
* Fixed most Find Bugs warnings
...
* Added UnreplayableOperationException
2009-02-13 10:21:28 +00:00
Trustin Lee
fb64aa94b5
Fixed a bug found by Find Bugs
2009-02-13 09:14:41 +00:00
Trustin Lee
ae004b5331
Fixed some problems reported by Find Bugs (mostly to shut it up)
2009-02-13 09:11:42 +00:00
Trustin Lee
7e8a1cd9c2
Code cleanup
2009-02-13 08:55:06 +00:00
Trustin Lee
d9c0befe24
Fixed equality comparison methods of DefaultChannelGroup
2009-02-13 08:17:35 +00:00
Trustin Lee
b22a578538
Prettier DefaultChannelGroup.toString()
2009-02-13 07:52:38 +00:00
Trustin Lee
1896c90207
* Removed ChannelGroupFactory that causes memory leak
...
* Added the default constructor for DefaultChannelGroup
2009-02-13 07:51:46 +00:00
Trustin Lee
e8665ea867
Added a convenience constructor to LocalAddress
2009-02-13 06:53:22 +00:00
Trustin Lee
395fcbbd29
Simplified LocalAddress implementation - no more global reference map that causes memory leak
2009-02-13 06:52:04 +00:00
Trustin Lee
1b28c126c5
Fixed a problem where DefaultNioSocketChannelConfig allowed incorrect configuration of write buffer watermark values
2009-02-13 06:36:30 +00:00
Trustin Lee
65048c930f
Made DirectChannelBufferFactory's preallocatedBufferCapacity configurable
2009-02-13 06:25:29 +00:00
Trustin Lee
91d7a329d4
* Renamed Concurrent*Weak*HashMap to Concurrent*WeakKey*HashMap to avoid confusion
...
* Added some FIXMEs related with potential memory leak
2009-02-13 06:19:10 +00:00
Trustin Lee
8aff5914d9
Added IdleState-aware ChannelHandler implementations
2009-02-13 06:05:21 +00:00
Trustin Lee
7b721ef1d4
Prettier LocalAddress.toString()
2009-02-13 04:51:36 +00:00
Trustin Lee
fa8890580e
Indentation
2009-02-13 04:41:01 +00:00
Trustin Lee
bf6a7db90a
Added more convenience constructors to HashedWheelTimer
2009-02-13 04:29:56 +00:00
Trustin Lee
789bfd3221
Changed the type of second unit timeout from long to int
2009-02-13 04:24:29 +00:00
Trustin Lee
11478edb5b
Fixed NPE
2009-02-13 04:17:36 +00:00
Trustin Lee
b49f8d8353
* Renamed the callback methods for Read/WriteTimeoutHandler
...
* More convenient exception handling
2009-02-12 15:41:58 +00:00
Trustin Lee
b06e33f5ee
Changed the default time unit to SECONDS
2009-02-12 15:33:28 +00:00
Trustin Lee
7f16fa352a
Removed unnecessary variable in IdleStateHandler
2009-02-12 15:31:39 +00:00
Trustin Lee
2c8f669030
Added IdleState.ALL_IDLE - was able to simplify even more
2009-02-12 15:29:35 +00:00
Trustin Lee
cbd2dec0fd
* Reverted back recent changes
...
* Renamed IdlenessHandler to IdleStateHandler
* Renamed IdlenessEvent to IdleStateEvent
* Added IdleState enum
2009-02-12 15:21:25 +00:00
Trustin Lee
2c3e7565fa
Implemented both idleness event roughly (needs some fix)
2009-02-12 11:03:10 +00:00
Trustin Lee
ed69d8bc15
Added another missing class
2009-02-12 10:51:38 +00:00
Trustin Lee
eab8623f4a
Added the missing class
2009-02-12 10:51:06 +00:00
Trustin Lee
0e5f798889
* Removed the getter methods in IdlenedssEvent and replaced them with subtypes
...
** Added ReaderIdlenessEvent and WriterIdlenessEvent
* Added protected methods which enables a user to override what to do on idleness / timeout
2009-02-12 10:50:43 +00:00
Trustin Lee
59b67420bf
Prettier output
2009-02-12 07:44:51 +00:00
Trustin Lee
2ebce4c987
Better keep-alive behavior
2009-02-12 07:39:20 +00:00
Trustin Lee
431151b8e5
Fixed issue: NETTY-107 - HttpMessageDecoder can not handle the content with no 'Content-Length' header.
2009-02-12 07:32:53 +00:00
Trustin Lee
2d682dc2a3
Fixed NETTY-107 HttpMessageDecoder can not handle the content with no 'Content-Length' header.
...
* Added HttpMessage.getContentLength(int defaultValue)
* Renamed state enum values
2009-02-12 07:17:29 +00:00
Trustin Lee
5faa7e9ea8
Removed unnecessary boxing / unboxing
2009-02-12 07:09:51 +00:00
Trustin Lee
e787378024
US-ASCII -> ASCII
2009-02-12 07:03:35 +00:00
Trustin Lee
912c66b931
Forgot to encode the last chunk correctly
2009-02-12 07:01:26 +00:00
Trustin Lee
cf1b915340
Improved the HttpServer example to demonstrate chunked encoding support
2009-02-12 06:44:52 +00:00
Trustin Lee
2a555082bb
Implemented chunked encoding support for the HTTP encoder
2009-02-12 06:37:22 +00:00
Trustin Lee
602c99c532
Fixed a problem where the last chunk is decoded too early
2009-02-12 06:27:17 +00:00
Trustin Lee
ebe77cef21
Fixed a 'shouldn't reach here' error
2009-02-12 06:26:05 +00:00
Trustin Lee
5ee6da3892
Fixed a bug where HttpRequest message is decoded twice
2009-02-12 06:25:13 +00:00
Trustin Lee
2ac8d11a34
Fixed a problem where DefaultHttpChunk.isLast returns a wrong value
2009-02-12 06:22:06 +00:00
Trustin Lee
44d56d2c1a
Added HttpChunk message for users who want to receive the content chunk by chunk
2009-02-12 06:09:29 +00:00
Trustin Lee
b6c992de8b
More optimistic initial line buffer size
2009-02-12 05:49:19 +00:00
Trustin Lee
a4fe52559b
More robust CR/LF handling in chunked encoding
2009-02-12 05:48:25 +00:00
Trustin Lee
9125ff5616
Fixed more issues related with chunked encoding
2009-02-12 05:41:22 +00:00
Trustin Lee
fb74832dc8
* Removed the usage of unnecessary state variable
...
* Renamed READ_CRLF to READ_END_OF_CHUNK
2009-02-12 05:28:55 +00:00
Trustin Lee
66423e0c1d
More robust chunk size parser
2009-02-12 05:23:39 +00:00
Trustin Lee
44498e067f
* Improved the detection of chunked encoding
...
* Fixed broken chunk length parser
2009-02-12 05:16:38 +00:00
Trustin Lee
01b0beab50
Typo
2009-02-12 05:14:16 +00:00
Trustin Lee
1243baa05b
More robust HTTP message decoding
2009-02-12 05:10:25 +00:00
Trustin Lee
9cdc4a959e
Better white space handling in HTTP
2009-02-12 05:02:22 +00:00
Trustin Lee
0198da7b6c
Related issue: NETTY-116 HTTP issues including chunked request / response patch
...
* Applied Dave's patch for QueryStringDecoder
2009-02-12 04:39:17 +00:00
Trustin Lee
32738273e0
Related issue: NETTY-116 HTTP issues including chunked request / response patch
...
* Applied Dave's patch for HttpMessageDecoder
2009-02-12 04:37:48 +00:00
Trustin Lee
334ea6f6e6
Now that there are two MessageEvent implementation, there's no point of having Channels.messageEvent() - a user could just create a new instance by calling the respective implementation's constructor
2009-02-11 09:56:28 +00:00
Trustin Lee
2b5a00e8b8
Removed unused code block
2009-02-11 09:53:14 +00:00
Trustin Lee
73cb446310
Removed the usage of Channels.messageEvent() which is obsolete
2009-02-11 09:52:36 +00:00
Trustin Lee
2030411759
Reverted r825 which doesn't make much sense
2009-02-11 09:47:53 +00:00
Trustin Lee
84aa72a70f
Made sure all timeout and idle time can be disabled with the non-positive constructor parameters
2009-02-11 09:38:24 +00:00
Trustin Lee
665db38994
Removed unused field
2009-02-11 09:32:41 +00:00
Trustin Lee
a09303785e
Removed unnecessary exception triggering
2009-02-11 09:32:17 +00:00
Trustin Lee
3acbe08eac
Code clean up
2009-02-11 09:24:28 +00:00
Trustin Lee
3f009da453
Resolved issue: NETTY-124 Clean the constants in HttpHeaders
...
* Reorganized HttpHeaders and added a bunch of constants
2009-02-11 08:48:39 +00:00
Trustin Lee
f44d9eced8
Added a TODO item
2009-02-11 06:14:07 +00:00
Trustin Lee
859f9a37a2
ChannelEvent implementations don't need to be public - package private is just enough because all events can be fired and created using Channels.
2009-02-11 06:03:00 +00:00
Trustin Lee
587c0ac27f
Added IdlenessHandler, IdlenessEvent, and DefaultIdlenessEvent
2009-02-11 05:59:35 +00:00
Trustin Lee
51b33c3678
Reverting back the latest change in ChannelState - not a good idea
2009-02-11 05:49:39 +00:00
Trustin Lee
2ee72abaaf
Added ChannelState.EXTENDED to support custom channel state like channel idleness
2009-02-11 05:45:53 +00:00
Trustin Lee
6e4f6b164c
* Renamed ChannelTimeoutException to TimeoutException
...
* Renamed ChannelReadTimeoutException to ReadTimeoutException
* Renamed ChannelWriteTimeoutException to WriteTimeoutException
2009-02-11 05:41:44 +00:00
Trustin Lee
d966ae57fc
Typo in comments
2009-02-11 05:36:37 +00:00
