Commit Graph

1671 Commits

Author SHA1 Message Date
Trustin Lee
b29d55aa38 Fixed issue: NETTY-216 HTTP Cookie missing HTTPOnly property
* Added Cookie.httpOnly property
* Added support for HTTPOnly to CookieEncoder and CookieDecoder
2009-08-27 06:48:27 +00:00
Trustin Lee
7388b961a6 Fixed indentation 2009-08-27 06:44:12 +00:00
Trustin Lee
b083f9eb2e Removed unnecessary printStackTrace 2009-08-27 06:24:14 +00:00
Trustin Lee
df72c4b7ee Better comment 2009-08-27 06:23:11 +00:00
Trustin Lee
32d9d026a1 Release ChunkedInput immediately on partial failure 2009-08-27 06:22:03 +00:00
Trustin Lee
925a99a572 Simplified Chunked resource management 2009-08-27 06:14:28 +00:00
Trustin Lee
347131e0fa Fixed issue: NETTY-215 ChunkedWriteHandler stops handling write queue when ChunkedInput.nextChunk() fails.
* Fixed a bad file descriptor error
2009-08-27 05:56:40 +00:00
Trustin Lee
6dc0b12020 Fixed issue: NETTY-215 ChunkedWriteHandler stops handling write queue when ChunkedInput.nextChunk() fails.
* Fixed related infinite event loop
2009-08-27 05:49:04 +00:00
Trustin Lee
a09b750c2f Fixed issue: NETTY-215 ChunkedWriteHandler stops handling write queue when ChunkedInput.nextChunk() fails. 2009-08-27 04:53:26 +00:00
Trustin Lee
1574fc3188 Fixed issue: NETTY-214 NIO socket / datagram transport sometimes does not shut down
* Fixed a race condition in NioWorker.close() and NioDatagramWorker.close()
2009-08-27 04:23:44 +00:00
Trustin Lee
b4f0b7360d better term 2009-08-25 09:13:58 +00:00
Trustin Lee
9b20a1453c Better description of interestOps 2009-08-25 09:10:22 +00:00
Trustin Lee
0628bde12f Fixed intermittent connection attempt failure due to a bug in connect timeout handler code 2009-08-23 08:09:42 +00:00
Trustin Lee
d842533135 Fixed a failing test 2009-08-21 04:29:48 +00:00
Trustin Lee
c861adf6e0 Fixed a test failure where OioSocketServerBootstrapTest blocks indefinitely 2009-08-19 09:26:01 +00:00
Trustin Lee
adc1969d6c Fixed issue: NETTY-204 Connection timeout does not work with the NIO socket transport.
* DefaultChannelConfig.setOption() does not handle connectTimeoutMillis
2009-08-14 20:36:32 +00:00
Trustin Lee
7ffd228cbf Fixed issue: NETTY-204 Connection timeout does not work with the NIO socket transport.
* implemented connection timeout for NioClientSocketChannel
2009-08-14 20:22:50 +00:00
Trustin Lee
05ddfdab46 Remove unused method in NioProviderMetadata 2009-08-14 19:05:58 +00:00
Trustin Lee
ad4ba5f0f4 Updated Javadoc of SslHandler 2009-08-14 19:02:22 +00:00
Trustin Lee
0879d2bbbe Fixed issue: NETTY-207 The default datagram broadcast flag is different between transports
* Set the default broadcast flag of OioDatagramChannel to 'false'
2009-08-12 02:28:30 +00:00
Trustin Lee
2ab6e4b5b0 Another fix for NETTY-206 Unnecessary exception log on early disconnection 2009-08-07 11:21:39 +00:00
Trustin Lee
7c828fc87d Javadoc not to receive a question about messy data transfer anymore 2009-08-07 04:33:34 +00:00
Trustin Lee
57ed3c1ee8 Removed unnecessary String.valueOf() call in StringEncoder 2009-08-07 03:42:21 +00:00
Trustin Lee
8a35a9aad3 Fixed issue: NETTY-205 Unnecessary exception log on early disconnection
* Do not log ClosedChannelException in RegisterTask.run()
2009-08-06 11:09:54 +00:00
Trustin Lee
3cf2d83f3f Removed a unused exception class in the factorial example 2009-07-24 02:38:19 +00:00
Trustin Lee
0d5fc90dc5 Log the warning only once 2009-07-24 01:30:48 +00:00
Trustin Lee
3920158bc0 Polished all examples 2009-07-23 09:05:53 +00:00
Trustin Lee
6321bb406f More Javadoc 2009-07-23 08:26:54 +00:00
Trustin Lee
338a5cba4a Added documentation on how to implement protocol multiplexer 2009-07-23 07:10:30 +00:00
Trustin Lee
c4449a170d More Javadoc in ChannelPipeline 2009-07-23 06:58:17 +00:00
Trustin Lee
5de3114ccb Improved OMATPE javadoc 2009-07-21 10:51:34 +00:00
Trustin Lee
865705e79b More correct explanation on OMATPE extension 2009-07-21 10:41:45 +00:00
Trustin Lee
a92142e493 More advice on extending OMATPE 2009-07-21 10:33:58 +00:00
Trustin Lee
1a54f32a77 Less indentation 2009-07-21 10:27:39 +00:00
Trustin Lee
dc06648005 Better example 2009-07-21 10:27:17 +00:00
Trustin Lee
82a84d822d * Added guide on extension
* Added OMATPE.getChildExecutorKeySet()
2009-07-21 10:26:24 +00:00
Trustin Lee
23bece222a Made OrderedMemoryAwareThreadPoolExecutor extensible so that a user can use a different key to maintain the event order 2009-07-21 09:56:27 +00:00
Trustin Lee
ca19f4cdde More documentation on Channel.write() and connectionless channels 2009-07-21 09:12:28 +00:00
Trustin Lee
8ed89dbd8f Fixed a race condition in HttpTunnelingServlet which caused data corruption and duplicate write 2009-07-21 07:36:11 +00:00
Trustin Lee
a28d08936d Send a response even when I wrote something in SecureChat 2009-07-20 05:43:02 +00:00
Trustin Lee
96aee007cc Fixed unnecessary duplicate handshake exception 2009-07-20 05:35:53 +00:00
Trustin Lee
2d4dfeffaa Stylesheet that is easier on eyes 2009-07-20 05:08:04 +00:00
Trustin Lee
f671fd38ad Updated APIviz tags 2009-07-20 05:05:18 +00:00
Trustin Lee
0277a68c49 Updated APIviz tags 2009-07-20 04:50:03 +00:00
Trustin Lee
f15db3a65e Updated APIviz tags and improved Javadoc of the HTTP codec 2009-07-20 03:37:35 +00:00
Trustin Lee
5c49cae981 Reverted back to the previous MessageEvent.toString() implementation that is more correct 2009-07-18 07:49:31 +00:00
Trustin Lee
2cf7816903 Reverted back to the previous MessageEvent implementation that should perform better in most cases 2009-07-18 07:46:49 +00:00
Trustin Lee
3610fa9608 * Updated the Javadoc of MessageEvent
* Improved how getRemoteAddress() works in DownstreamMessageEvent and UpstreamMessageEvent
2009-07-18 07:43:13 +00:00
Trustin Lee
7be842be05 * MessageEvent.getRemoteAddress() does not return null anymore
* Improved the String representation of MessageEvent implementations
2009-07-18 07:38:39 +00:00
Trustin Lee
17bbe5d3ee Improved Javadoc of Channel.getRemoteAddress() 2009-07-18 07:20:03 +00:00
Trustin Lee
90329ef978 Updated APIviz tags (work in progress) 2009-07-17 12:49:32 +00:00
Trustin Lee
89a4bd9d4e Added a global flag that disables the dead lock checker (use at your own risk) 2009-07-17 10:32:17 +00:00
Trustin Lee
8ec352de7a Added ArgoUML project (work in progress) 2009-07-17 09:58:43 +00:00
Trustin Lee
37cf2553fb Fixed a broken link 2009-07-17 04:42:46 +00:00
Trustin Lee
c74fe22de3 Javadoc & null check 2009-07-16 11:20:01 +00:00
Trustin Lee
3d0ed106fc * LocalServerChannel is not a LocalChannel
* LocalChannel.getConfig() is not necessary
2009-07-16 08:11:51 +00:00
Trustin Lee
4021ef4692 Improved SslHandler Javadoc 2009-07-16 07:17:37 +00:00
Trustin Lee
827effe4e2 Fixed another dead lock in SslHandler 2009-07-15 14:39:54 +00:00
Trustin Lee
ea81870a28 Font embedding
Bigger program listing text
2009-07-15 12:04:07 +00:00
Trustin Lee
01dffb1ad8 Updated maven-jdocbook-plugin 2009-07-15 11:04:51 +00:00
Trustin Lee
f4cdf3c3f8 * Upgraded dependencies
* Re-generated Protobuf classes
2009-07-15 09:33:11 +00:00
Trustin Lee
7b61bdc08f Fixed a bug where WriteCompletionEvent is not fired for HttpTunnelingClientSocketChannel 2009-07-15 03:13:49 +00:00
Trustin Lee
cf57e4c42b Simplified HTTP tunneling example 2009-07-15 03:13:09 +00:00
Trustin Lee
43d2fb47bd Fixed a bug where Channel.write(emptyBuffer) does not complete when SslHandler is in the pipeline 2009-07-15 03:10:33 +00:00
Trustin Lee
bfaa647bba * Fixed a bug in HttpTunnelingClientSocketChannel where the HTTP request is not sent if the scheme is HTTPS
* Fixed a bug where HttpTunnelingServlet does not catch EOFException
* Added HTTPS support to the HttpTunnelingClientExample
2009-07-15 02:41:04 +00:00
Trustin Lee
5b8f9b73ec Regenerated serialVersionUID 2009-07-15 02:06:09 +00:00
Trustin Lee
046aae6ff8 Do not expose the server-side exception message to the client 2009-07-15 02:05:12 +00:00
Trustin Lee
99261232a0 * Optimized HttpTunnelingServlet.read()
* Do not strip \r\n in HttpTunnelingServlet.read()
2009-07-15 01:59:43 +00:00
Trustin Lee
44110a281e More convenience constructors in LoggingHandler 2009-07-15 01:40:16 +00:00
Trustin Lee
a53388b859 Removed the test code which was added temporarily 2009-07-14 10:54:30 +00:00
Trustin Lee
8351d6d4d0 Make sure HttpServlet returns from service() when the channel has been closed. 2009-07-14 10:53:41 +00:00
Trustin Lee
28c64f1477 Documentation cleanup 2009-07-14 10:38:59 +00:00
Trustin Lee
5fa73d2af5 Example sync between package-info.java 2009-07-14 10:37:36 +00:00
Trustin Lee
cb1c079380 Typo 2009-07-14 10:36:36 +00:00
Trustin Lee
f90f701a8d Added a link to the package summary for HttpTunnelingServlet and HttpTunnelingClientSocketChannelFactory 2009-07-14 10:35:04 +00:00
Trustin Lee
25d5023267 * Revamped the HTTP tunneling transport
** One HTTP request/response corresponds to one socket connection now
** No more reconnection
** HTTP server should not disconnect the connection or close the request or response prematurely
** Added related documentation and updated the example
2009-07-14 10:31:22 +00:00
Trustin Lee
f9c2f66f19 exceptionCaught event should be triggered on connection attempt failure 2009-07-14 09:42:54 +00:00
Trustin Lee
f59f480fb7 Code clean up 2009-07-14 05:28:07 +00:00
Trustin Lee
2ff93e8705 Removed unnecessary member variables in IdleStateHandler 2009-07-11 19:04:27 +00:00
Trustin Lee
fecfadb853 Fixed issue: NETTY-191 Raise ChannelClosedException only once when many queued write requests failed. 2009-07-09 06:29:03 +00:00
Trustin Lee
7c78539cd5 Commented out debugging purpose printlns 2009-07-09 06:12:25 +00:00
Trustin Lee
0fa25a96a0 Accurate NIO constraint level determination for IBM JDK 6 2009-07-09 06:11:32 +00:00
Trustin Lee
75688a719d Allow 0 (use default) for backlog value 2009-07-08 20:48:00 +00:00
Trustin Lee
cae3010d6e Fixed performance regression which occurs when a user tries to write something in channelConnected() 2009-07-08 19:55:34 +00:00
Trustin Lee
d7d0877ede Forgot to revert the experimental change 2009-07-08 18:30:47 +00:00
Trustin Lee
050c2c793f Calling accept() many times doesn't seem to help at all 2009-07-08 18:30:14 +00:00
Trustin Lee
14e8f0a75e Some system calls can be called later to improve accept() performance 2009-07-08 18:13:56 +00:00
Trustin Lee
f414e425e7 Set daemon thread flag for NIO constraint level autodetector thread 2009-07-08 13:36:54 +00:00
Trustin Lee
4497d9362a Fixed issue: NETTY-189 ConnectException: connection refused in Local transport
* Made sure local address is unregistered only when necessary
2009-07-08 13:24:29 +00:00
Trustin Lee
580a6e491a Fixed indefinite blocking 2009-07-08 11:44:36 +00:00
Trustin Lee
31ec36f3bb Optimized accept throughput by removing the usage of a temporary selector 2009-07-08 11:43:00 +00:00
Trustin Lee
53beb9c7e6 Fixed issue: NETTY-188 ClosedChannelException in the proxy example
* Made sure all write requests are flushed before closing a channel
2009-07-08 06:03:15 +00:00
Trustin Lee
142bce4560 Fixed issue: NETTY-187 Subsitute ReplayingDecoder with FrameDecoder without losing stored buffer
* Added ReplayingDecoder.actualReadableBytes()
2009-07-06 11:32:01 +00:00
Trustin Lee
81cb42f37e Indentation 2009-06-30 11:36:01 +00:00
Trustin Lee
6805ea719b Fixed a problem where HttpTunnelingClientSocketChannel.setInterestOps() returns a wrong future 2009-06-30 11:22:26 +00:00
Trustin Lee
f0233fc1b8 Removed a resolved issue marker 2009-06-30 11:19:27 +00:00
Trustin Lee
0d263b85e5 No more awaitUninterruptible 2009-06-30 11:16:45 +00:00
Trustin Lee
78dbbe7661 Fixed bugs caused by today's refactoring 2009-06-30 11:16:01 +00:00
Trustin Lee
d35a8d29b1 Eliminated unnecessary use of thread pool in the HTTP tunneling transport 2009-06-30 10:30:48 +00:00
Trustin Lee
012066cfa9 Used org.jboss.netty.handler.codec.http instead of custom decoder for maximum compatibility 2009-06-30 10:03:41 +00:00
Trustin Lee
307c00e073 Traceable exception message 2009-06-30 09:52:47 +00:00
Trustin Lee
cc13dba498 Traceable exception message 2009-06-30 09:52:00 +00:00
Trustin Lee
9ef9b3753e Added Set-Cookie2 to HttpHeaders.Names 2009-06-30 09:42:34 +00:00
Trustin Lee
281b4507df HttpMessage.getHeaders() never returns null for convenience 2009-06-30 09:39:07 +00:00
Trustin Lee
6158f7772f Added more HTTP header constants useful for MIME representation 2009-06-30 09:29:35 +00:00
Trustin Lee
c8a9142ec7 Put some notes about the current issues with HTTP tunneling transport implementation 2009-06-30 09:19:34 +00:00
Trustin Lee
c0267a9e4f Store datagram channel's remoteAddress as much as possible within the extent that does not cause a race condition 2009-06-30 09:17:50 +00:00
Trustin Lee
959e72a6b0 Removed unnecessary SuppressWarnings annotations 2009-06-30 01:16:54 +00:00
Trustin Lee
e9d2c503f3 Removed unnecessary if statement in setOption 2009-06-27 12:02:25 +00:00
Trustin Lee
c2fe9778af Fixed a bug where datagram channel configurations are not reflected correctly when set via Bootstrap 2009-06-27 12:00:38 +00:00
Trustin Lee
6765d097e5 Fixed a timing issue with SSL handshake 2009-06-25 17:14:54 +00:00
Trustin Lee
1c954d2902 Javadoc 2009-06-25 10:49:26 +00:00
Trustin Lee
2997b5b40a Fixed incorrect option handling 2009-06-25 10:31:00 +00:00
Trustin Lee
de717916be Added more configuration parameters for SSLEngine 2009-06-25 10:26:04 +00:00
Trustin Lee
147173e56d * Fixed potential concurrency issues
* message queue should be final
2009-06-25 10:10:55 +00:00
Trustin Lee
1cff6738be Made HttpTunnelingSocketChannelConfig public to allow an access to the SslContext property 2009-06-25 09:55:00 +00:00
Trustin Lee
dde115525b Added SSL support to the HTTP tunneling client socket channel 2009-06-25 09:47:45 +00:00
Trustin Lee
fb8cc156f3 Fixed NPE in OioWorker.write when the socket is closed already 2009-06-25 09:18:14 +00:00
Trustin Lee
cfa4e5e4ee Fixed NETTY-184 Provide NIO equivalent for ChunkedFile and ChunkedStream
* Added ChunkedNioFile and ChunkedNioStream
* Added another convenience constructor to ChunkedFile
2009-06-25 07:45:15 +00:00
Trustin Lee
3a2350158d Fix for NETTY-183 Client-side HTTP tunneling transport logs and swallows an exceptionCaught event.
* HttpTunnelingClientSocketChannel.ServletChannelHandler does not log the caught exception anymore. The exception is propagated to the HttpTunnelingClientSocketChannel's pipeline.
* More comprehensive log message on the server side
2009-06-24 18:12:00 +00:00
Trustin Lee
8dd55b0368 NETTY-182 NIO server socket sometimes does not shut down
* Should not break the loop after swallowing exceptions in Boss.
2009-06-24 02:58:10 +00:00
Trustin Lee
fa51403eb2 NETTY-182 NIO server socket sometimes does not shut down
* Swallow ClosedSelectorException
* channel.isBound() check for each loop
2009-06-24 02:49:26 +00:00
Trustin Lee
d963f4c046 Backported upstream updates for LinkedTransferQueue (NETTY-181) 2009-06-23 16:08:15 +00:00
Trustin Lee
590ebcc394 Fixed issue: NETTY-180 Channel.getRemoteAddress() can return null for a received MessageEvent when ExecutionHandler is in the pipeline.
* DatagramChannel implementations cache localAddresses now
* DatagramChannel implementations don't cache remoteAddress because a user can disconnect and then connect again.  However, MessageEvent.getRemoteAddress() will always have correct remoteAddress value, so it shouldn't be a problem at all.
2009-06-23 07:52:12 +00:00
Trustin Lee
5698904374 Fixed issue: NETTY-180 Channel.getRemoteAddress() can return null for a received MessageEvent when ExecutionHandler is in the pipeline.
* All Channel implementations but DatagramChannel now cache localAddress and remoteAddress so that they do not return null even after the connection has been closed.
2009-06-23 07:46:59 +00:00
Trustin Lee
8448188706 Related issue: NETTY-180 Channel.getRemoteAddress() can return null for a received MessageEvent when ExecutionHandler is in the pipeline.
* AbstractChannel.toString() does not use isConnected() or isBound() because it can lead to inconsistent string representation when ExecutionHandler is in the pipeline.
2009-06-23 07:20:57 +00:00
Trustin Lee
6fbd3871a3 Fixed license headers 2009-06-19 17:54:42 +00:00
Trustin Lee
caf0a97ba3 Fixed license headers 2009-06-19 17:48:17 +00:00
Trustin Lee
82e826440c Added missing license headers 2009-06-19 17:33:40 +00:00
Trustin Lee
1b56a56c2f Beautified JXR report 2009-06-19 17:31:31 +00:00
Trustin Lee
a7c2914163 Javadoc 2009-06-19 17:02:39 +00:00
Trustin Lee
f65b53917d Javadoc 2009-06-19 17:01:09 +00:00
Trustin Lee
54dd31c449 Javadoc 2009-06-19 16:45:30 +00:00
Trustin Lee
85f1db7459 Javadoc 2009-06-19 15:39:34 +00:00
Trustin Lee
4e2be13306 Javadoc 2009-06-19 15:36:42 +00:00
Trustin Lee
6058cf3981 Javadoc 2009-06-19 15:35:19 +00:00
Trustin Lee
44c7818ae8 Javadoc 2009-06-19 15:05:47 +00:00
Trustin Lee
0047563eb5 Javadoc 2009-06-19 15:01:47 +00:00
Trustin Lee
7accf4d29d Javadoc 2009-06-19 14:57:36 +00:00
Trustin Lee
2aa6f3e48d Javadoc 2009-06-19 14:52:29 +00:00
Trustin Lee
997dc9081a Javadoc 2009-06-19 14:49:26 +00:00
Trustin Lee
673312b22e Javadoc 2009-06-19 14:17:02 +00:00
Trustin Lee
aa0a8f17c8 * Added HttpMessage.isKeepAlive()
* Javadoc
2009-06-19 14:15:20 +00:00
Trustin Lee
120eeabc79 Javadoc 2009-06-19 11:40:28 +00:00
Trustin Lee
eaf931ac92 Javadoc 2009-06-19 11:36:31 +00:00
Trustin Lee
629ae769d7 Javadoc 2009-06-19 11:33:38 +00:00
Trustin Lee
dba344bd8e Prettier Javadoc stylesheet 2009-06-19 11:27:53 +00:00
Trustin Lee
c630a6ea65 Javadoc 2009-06-19 11:17:38 +00:00
Trustin Lee
f19cfb45e9 Javadoc 2009-06-19 10:53:29 +00:00
Trustin Lee
592e62573f Javadoc 2009-06-19 10:46:47 +00:00
Trustin Lee
81bd15f8e9 Javadoc 2009-06-19 09:45:01 +00:00
Trustin Lee
369a363855 Added LoggingHandler.getLevel() 2009-06-19 09:39:31 +00:00
Trustin Lee
a902cbf970 Allowed LoggingHandler to log in a different level 2009-06-19 09:38:34 +00:00
Trustin Lee
40ce919488 * Added InternalLogLevel
* Added InternalLogger.log() and isEnabled()
2009-06-19 09:31:38 +00:00
Trustin Lee
f7b2b3b1c3 Javadoc 2009-06-19 09:15:48 +00:00
Trustin Lee
82c55287a2 Javadoc 2009-06-19 09:10:35 +00:00
Trustin Lee
9207f35b14 * Hid AbstractCodecEmbedder from user
* Added @see tags to the CodecEmbedder implementations
2009-06-19 09:09:32 +00:00
Trustin Lee
cc0e6020d1 Renamed ChunkedInput.available to hasNextChunk
Renamed ChunkedInput.readChunk to nextChunk
2009-06-19 09:04:36 +00:00
Trustin Lee
cd23da084a Javadoc 2009-06-19 09:02:43 +00:00
Trustin Lee
8f2096a040 Javadoc 2009-06-19 08:59:24 +00:00
Trustin Lee
d5c4cd3df7 Javadoc 2009-06-19 08:16:56 +00:00
Trustin Lee
91c497f1e0 Javadoc 2009-06-19 08:08:08 +00:00
Trustin Lee
bf767a8f6c Javadoc 2009-06-19 08:01:28 +00:00
Trustin Lee
d14de97a72 Javadoc 2009-06-19 07:58:55 +00:00
Trustin Lee
46a7f6ff5f Fixed issue: NETTY-178 ObjectEncoder encodes array fields incorrectly.
* Made sure CompactObjectOutputStream encodes the class descriptor of an array type correctly.
2009-06-18 14:26:39 +00:00
Trustin Lee
2b0ec506ec Javadoc 2009-06-18 12:32:22 +00:00
Trustin Lee
10009a05fb Javadoc 2009-06-18 12:30:38 +00:00
Trustin Lee
a26ebc2bc1 Javadoc 2009-06-18 12:21:46 +00:00
Trustin Lee
f38fb2b742 Typo 2009-06-18 12:19:59 +00:00
Trustin Lee
d4a8631e62 Javadoc 2009-06-18 12:18:43 +00:00
Trustin Lee
4d0facee9f Javadoc 2009-06-18 12:16:25 +00:00
Trustin Lee
230113c0c6 Javadoc 2009-06-18 11:31:31 +00:00
Trustin Lee
cad86962ef Javadoc 2009-06-18 11:29:29 +00:00
Trustin Lee
72f1162729 Javadoc 2009-06-18 11:16:06 +00:00
Trustin Lee
192af44253 Better monospace font precedence 2009-06-18 10:31:13 +00:00
Trustin Lee
eabc83fb92 Improved the custom Javadoc stylesheet 2009-06-18 10:29:30 +00:00
Trustin Lee
2729f88bdf Improved the custom Javadoc stylesheet 2009-06-18 10:22:59 +00:00
Trustin Lee
cb5b1a7612 Improved the custom Javadoc stylesheet 2009-06-18 10:09:41 +00:00
Trustin Lee
8657220bf4 Custom stylesheet for prettier Javadoc 2009-06-18 09:54:59 +00:00
Trustin Lee
4c9ae49bf8 Fixed bad tags 2009-06-18 09:42:12 +00:00
Trustin Lee
ff5ebb0a15 Fixed bad tags 2009-06-18 09:40:50 +00:00
Trustin Lee
a56d3306c1 * Javadoc
* Made AbstractXnioChannelHandler package-private because it's not necessary to expose it to the user
2009-06-18 09:32:33 +00:00
Trustin Lee
e79d45727d Javadoc 2009-06-18 09:24:32 +00:00
Trustin Lee
bf6bc95c63 Javadoc 2009-06-18 09:13:08 +00:00
Trustin Lee
fe025091a7 Javadoc 2009-06-18 09:10:32 +00:00
Trustin Lee
fc294510c1 Javadoc 2009-06-18 09:09:09 +00:00
Trustin Lee
8c1335dac1 Added missing bindings in Guice integration 2009-06-18 09:01:07 +00:00
Trustin Lee
ce3bf8fbab Added NioDatagramChannelFactory support to Spring integration 2009-06-18 08:59:22 +00:00
Trustin Lee
1146c7072d Added NioDatagramChannelFactory support to JBossMC integration 2009-06-18 08:58:39 +00:00
Trustin Lee
bcc697110f Added NioDatagramChannelFactory support to OSGi integration 2009-06-18 08:57:01 +00:00
Trustin Lee
418557248a Added NioDatagramChannelFactory support to Guice integration 2009-06-18 08:56:10 +00:00
Trustin Lee
f8bba65b28 Javadoc 2009-06-18 08:53:05 +00:00
Trustin Lee
d2e91d2a45 Javadoc 2009-06-18 08:48:36 +00:00
Trustin Lee
a0adcf8dc8 Javadoc 2009-06-18 08:41:06 +00:00
Trustin Lee
fae9900211 Javadoc 2009-06-18 08:38:44 +00:00
Trustin Lee
e1abd56c1d * Javadoc
* Backported fixes applied to OioWorker
2009-06-18 08:20:57 +00:00
Trustin Lee
2b33c26e72 Javadoc 2009-06-18 07:33:37 +00:00
Trustin Lee
48634e3d30 Fixed typo and a compiler warning 2009-06-18 07:30:26 +00:00
Trustin Lee
0f8c1be142 Better explanation on what the local transport is 2009-06-17 10:14:14 +00:00
Trustin Lee
f40bb1d522 Javadoc 2009-06-17 10:07:41 +00:00
Trustin Lee
d16639d3ea Javadoc 2009-06-17 09:49:05 +00:00
Trustin Lee
29da430183 Javadoc 2009-06-17 09:33:20 +00:00
Trustin Lee
843b530c64 Javadoc 2009-06-17 09:13:10 +00:00
Trustin Lee
35eac01e40 Javadoc 2009-06-17 08:36:59 +00:00
Trustin Lee
9092d51b04 Javadoc 2009-06-17 08:33:54 +00:00
Trustin Lee
48a5d95dac Javadoc 2009-06-17 08:28:03 +00:00
Trustin Lee
ca11f90270 * Added ChannelBufferOutputStream.writtenBytes()
* Javadoc
2009-06-17 08:24:52 +00:00
Trustin Lee
c838c2aea3 Javadoc 2009-06-17 08:10:45 +00:00
Trustin Lee
70e90fc85e Fixed issue: NETTY-176 toByteBuffer() and slice() sometimes do not respect byte order
* Added tests to make sure all ChannelBuffer implementations are fixed
* Fixed the byte order problem in HeapChannelBuffer
2009-06-17 08:08:11 +00:00
Trustin Lee
b9cd9de5ed Fixed issue: NETTY-176 ByteBufferBackedBuffer.toByteBuffer() and slice() do not respect byte order 2009-06-17 07:57:14 +00:00
Trustin Lee
e04d8e9de1 Javadoc 2009-06-17 06:37:36 +00:00
Trustin Lee
8b5a652883 Javadoc 2009-06-17 05:39:19 +00:00
Trustin Lee
28511fcb9e * Javadoc
* Added EstimatableObjectWrapper and make ChannelEventRunnable implement it to avoid an evil circular dependency
2009-06-17 05:28:53 +00:00
Trustin Lee
73853f1b04 Javadoc 2009-06-17 05:12:18 +00:00
Trustin Lee
1826b88622 Javadoc 2009-06-17 05:09:45 +00:00
Trustin Lee
262fd48e28 Typo 2009-06-17 05:01:09 +00:00
Trustin Lee
10a110c564 Javadoc 2009-06-17 05:00:48 +00:00
Trustin Lee
8943926625 Javadoc 2009-06-17 04:58:25 +00:00
Trustin Lee
373cd52012 Fixed a problem in ChunkedWriteHandler where channelInterestOpsChanged event is not propagated properly 2009-06-16 10:44:03 +00:00
Trustin Lee
4f4cf07760 Removed duplicate file separator replacement 2009-06-16 10:16:36 +00:00
Trustin Lee
51b6e05b0d Added missing return in the example 2009-06-16 10:14:43 +00:00
Trustin Lee
575973863f Added missing exit condition 2009-06-16 10:07:46 +00:00
Trustin Lee
887e0b6de7 Oops wrong variable 2009-06-16 10:06:33 +00:00
Trustin Lee
aec7fe1704 Update offset sooner (Before getting any exceptions) 2009-06-16 10:06:14 +00:00
Trustin Lee
6e4331d9f7 Added a static file web server example 2009-06-16 09:27:46 +00:00
Trustin Lee
e8d42cbc46 Updated author tags and version tags 2009-06-16 08:39:50 +00:00
Trustin Lee
f9c38bb76b * Reorganized HTTP examples (will add file server example later)
* Fixed configuration errors in the HTTP tunneling transport example
2009-06-16 08:35:43 +00:00
Trustin Lee
b19d488312 Related issue: NETTY-175 Large Data Transfer
* Added ChunkedStream
* Moved ChunkedFile.DEFAULT_CHUNK_SIZE to ChunkedStream
2009-06-16 08:21:50 +00:00
Trustin Lee
bba5b7bd42 More validation 2009-06-16 08:09:12 +00:00
Trustin Lee
c2169f2b73 Renamed ChunkStream to ChunkedInput
Renamed ChunkStreamWriteHandler to ChunkedWriteHandler
Renamed FileChunkStream to ChunkedFile
2009-06-16 08:06:00 +00:00
Trustin Lee
c08e7dd397 Issue NETTY-175 - Large data transfer
* Added ChunkStream and FileChunkStream
* Added ChunkStreamWriteHandler
2009-06-16 07:04:20 +00:00
Trustin Lee
ee8ffec265 Optimized HttpMessageDecoder.readHeader() 2009-06-15 09:06:56 +00:00
Trustin Lee
bda2f0a852 Fixed incorrect state management for HTTP header size 2009-06-15 08:45:39 +00:00
Trustin Lee
aeb7903be8 Fixed a mistake during optimization 2009-06-15 08:35:24 +00:00
Trustin Lee
12acb2cf09 Fixed a NPE in HttpMessageDecoder.readHeaders() on a particular malformed header 2009-06-15 08:13:52 +00:00
Trustin Lee
f059f91ff4 Code simplification / optimization 2009-06-15 08:05:27 +00:00
Trustin Lee
d76bfe72b5 Fixed issue: NETTY-174 Always use 'ASCII' charset when encoding HTTP messages. 2009-06-15 07:50:53 +00:00
Trustin Lee
e39d8720d2 Applied composite buffer consolidation to NioDatagramWorker too 2009-06-15 07:32:51 +00:00
Trustin Lee
160866e1a0 HttpMessageDecoder does not use regular expressions to decode the initial line and headers anymore so that it performs better 2009-06-15 07:30:07 +00:00
Trustin Lee
e410abed02 Fixed issue: NETTY-173 Do not use Class.isArray() in ReplayingDecoder and FrameDecoder
* Modified FrameDecoder and ReplayingDecoder not to use Class.isArray() anymore.
2009-06-15 07:29:12 +00:00
Trustin Lee
5ae0adbfaa Made sure composite buffer consolidation happens only once by converting CompositeChannelBuffer to an ordinary buffer 2009-06-15 07:26:05 +00:00
Trustin Lee
5fb8e8069b Tiny optimization that makes header addition faster in most cases 2009-06-15 07:06:53 +00:00
Trustin Lee
8debedf6b6 Removed the slow Class.isArray() call by returning Object[] instead of HttpChunk[] 2009-06-15 06:33:30 +00:00
Trustin Lee
a979433f91 Tiny optimization in HttpMessageDecoder.readHeaders() 2009-06-15 06:29:45 +00:00
Trustin Lee
f22f0b2035 CompositeChannelBuffer.toByteBuffer() should return the ByteBuffer with the same order 2009-06-15 06:13:50 +00:00
Daniel Bevenius
40bf0a63f1 Unittest and javadoc. 2009-06-13 11:30:02 +00:00
Trustin Lee
666f57a35e Fixed a bug where a wrong channel is closed on connection failure 2009-06-12 08:42:44 +00:00
Trustin Lee
ad8bb7eaf6 Removed an unnecessary empty line 2009-06-12 08:41:00 +00:00
Trustin Lee
ef40ba7941 Added a proxy example which is asked pretty often 2009-06-12 08:39:04 +00:00
Trustin Lee
0067371e24 Organized imports 2009-06-12 02:53:26 +00:00
Trustin Lee
7a4f00201a Renamed NioUdpWorker to NioDatagramWork 2009-06-12 02:47:57 +00:00
Trustin Lee
08107683b3 Less memory copy for OIO datagram transport 2009-06-12 02:08:58 +00:00
Trustin Lee
ee3ae043dc Fixed NPE in OioDatagramWorker.writeNow() 2009-06-12 01:52:02 +00:00
Trustin Lee
01d8de26cf Fixed NPE in NioUdpWorker.writeNow() 2009-06-12 01:48:00 +00:00
Trustin Lee
d42ea03799 Fixed incorrect or missing event order in Bootstraps and NIO UDP transport 2009-06-12 01:43:26 +00:00
Trustin Lee
0a5019385c * Added detailed explanation on NETTY-114 (not to forget why I woke up selector again) 2009-06-11 16:47:55 +00:00
Trustin Lee
e9d07c3c2e OioDatagramWorker now honors buffer factory's default byte order 2009-06-11 07:16:10 +00:00
Trustin Lee
8f4e0b524c NioUdpWorker.read() now honors buffer factory's default byte order 2009-06-11 07:14:40 +00:00
Trustin Lee
fa3eb52f4e Fixed NotYetConnectedException on setInterestOps by backporting the fix applied to NioWorker 2009-06-11 07:01:14 +00:00
Trustin Lee
899b16678f * Merged recent changes in the trunk to the NIO UDP transport
* Other miscellaneous modifications like typo fix
2009-06-11 06:10:46 +00:00
Trustin Lee
e4871f8460 Removed predictor from DefaultNioDatagramChannelConfig because it's already implemented in its superclass 2009-06-11 05:09:11 +00:00
Trustin Lee
1a309bff34 Updated @author tags 2009-06-11 05:06:14 +00:00
Trustin Lee
3473135c7b Updated @author tags 2009-06-11 05:03:53 +00:00
Trustin Lee
4b263dfb0e Updated license headers 2009-06-11 05:02:39 +00:00
Trustin Lee
d202db83f0 Updated license headers 2009-06-11 05:00:48 +00:00
Daniel Bevenius
c01e997a45 Added some javadocs and removed unsed code and excessive comments. 2009-06-11 04:33:07 +00:00
Trustin Lee
effbe32fdb Merged Daniel's NIO UDP transport into trunk - needs more review and cleanup but looks OK in general 2009-06-11 00:48:49 +00:00
Trustin Lee
734a5a46d4 Fixed issue: NETTY-172 Let user choose the I/O thread names
* Added ThreadNameDeterminer
* Moved ThreadRenamingRunnable from org.jboss.netty.util.internal to org.jboss.netty.util because it should be accessible by user
2009-06-10 08:56:37 +00:00
Trustin Lee
583ddfe992 Fixed compiler warnings 2009-06-09 10:19:29 +00:00
Trustin Lee
be12a1bdf1 Disabled NIO constraint level autodetection for IBM JDK 1.6 2009-06-09 05:17:36 +00:00
Trustin Lee
645ba6d3b9 Potential fix for AIX close freeze issue 2009-06-09 04:32:02 +00:00
Trustin Lee
afb7e511ad Fixed a case where HashedWheelTimer notifies a timeout one round later 2009-06-05 17:05:42 +00:00
Trustin Lee
bb6f5a6104 Fixed issue: NETTY-167 resumeRead() sometimes does not work in OIO transport. 2009-06-05 07:30:55 +00:00
Trustin Lee
7339e172e0 Fixed issue: NETTY-166 Dead lock triggered by OIO transport and MemoryAwareThreadPoolExecutor when WriteCompletionEvent reaches memory limit
* MemoryAwareThreadPoolExecutor does not count WriteCompletionEvent anymore to avoid dead lock
2009-06-05 07:05:20 +00:00
Trustin Lee
663fe81af2 Made sure interestOps is updated before OIO thread is interrupted 2009-06-05 07:01:13 +00:00
Trustin Lee
5273e274de Made sure interestOps is updated before OIO thread is interrupted 2009-06-05 07:00:55 +00:00
Trustin Lee
76777b74b4 Fixed a problem in the examples where the client process does not shut itself down when a user typed the 'bye' command. 2009-06-04 08:50:19 +00:00
Trustin Lee
345a5512ab Made sure to clean up the cumulative buffer on channelDisconnected or channelClosed 2009-06-04 08:49:33 +00:00
Trustin Lee
d4071e87ef Added more exception message pattern to detect the exception related with the closed connection in SslHandler 2009-06-04 08:48:51 +00:00
Trustin Lee
7739f02423 Removed System.println 2009-06-04 06:15:44 +00:00
Trustin Lee
df06536818 Fixed test failure 2009-06-04 06:15:19 +00:00
Trustin Lee
02ba3b553a Removed an unnecessary empty line 2009-06-04 06:01:08 +00:00
Trustin Lee
c4bfb45183 Fixed issue: NETTY-165 FrameDecoder and ReplayingDecoder must call decodeLast even if there's no data in the buffer.
* Made sure decodeLast() is called even if the cumulative buffer is empty so that a decoder implementation always get notified when the connection is closed
* Updated Javadoc to explain that the buffer can be empty
2009-06-04 06:00:26 +00:00
Trustin Lee
553c4d2df8 * There's no need to send content-length header if HttpRequestHandler is going to close the connection right after a response.
* HttpClient sets 'Connection' to 'close' so that the HTTP server closes the connection
2009-06-04 03:18:44 +00:00
Trustin Lee
ee3440567c Prettier output 2009-06-04 03:15:26 +00:00
Trustin Lee
3aa91b0904 Modified HttpResponseHandler to print the 'end of chunk' marker 2009-06-04 03:13:44 +00:00
Trustin Lee
1609e1c347 Fixed issue: NETTY-164 - ReplayingDecoderBuffer.readableBytes() and capacity() should not return Integer.MAX_VALUE if the connection is closed.
* Fixed a problem where ReplayingDecoderBuffer.readable() does not respect 'terminated' flag.
2009-06-04 03:10:53 +00:00
Trustin Lee
3acda248c1 Fixed issue: NETTY-164 ReplayingDecoderBuffer.readableBytes() and capacity() should not return Integer.MAX_VALUE if the connection is closed.
* Added ReplayingDecoderBuffer.terminate(), which makes readableBytes() and capacity() to return an ordinary value instead of Integer.MAX_VALUE
2009-06-03 08:58:06 +00:00
Trustin Lee
2100462235 Fixed compilation errors in VirtualExecutorService 2009-06-03 07:48:23 +00:00
Trustin Lee
5f27babff4 Resolved issue: NETTY-161 Provide a way to get notified when all I/O workers of a ChannelFactory are terminated.
* Added VirtualExecutorService
2009-06-03 03:30:01 +00:00
Trustin Lee
3c29ccfdb5 HttpClient should use HTTP 1.1 2009-06-01 04:52:35 +00:00
Trustin Lee
151bf08095 Fixed issue: NETTY-163 OioDatagramChannel.connect() hangs if called on a bound channel
* Set SO_TIMEOUT of DatagramSocket to 100ms
2009-06-01 04:17:10 +00:00
Trustin Lee
ffe2831502 Fixed issue: NETTY-162 directBuffer cannot create buffer with LITTLE_ENDIAN endianness
* Added test case for little endian direct buffer
* Fixed a problem where the sliced buffer's endianness is not set
2009-05-30 06:50:09 +00:00
Trustin Lee
d4c2b7d70d ChannelLocal shouldn't be abstract 2009-05-28 23:42:39 +00:00
Trustin Lee
382099fae2 Fixed issue: NETTY-160 Make ChannelLocal non-abstract 2009-05-28 23:41:26 +00:00
Trustin Lee
c5c3fbcb20 Updated Javadoc 2009-05-22 06:39:48 +00:00
Trustin Lee
1116ae4733 Previous improvement on LoggingHandler was not logically correct - stepping back a little bit 2009-05-22 06:37:09 +00:00
Trustin Lee
96a751d9b0 Javadoc for LoggingHandler 2009-05-22 06:26:27 +00:00
Trustin Lee
7452e139c1 Method ordering 2009-05-22 06:14:09 +00:00
Trustin Lee
903fde7704 Method ordering 2009-05-22 06:13:47 +00:00
Trustin Lee
7b87b1b23c Made LoggingHandler more extensible 2009-05-22 06:13:19 +00:00
Trustin Lee
6da3fb5a90 Fixed FindBugs warnings 2009-05-22 06:04:47 +00:00
Trustin Lee
1f6591feb2 Suppressed error log which occurs only in Windows on connection attempt failure, because it can mislead the developer to think there's a bug in the test / impl 2009-05-22 05:41:47 +00:00
Trustin Lee
55cf5d67af Fixed issue: NETTY-157 Channel.close() does not trigger a channelUnbound event in some transports
* Made sure the specified future is not marked as done before setClosed() is called.  The specified future can be the closeFuture of the channel, consequently making setClosed() always fail.
2009-05-22 04:51:13 +00:00
Trustin Lee
f0a96e7417 Tiny optimization - no need to create a string when there's nothing to log 2009-05-21 12:04:28 +00:00
Trustin Lee
031c26482c Fixed issue: NETTY-158 Can't set the default byte order to little endian on the client side if FrameDecoder or ReplayingDecoder is used.
* FrameDecoder and ReplayingDecoder now create their internal buffers only on demand so that a user has a chance to decide what ChannelBufferFactory FrameDecoder and ReplayingDecoder will use.
2009-05-21 11:58:40 +00:00
Trustin Lee
25eee122cb More comprehensive exception message 2009-05-21 11:52:17 +00:00
Trustin Lee
ad6888a635 Fixed issue: NETTY-157 NioServerSocketChannel.close() does not trigger a channelUnbound event.
* Fixed a case where channelUnbound event is not fired if the specified future is the close future actually
2009-05-21 11:03:58 +00:00
Trustin Lee
77742f5cf9 Resolved issue: NETTY-156 Improve NIO worker performance by removing unnecessary SelectionKey access
* Applied patch by Wade Poziombka
* Reduced the call to SelectionKey.readyOps() even more
2009-05-21 10:28:05 +00:00
Trustin Lee
f92a0fe537 Fixed some warnings revealed by Eclipse 3.5 RC1 - previous Eclipse versions might complain this annotation is unnecessary. 2009-05-20 09:03:17 +00:00
Trustin Lee
678be7866c NETTY-154 channelOpen / channelBound / channelConnected needs to be called from the boss thread in NIO Socket transport.
* Boss thread now calls channelOpen channelBound and channelConnected
* to avoid a race condition when channel.setInterestOps() in the three handler methods above, interestOpsLock is acquired properly
2009-05-15 08:01:54 +00:00
Trustin Lee
92b336814f Made CompactObjectInputStream.loadClass() protected just in case a user wants to override it 2009-05-15 03:43:19 +00:00
Trustin Lee
b2eea97036 Fix for NETTY-150 CompactObjectInputStream web start (applet) Class.forName issue
* Refactored to reduce code duplication in CompactObjectInputStream
* Made sure that class loading doesn't incur security check unnecessarily
2009-05-15 03:42:48 +00:00
Trustin Lee
64bfa6cfda Better handling of InterruptedIOException in OIO Datagram 2009-05-13 13:12:19 +00:00
Trustin Lee
06586a6bfc More explanation on how dead lock can be produced 2009-05-13 01:11:06 +00:00
Trustin Lee
7e3ecf6b46 Better fix for the SslHandler dead lock 2009-05-13 01:08:40 +00:00
Trustin Lee
4eee24dc2c Fixed a dead lock in SslHandler 2009-05-12 14:46:54 +00:00
Trustin Lee
23d922fab2 Fix for NETTY-150 CompactObjectInputStream web start (applet) Class.forName issue 2009-05-12 14:09:55 +00:00
Trustin Lee
3c79744064 Fixed issue: NETTY-151 HTTP Content-Length
* HttpMessage.getLength() now returns a long integer
2009-05-08 12:45:10 +00:00
Trustin Lee
4877a2e73e Changed the pipeline coverage of HttpMessageEncoder to "all" 2009-05-08 08:22:01 +00:00
Trustin Lee
24ec8eeff6 Fixed the documentation error reported by Stefan 2009-05-08 08:21:13 +00:00
Trustin Lee
6a570765d4 Workaround for NPE in Tomcat on undeploy 2009-04-29 13:22:42 +00:00
Trustin Lee
3ee287bf49 Updated Javadoc of OrderedMemoryAwareThreadPoolExecutor 2009-04-29 02:10:52 +00:00
Trustin Lee
da6f2ac968 Updated Javadoc of OrderedMemoryAwareThreadPoolExecutor 2009-04-29 02:09:05 +00:00
Trustin Lee
429e9a2288 Made sure to disconnect on reconnection 2009-04-29 01:15:10 +00:00
Trustin Lee
d185a4b8d0 Fixed wrong thread name 2009-04-29 01:14:39 +00:00
Trustin Lee
d809046987 Fixed ClosedChannelException caused by previous 'chunk end mark' fix 2009-04-29 01:08:05 +00:00
Trustin Lee
fee1515818 Fixed a bug where HttpTunnelingClientSocketChannel does not send the end mark 2009-04-29 00:48:26 +00:00
Trustin Lee
7661bcec2d Adjusted the access modifiers of HttpTunnleingClientSocketChannel methods 2009-04-29 00:41:16 +00:00
Trustin Lee
d3eae2a511 Javadoc 2009-04-28 14:43:20 +00:00
Trustin Lee
4c564066eb Typo 2009-04-28 14:41:48 +00:00
Trustin Lee
48912c03ac Fixed ChannelHandlerContext example and added more explanation 2009-04-28 14:35:23 +00:00
Trustin Lee
e8aba5ae5a Javadoc 2009-04-28 13:39:06 +00:00
Trustin Lee
14f735438c Javadoc 2009-04-28 13:35:55 +00:00
Trustin Lee
d56c90fef5 Wrong tag 2009-04-28 12:38:02 +00:00
Trustin Lee
7ad38e8c8c Javadoc 2009-04-28 12:36:06 +00:00
Trustin Lee
3cd8478912 APIviz diagram cleanup 2009-04-28 12:11:01 +00:00
Trustin Lee
b01f484b79 Javadoc 2009-04-28 12:01:34 +00:00
Trustin Lee
553796fd75 Fixed an incorrect relationship in a class diagram 2009-04-28 11:57:51 +00:00
Trustin Lee
942298c537 Cleaned up the class diagram in the buffer package 2009-04-28 11:54:29 +00:00
Trustin Lee
e8b186eb4a Moved the chapter 3 to the package description of org.jboss.netty.buffer. User guide will focus on bigger pictures 2009-04-28 11:28:04 +00:00
Trustin Lee
91c0f5ed56 Javadoc 2009-04-28 10:38:00 +00:00
Trustin Lee
f3e910bd46 Member reordering 2009-04-28 05:45:05 +00:00
Trustin Lee
ef5fc808a2 Added ConnectionlessBootstrap.connect() 2009-04-28 05:44:40 +00:00
Trustin Lee
f69cb45ff9 Added ConnectionlessBootstrap for UDP transports 2009-04-28 05:28:36 +00:00
Trustin Lee
f8f1f2ca63 ServerBootstrap cannot be used with UDP/IP 2009-04-28 05:10:46 +00:00
Trustin Lee
cd35c1d130 * Fixed a potential issue where ClosedChannelException is thrown unnecessarilly
* Fixed a potential performance issue where an unused exception is created when a channel is closed
2009-04-26 04:04:05 +00:00
Trustin Lee
120db66aca More documentation on ChannelBuffer 2009-04-24 13:56:35 +00:00
Trustin Lee
e489f2e0ed REphrasing 2009-04-23 11:57:16 +00:00
Trustin Lee
7bdc627b8e Improved Javadoc as suggested by Frederic 2009-04-23 11:51:27 +00:00