netty5

History

Kareem Ali b559711f3e Motivation: (#10326 ) The current FLowControlHandler keeps a flag to track whether a read() call is pending. This could lead to a scenario where you call read multiple times when the queue is empty, and when the FlowControlHandler Queue starts getting messages, channelRead will be fired only once, when we should've fired x many times, once for each time the handlers downstream called read(). Modifications: Minor change to replace the boolean flag with a counter and adding a unit test for this scenario. Result: I used TDD, so I wrote the test, made sure it's failing, then updated the code and re-ran the test to make sure it's successful after the changes. Co-authored-by: Kareem Ali <kali@localhost.localdomain>	2020-06-04 19:17:33 +02:00
..
src	Motivation: (#10326 )	2020-06-04 19:17:33 +02:00
pom.xml	[maven-release-plugin] prepare for next development iteration	2020-05-13 06:00:23 +00:00

The current FLowControlHandler keeps a flag to track whether a read() call is pending.
This could lead to a scenario where you call read multiple times when the queue is empty,
and when the FlowControlHandler Queue starts getting messages, channelRead will be fired only once,
when we should've fired x many times, once for each time the handlers downstream called read().

Modifications:

Minor change to replace the boolean flag with a counter and adding a unit test for this scenario.

Result:

I used TDD, so I wrote the test, made sure it's failing, then updated the code and re-ran the test
to make sure it's successful after the changes.

Co-authored-by: Kareem Ali <kali@localhost.localdomain>

2020-06-04 19:17:33 +02:00

src

Motivation: (#10326 )

2020-06-04 19:17:33 +02:00

pom.xml

[maven-release-plugin] prepare for next development iteration

2020-05-13 06:00:23 +00:00