andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
http2-api-poc
netty5/transport-native-epoll/src/test/java/io/netty/channel/epoll
History
Chris Vest edf4e28afa
Change !future.isSuccess() to future.isFailed() where it makes sense (#11616) 
Motivation:
The expression "not is success" can mean that either the future failed, or it has not yet completed.
However, many places where such an expression is used is expecting the future to have completed.
Specifically, they are expecting to be able to call `cause()` on the future.
It is both more correct, and semantically clearer, to call `isFailed()` instead of `!isSuccess()`.

Modification:
Change all places that used `!isSuccess()` to  mean that the future had failed, to use `isFailed()`.
A few places are relying on `isSuccess()` returning `false` for _incomplete_ futures, and these places have been left unchanged.

Result:
Clearer code, with potentially fewer latent bugs.
2021-08-26 09:43:17 +02:00
..
EpollAbstractDomainSocketEchoTest.java Enable nohttp check during the build (#10708) 2020-10-23 15:26:25 +02:00
EpollChannelConfigTest.java Migrate testsuite, transport-native-epoll, transport-native-kqueue, and transport-native-unix-common-tests tests to JUnit 5 (#11320) 2021-05-27 14:07:41 +02:00
EpollCompositeBufferGatheringWriteTest.java TCP Fast Open for clients (#11006) 2021-02-15 14:29:03 +01:00
EpollDatagramChannelConfigTest.java Migrate testsuite, transport-native-epoll, transport-native-kqueue, and transport-native-unix-common-tests tests to JUnit 5 (#11320) 2021-05-27 14:07:41 +02:00
EpollDatagramChannelTest.java All *Bootstrap methods that used to return ChannelFuture now return Future<Channel> (#11517) 2021-08-03 19:43:38 +02:00
EpollDatagramConnectNotExistsTest.java Enable nohttp check during the build (#10708) 2020-10-23 15:26:25 +02:00
EpollDatagramMulticastIPv6Test.java Enable nohttp check during the build (#10708) 2020-10-23 15:26:25 +02:00
EpollDatagramMulticastIpv6WithIpv4AddrTest.java Avoid letting ipv6 addresses join ipv4 groups (#11015) 2021-02-16 14:22:02 +01:00
EpollDatagramMulticastTest.java Enable nohttp check during the build (#10708) 2020-10-23 15:26:25 +02:00
EpollDatagramScatteringReadTest.java Clean up Future/Promises API (#11575) 2021-08-20 09:55:16 +02:00
EpollDatagramUnicastIPv6MappedTest.java Enable nohttp check during the build (#10708) 2020-10-23 15:26:25 +02:00
EpollDatagramUnicastIPv6Test.java Enable nohttp check during the build (#10708) 2020-10-23 15:26:25 +02:00
EpollDatagramUnicastTest.java All *Bootstrap methods that used to return ChannelFuture now return Future<Channel> (#11517) 2021-08-03 19:43:38 +02:00
EpollDetectPeerCloseWithoutReadTest.java Enable nohttp check during the build (#10708) 2020-10-23 15:26:25 +02:00
EpollDomainDatagramPathTest.java Fix a problem with IP protocol version confusion on MacOS when TCP FastOpen is enabled (#11588) 2021-08-18 20:47:56 +02:00
EpollDomainDatagramUnicastTest.java Clean up Future/Promises API (#11575) 2021-08-20 09:55:16 +02:00
EpollDomainSocketDataReadInitialStateTest.java Fix a problem with IP protocol version confusion on MacOS when TCP FastOpen is enabled (#11588) 2021-08-18 20:47:56 +02:00
EpollDomainSocketEchoTest.java Fix a problem with IP protocol version confusion on MacOS when TCP FastOpen is enabled (#11588) 2021-08-18 20:47:56 +02:00
EpollDomainSocketFdTest.java Change !future.isSuccess() to future.isFailed() where it makes sense (#11616) 2021-08-26 09:43:17 +02:00
EpollDomainSocketFileRegionTest.java Fix a problem with IP protocol version confusion on MacOS when TCP FastOpen is enabled (#11588) 2021-08-18 20:47:56 +02:00
EpollDomainSocketFixedLengthEchoTest.java Fix a problem with IP protocol version confusion on MacOS when TCP FastOpen is enabled (#11588) 2021-08-18 20:47:56 +02:00
EpollDomainSocketGatheringWriteTest.java Fix a problem with IP protocol version confusion on MacOS when TCP FastOpen is enabled (#11588) 2021-08-18 20:47:56 +02:00
EpollDomainSocketObjectEchoTest.java Fix a problem with IP protocol version confusion on MacOS when TCP FastOpen is enabled (#11588) 2021-08-18 20:47:56 +02:00
EpollDomainSocketReuseFdTest.java Fix a problem with IP protocol version confusion on MacOS when TCP FastOpen is enabled (#11588) 2021-08-18 20:47:56 +02:00
EpollDomainSocketShutdownOutputByPeerTest.java Fix a problem with IP protocol version confusion on MacOS when TCP FastOpen is enabled (#11588) 2021-08-18 20:47:56 +02:00
EpollDomainSocketSslClientRenegotiateTest.java Fix a problem with IP protocol version confusion on MacOS when TCP FastOpen is enabled (#11588) 2021-08-18 20:47:56 +02:00
EpollDomainSocketSslEchoTest.java Fix a problem with IP protocol version confusion on MacOS when TCP FastOpen is enabled (#11588) 2021-08-18 20:47:56 +02:00
EpollDomainSocketSslGreetingTest.java Fix a problem with IP protocol version confusion on MacOS when TCP FastOpen is enabled (#11588) 2021-08-18 20:47:56 +02:00
EpollDomainSocketStartTlsTest.java Fix a problem with IP protocol version confusion on MacOS when TCP FastOpen is enabled (#11588) 2021-08-18 20:47:56 +02:00
EpollDomainSocketStringEchoTest.java Fix a problem with IP protocol version confusion on MacOS when TCP FastOpen is enabled (#11588) 2021-08-18 20:47:56 +02:00
EpollEventLoopTest.java Migrate testsuite, transport-native-epoll, transport-native-kqueue, and transport-native-unix-common-tests tests to JUnit 5 (#11320) 2021-05-27 14:07:41 +02:00
EpollJdkLoopbackSocketSslEchoTest.java Fix a problem with IP protocol version confusion on MacOS when TCP FastOpen is enabled (#11588) 2021-08-18 20:47:56 +02:00
EpollKQueueIovArrayTest.java Migrate testsuite, transport-native-epoll, transport-native-kqueue, and transport-native-unix-common-tests tests to JUnit 5 (#11320) 2021-05-27 14:07:41 +02:00
EpollReuseAddrTest.java All *Bootstrap methods that used to return ChannelFuture now return Future<Channel> (#11517) 2021-08-03 19:43:38 +02:00
EpollServerSocketChannelConfigTest.java All *Bootstrap methods that used to return ChannelFuture now return Future<Channel> (#11517) 2021-08-03 19:43:38 +02:00
EpollSocketAutoReadTest.java TCP Fast Open for clients (#11006) 2021-02-15 14:29:03 +01:00
EpollSocketChannelConfigTest.java Improve test failure reporting of EpollSocketChannelConfigTest (#11570) 2021-08-12 11:39:19 +02:00
EpollSocketChannelNotYetConnectedTest.java TCP Fast Open for clients (#11006) 2021-02-15 14:29:03 +01:00
EpollSocketChannelTest.java All *Bootstrap methods that used to return ChannelFuture now return Future<Channel> (#11517) 2021-08-03 19:43:38 +02:00
EpollSocketCloseForciblyTest.java TCP Fast Open for clients (#11006) 2021-02-15 14:29:03 +01:00
EpollSocketConditionalWritabilityTest.java TCP Fast Open for clients (#11006) 2021-02-15 14:29:03 +01:00
EpollSocketConnectionAttemptTest.java Enable nohttp check during the build (#10708) 2020-10-23 15:26:25 +02:00
EpollSocketConnectTest.java Add support for client-side TCP FastOpen to KQueue MacOS (#11560) 2021-08-12 13:50:34 +02:00
EpollSocketDataReadInitialStateTest.java TCP Fast Open for clients (#11006) 2021-02-15 14:29:03 +01:00
EpollSocketEchoTest.java TCP Fast Open for clients (#11006) 2021-02-15 14:29:03 +01:00
EpollSocketExceptionHandlingTest.java TCP Fast Open for clients (#11006) 2021-02-15 14:29:03 +01:00
EpollSocketFileRegionTest.java TCP Fast Open for clients (#11006) 2021-02-15 14:29:03 +01:00
EpollSocketFixedLengthEchoTest.java TCP Fast Open for clients (#11006) 2021-02-15 14:29:03 +01:00
EpollSocketGatheringWriteTest.java TCP Fast Open for clients (#11006) 2021-02-15 14:29:03 +01:00
EpollSocketHalfClosed.java TCP Fast Open for clients (#11006) 2021-02-15 14:29:03 +01:00
EpollSocketMultipleConnectTest.java TCP Fast Open for clients (#11006) 2021-02-15 14:29:03 +01:00
EpollSocketObjectEchoTest.java TCP Fast Open for clients (#11006) 2021-02-15 14:29:03 +01:00
EpollSocketReadPendingTest.java TCP Fast Open for clients (#11006) 2021-02-15 14:29:03 +01:00
EpollSocketRstTest.java Migrate testsuite, transport-native-epoll, transport-native-kqueue, and transport-native-unix-common-tests tests to JUnit 5 (#11320) 2021-05-27 14:07:41 +02:00
EpollSocketShutdownOutputByPeerTest.java Enable nohttp check during the build (#10708) 2020-10-23 15:26:25 +02:00
EpollSocketShutdownOutputBySelfTest.java Enable nohttp check during the build (#10708) 2020-10-23 15:26:25 +02:00
EpollSocketSslClientRenegotiateTest.java Migrate testsuite, transport-native-epoll, transport-native-kqueue, and transport-native-unix-common-tests tests to JUnit 5 (#11320) 2021-05-27 14:07:41 +02:00
EpollSocketSslEchoTest.java Migrate testsuite, transport-native-epoll, transport-native-kqueue, and transport-native-unix-common-tests tests to JUnit 5 (#11320) 2021-05-27 14:07:41 +02:00
EpollSocketSslGreetingTest.java Migrate testsuite, transport-native-epoll, transport-native-kqueue, and transport-native-unix-common-tests tests to JUnit 5 (#11320) 2021-05-27 14:07:41 +02:00
EpollSocketSslSessionReuseTest.java Migrate testsuite, transport-native-epoll, transport-native-kqueue, and transport-native-unix-common-tests tests to JUnit 5 (#11320) 2021-05-27 14:07:41 +02:00
EpollSocketStartTlsTest.java Migrate testsuite, transport-native-epoll, transport-native-kqueue, and transport-native-unix-common-tests tests to JUnit 5 (#11320) 2021-05-27 14:07:41 +02:00
EpollSocketStringEchoBusyWaitTest.java Migrate testsuite, transport-native-epoll, transport-native-kqueue, and transport-native-unix-common-tests tests to JUnit 5 (#11320) 2021-05-27 14:07:41 +02:00
EpollSocketStringEchoTest.java TCP Fast Open for clients (#11006) 2021-02-15 14:29:03 +01:00
EpollSocketTcpMd5Test.java Remove Unused Imports (#11546) 2021-08-05 14:08:07 +02:00
EpollSocketTest.java Fix a problem with IP protocol version confusion on MacOS when TCP FastOpen is enabled (#11588) 2021-08-18 20:47:56 +02:00
EpollSocketTestPermutation.java Fix a problem with IP protocol version confusion on MacOS when TCP FastOpen is enabled (#11588) 2021-08-18 20:47:56 +02:00
EpollTest.java Migrate testsuite, transport-native-epoll, transport-native-kqueue, and transport-native-unix-common-tests tests to JUnit 5 (#11320) 2021-05-27 14:07:41 +02:00
EpollWriteBeforeRegisteredTest.java TCP Fast Open for clients (#11006) 2021-02-15 14:29:03 +01:00
LinuxSocketTest.java Migrate testsuite, transport-native-epoll, transport-native-kqueue, and transport-native-unix-common-tests tests to JUnit 5 (#11320) 2021-05-27 14:07:41 +02:00
NativeTest.java Migrate testsuite, transport-native-epoll, transport-native-kqueue, and transport-native-unix-common-tests tests to JUnit 5 (#11320) 2021-05-27 14:07:41 +02:00