andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
8,382 Commits 27 Branches 234 Tags 84 MiB
Java 99.8%
Shell 0.1%
0234878c4b
Go to file
Nikolay Fedorovskikh 0234878c4b Fix the commands cache and hashCode() in SmtpCommand 
Motivation:
- A `hashCode` of the SmtpCommand is recalculated on each call of `hashCode()`. Cached hash code value can be just replaced with call of `name.hashCode()`.
- The commands cache don't work for strings: `SmtpCommand.valueOf("HELO")` returns a new instance.
- Field `contentExpected` is redundant and can be replaced with `equals(DATA)`.

Modifications:
- Use the `name.hashCode()` as hash code result.
- Fix a command cache: use strings as map keys.
- Replace field `contentExpected` to using `this.equals(DATA)`.
- Add unit tests.

Result:
More correct and clean code.
2017-08-18 09:46:53 +02:00
.github Use GitHub Issue/PR Template Feature 2016-12-07 11:40:26 -08:00
all [maven-release-plugin] prepare for next development iteration 2017-08-02 12:55:10 +00:00
bom [maven-release-plugin] prepare for next development iteration 2017-08-02 12:55:10 +00:00
buffer Use the ByteBufAllocator when copy a ReadOnlyByteBufferBuf and so also be able to release it without the GC when the Cleaner is present. 2017-08-16 07:33:10 +02:00
codec Use Constructor for reflective class instantiation. 2017-08-18 09:42:36 +02:00
codec-dns [maven-release-plugin] prepare for next development iteration 2017-08-02 12:55:10 +00:00
codec-haproxy [maven-release-plugin] prepare for next development iteration 2017-08-02 12:55:10 +00:00
codec-http Revert "Only call ctx.fireChannelReadComplete() if ByteToMessageDecoder decoded at least one message." 2017-08-18 09:06:37 +02:00
codec-http2 Immediate caching the strings wrapped to AsciiString 2017-08-15 06:22:14 +02:00
codec-memcache [maven-release-plugin] prepare for next development iteration 2017-08-02 12:55:10 +00:00
codec-mqtt Add null checks before converting to string to avoid NPE. 2017-08-11 07:14:39 +02:00
codec-redis [maven-release-plugin] prepare for next development iteration 2017-08-02 12:55:10 +00:00
codec-smtp Fix the commands cache and hashCode() in SmtpCommand 2017-08-18 09:46:53 +02:00
codec-socks [maven-release-plugin] prepare for next development iteration 2017-08-02 12:55:10 +00:00
codec-stomp Immediate caching the strings wrapped to AsciiString 2017-08-15 06:22:14 +02:00
codec-xml [maven-release-plugin] prepare for next development iteration 2017-08-02 12:55:10 +00:00
common Make NativeLibraryLoader check java.library.path first 2017-08-16 14:27:50 -07:00
dev-tools [maven-release-plugin] prepare for next development iteration 2017-08-02 12:55:10 +00:00
example Immediate caching the strings wrapped to AsciiString 2017-08-15 06:22:14 +02:00
handler Revert "Only call ctx.fireChannelReadComplete() if ByteToMessageDecoder decoded at least one message." 2017-08-18 09:06:37 +02:00
handler-proxy [maven-release-plugin] prepare for next development iteration 2017-08-02 12:55:10 +00:00
license Remove reference to akka code and ArrayDeque which is not part of netty anymore 2017-03-07 21:30:51 +01:00
microbench [maven-release-plugin] prepare for next development iteration 2017-08-02 12:55:10 +00:00
resolver [maven-release-plugin] prepare for next development iteration 2017-08-02 12:55:10 +00:00
resolver-dns Ensure netty builds with java9 (build 9+181) 2017-08-15 20:31:10 +02:00
tarball [maven-release-plugin] prepare for next development iteration 2017-08-02 12:55:10 +00:00
testsuite Increase test timeout for SocketStringEchoTest 2017-08-12 11:19:12 -07:00
testsuite-autobahn [maven-release-plugin] prepare for next development iteration 2017-08-02 12:55:10 +00:00
testsuite-osgi [maven-release-plugin] prepare for next development iteration 2017-08-02 12:55:10 +00:00
transport Use Constructor for reflective class instantiation. 2017-08-18 09:42:36 +02:00
transport-native-epoll Do not define JNI_OnLoad when not dynamic 2017-08-18 09:20:58 +02:00
transport-native-kqueue Do not define JNI_OnLoad when not dynamic 2017-08-18 09:20:58 +02:00
transport-native-unix-common Use underscore in native library names for consistency. 2017-08-15 06:02:00 +02:00
transport-native-unix-common-tests [maven-release-plugin] prepare for next development iteration 2017-08-02 12:55:10 +00:00
transport-rxtx We should prefer heap buffers when using the OIO transport to reduce memory copies. 2017-08-11 08:48:04 +02:00
transport-sctp [maven-release-plugin] prepare for next development iteration 2017-08-02 12:55:10 +00:00
transport-udt Use Constructor for reflective class instantiation. 2017-08-18 09:42:36 +02:00
.fbprefs Updated Find Bugs configuration 2009-03-04 10:33:09 +00:00
.gitignore Use shaded dependency on JCTools instead of copy and paste 2016-06-10 13:19:45 +02:00
.travis.yml Travis CI branch whitelisting 2013-03-11 09:55:43 +09:00
CONTRIBUTING.md Move the pull request guide to the developer guide 2014-03-12 13:13:58 +09:00
LICENSE.txt Relicensed to Apache License v2 2009-08-28 07:15:49 +00:00
NOTICE.txt Remove reference to akka code and ArrayDeque which is not part of netty anymore 2017-03-07 21:30:51 +01:00
pom.xml Update netty-tcnative native library names to use underscores. 2017-08-17 10:08:32 +02:00
README.md Updating Branches to look section to match the current branching structure of the project 2016-03-10 22:08:01 +01:00
run-example.sh Add UptimeServer and adjust UptimeClient's code style. 2017-04-28 07:41:07 +02:00

README.md

Netty Project

Netty is an asynchronous event-driven network application framework for rapid development of maintainable high performance protocol servers & clients.

Links

How to build

For the detailed information about building and developing Netty, please visit the developer guide. This page only gives very basic information.

You require the following to build Netty:

Note that this is build-time requirement. JDK 5 (for 3.x) or 6 (for 4.0+) is enough to run your Netty-based application.

Branches to look

Development of all versions takes place in each branch whose name is identical to <majorVersion>.<minorVersion>. For example, the development of 3.9 and 4.0 resides in the branch '3.9' and the branch '4.0' respectively.