netty5/resolver-dns/src/main/java/io/netty/resolver/dns/InflightNameResolver.java
Chris Vest 0cb4cc4e49
Make Promise not extend Future (#11634)
Motivation:
We wish to separate these two into clearer write/read interfaces.
In particular, we don't want to be able to add listeners to promises, because it makes it easy to add them out of order.
We can't prevent it entirely, because any promise can be freely converted to a future where listeners can be added.
We can, however, discourage this in the API.

Modification:
The Promise interface no longer extends the Future interface.
Numerous changes to make the project compile and its tests run.

Result:
Clearer separation of concerns in the code.
2021-09-02 10:46:54 +02:00

122 lines
4.3 KiB
Java

/*
* Copyright 2016 The Netty Project
*
* The Netty Project licenses this file to you under the Apache License,
* version 2.0 (the "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at:
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
* License for the specific language governing permissions and limitations
* under the License.
*/
package io.netty.resolver.dns;
import io.netty.resolver.NameResolver;
import io.netty.util.concurrent.EventExecutor;
import io.netty.util.concurrent.Future;
import io.netty.util.concurrent.Promise;
import io.netty.util.internal.StringUtil;
import java.util.List;
import java.util.concurrent.ConcurrentMap;
import static java.util.Objects.requireNonNull;
// FIXME(trustin): Find a better name and move it to the 'resolver' module.
final class InflightNameResolver<T> implements NameResolver<T> {
private final EventExecutor executor;
private final NameResolver<T> delegate;
private final ConcurrentMap<String, Promise<T>> resolvesInProgress;
private final ConcurrentMap<String, Promise<List<T>>> resolveAllsInProgress;
InflightNameResolver(EventExecutor executor, NameResolver<T> delegate,
ConcurrentMap<String, Promise<T>> resolvesInProgress,
ConcurrentMap<String, Promise<List<T>>> resolveAllsInProgress) {
this.executor = requireNonNull(executor, "executor");
this.delegate = requireNonNull(delegate, "delegate");
this.resolvesInProgress = requireNonNull(resolvesInProgress, "resolvesInProgress");
this.resolveAllsInProgress = requireNonNull(resolveAllsInProgress, "resolveAllsInProgress");
}
@Override
public Future<T> resolve(String inetHost) {
return resolve(inetHost, executor.newPromise());
}
@Override
public Future<List<T>> resolveAll(String inetHost) {
return resolveAll(inetHost, executor.newPromise());
}
@Override
public void close() {
delegate.close();
}
@Override
public Future<T> resolve(String inetHost, Promise<T> promise) {
return resolve(resolvesInProgress, inetHost, promise, false);
}
@Override
public Future<List<T>> resolveAll(String inetHost, Promise<List<T>> promise) {
return resolve(resolveAllsInProgress, inetHost, promise, true);
}
private <U> Future<U> resolve(
final ConcurrentMap<String, Promise<U>> resolveMap,
final String inetHost, final Promise<U> promise, boolean resolveAll) {
final Promise<U> earlyPromise = resolveMap.putIfAbsent(inetHost, promise);
if (earlyPromise != null) {
// Name resolution for the specified inetHost is in progress already.
Future<U> earlyFuture = promise.asFuture();
if (earlyFuture.isDone()) {
transferResult(earlyFuture, promise);
} else {
earlyFuture.addListener(f -> transferResult(f, promise));
}
} else {
try {
if (resolveAll) {
@SuppressWarnings("unchecked")
final Promise<List<T>> castPromise = (Promise<List<T>>) promise; // U is List<T>
delegate.resolveAll(inetHost, castPromise);
} else {
@SuppressWarnings("unchecked")
final Promise<T> castPromise = (Promise<T>) promise; // U is T
delegate.resolve(inetHost, castPromise);
}
} finally {
if (promise.isDone()) {
resolveMap.remove(inetHost);
} else {
promise.asFuture().addListener(f -> resolveMap.remove(inetHost));
}
}
}
return promise.asFuture();
}
private static <T> void transferResult(Future<? extends T> src, Promise<T> dst) {
if (src.isSuccess()) {
dst.trySuccess(src.getNow());
} else {
dst.tryFailure(src.cause());
}
}
@Override
public String toString() {
return StringUtil.simpleClassName(this) + '(' + delegate + ')';
}
}