0e4c073bcf
Motivation: ByteToMessageDecoder requires using an intermediate List to put results into. This intermediate list adds overhead (memory/CPU) which grows as the number of objects increases. This overhead can be avoided by directly propagating events through the ChannelPipeline via ctx.fireChannelRead(...). This also makes the semantics more clear and allows us to keep track if we need to call ctx.read() in all cases. Modifications: - Remove List from the method signature of ByteToMessageDecoder.decode(...) and decodeLast(...) - Adjust all sub-classes - Adjust unit tests - Fix javadocs. Result: Adjust ByteToMessageDecoder as noted in https://github.com/netty/netty/issues/8525.
61 lines
2.1 KiB
Java
61 lines
2.1 KiB
Java
/*
|
|
* Copyright 2012 The Netty Project
|
|
*
|
|
* The Netty Project licenses this file to you under the Apache License,
|
|
* version 2.0 (the "License"); you may not use this file except in compliance
|
|
* with the License. You may obtain a copy of the License at:
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
* License for the specific language governing permissions and limitations
|
|
* under the License.
|
|
*/
|
|
package io.netty.handler.codec.socks;
|
|
|
|
import io.netty.buffer.ByteBuf;
|
|
import io.netty.channel.ChannelHandlerContext;
|
|
import io.netty.handler.codec.ReplayingDecoder;
|
|
import io.netty.handler.codec.socks.SocksAuthResponseDecoder.State;
|
|
|
|
/**
|
|
* Decodes {@link ByteBuf}s into {@link SocksAuthResponse}.
|
|
* Before returning SocksResponse decoder removes itself from pipeline.
|
|
*/
|
|
public class SocksAuthResponseDecoder extends ReplayingDecoder<State> {
|
|
|
|
public SocksAuthResponseDecoder() {
|
|
super(State.CHECK_PROTOCOL_VERSION);
|
|
}
|
|
|
|
@Override
|
|
protected void decode(ChannelHandlerContext ctx, ByteBuf byteBuf)
|
|
throws Exception {
|
|
switch (state()) {
|
|
case CHECK_PROTOCOL_VERSION: {
|
|
if (byteBuf.readByte() != SocksSubnegotiationVersion.AUTH_PASSWORD.byteValue()) {
|
|
ctx.fireChannelRead(SocksCommonUtils.UNKNOWN_SOCKS_RESPONSE);
|
|
break;
|
|
}
|
|
checkpoint(State.READ_AUTH_RESPONSE);
|
|
}
|
|
case READ_AUTH_RESPONSE: {
|
|
SocksAuthStatus authStatus = SocksAuthStatus.valueOf(byteBuf.readByte());
|
|
ctx.fireChannelRead(new SocksAuthResponse(authStatus));
|
|
break;
|
|
}
|
|
default: {
|
|
throw new Error();
|
|
}
|
|
}
|
|
ctx.pipeline().remove(this);
|
|
}
|
|
|
|
enum State {
|
|
CHECK_PROTOCOL_VERSION,
|
|
READ_AUTH_RESPONSE
|
|
}
|
|
}
|