Go to file
Nick Hill 0f8ce1b284 Fix incorrect sizing of temp byte arrays in (Unsafe)ByteBufUtil (#8484)
Motivation:

Two similar bugs were introduced by myself in separate recent PRs #8393
and #8464, while optimizing the assignment/handling of temporary arrays
in ByteBufUtil and UnsafeByteBufUtil.

The temp arrays allocated for buffering data written to an OutputStream
are incorrectly sized to the full length of the data to copy rather than
being capped at WRITE_CHUNK_SIZE.

Unfortunately one of these is in the 4.1.31.Final release, I'm really
sorry and will be more careful in future.

This kind of thing is tricky to cover in unit tests.

Modifications:

Revert the temp array allocations back to their original sizes.

Avoid making duplicate calls to ByteBuf.capacity() in a couple of places
in ByteBufUtil (unrelated thing I noticed, can remove it from this PR if
desired!)

Result:

Temporary byte arrays will be reverted to their originally intended
sizes.
2018-11-09 18:24:38 +01:00
.github Use GitHub Issue/PR Template Feature 2016-12-07 11:40:26 -08:00
.mvn/wrapper Include mvn wrapper to make setup of development env easier 2018-01-26 08:13:17 +01:00
all [maven-release-plugin] prepare for next development iteration 2018-10-29 15:38:51 +00:00
bom [maven-release-plugin] prepare for next development iteration 2018-10-29 15:38:51 +00:00
buffer Fix incorrect sizing of temp byte arrays in (Unsafe)ByteBufUtil (#8484) 2018-11-09 18:24:38 +01:00
codec Don't swallow intermediate write failures in MessageToMessageEncoder (#8454) 2018-11-03 10:36:26 +01:00
codec-dns [maven-release-plugin] prepare for next development iteration 2018-10-29 15:38:51 +00:00
codec-haproxy [maven-release-plugin] prepare for next development iteration 2018-10-29 15:38:51 +00:00
codec-http [maven-release-plugin] prepare for next development iteration 2018-10-29 15:38:51 +00:00
codec-http2 Make Http2StreamFrameToHttpObjectCodec truly @Sharable (#8482) 2018-11-09 18:23:53 +01:00
codec-memcache [maven-release-plugin] prepare for next development iteration 2018-10-29 15:38:51 +00:00
codec-mqtt [maven-release-plugin] prepare for next development iteration 2018-10-29 15:38:51 +00:00
codec-redis [maven-release-plugin] prepare for next development iteration 2018-10-29 15:38:51 +00:00
codec-smtp [maven-release-plugin] prepare for next development iteration 2018-10-29 15:38:51 +00:00
codec-socks [maven-release-plugin] prepare for next development iteration 2018-10-29 15:38:51 +00:00
codec-stomp [maven-release-plugin] prepare for next development iteration 2018-10-29 15:38:51 +00:00
codec-xml [maven-release-plugin] prepare for next development iteration 2018-10-29 15:38:51 +00:00
common Replace ConcurrentHashMap at allLeaks with a thread-safe set (#8467) 2018-11-06 11:21:56 +01:00
dev-tools [maven-release-plugin] prepare for next development iteration 2018-10-29 15:38:51 +00:00
docker Update to openjdk 12ea19 (#8487) 2018-11-09 16:50:58 +01:00
example #7695 no need to manually release chunk during upload (#7696) 2018-11-02 08:12:10 +01:00
handler Ensure we correctly call wrapEngine(...) during tests. (#8473) 2018-11-08 15:22:33 +01:00
handler-proxy [maven-release-plugin] prepare for next development iteration 2018-10-29 15:38:51 +00:00
license Add the NOTICE of the forked portion of Apache Harmony 2018-01-30 11:22:51 +01:00
microbench Streamline CompositeByteBuf internals (#8437) 2018-11-03 10:37:07 +01:00
resolver [maven-release-plugin] prepare for next development iteration 2018-10-29 15:38:51 +00:00
resolver-dns Fix NPE when trying to build a DnsNameResolver with a null resolvedAddressTypes (#8445) 2018-10-30 13:15:16 +01:00
tarball [maven-release-plugin] prepare for next development iteration 2018-10-29 15:38:51 +00:00
testsuite [maven-release-plugin] prepare for next development iteration 2018-10-29 15:38:51 +00:00
testsuite-autobahn [maven-release-plugin] prepare for next development iteration 2018-10-29 15:38:51 +00:00
testsuite-http2 [maven-release-plugin] prepare for next development iteration 2018-10-29 15:38:51 +00:00
testsuite-osgi [maven-release-plugin] prepare for next development iteration 2018-10-29 15:38:51 +00:00
testsuite-shading [maven-release-plugin] prepare for next development iteration 2018-10-29 15:38:51 +00:00
transport [maven-release-plugin] prepare for next development iteration 2018-10-29 15:38:51 +00:00
transport-native-epoll Add testcase for epollWait(...) with negative timerfd values. (#8447) 2018-10-30 19:38:02 +01:00
transport-native-kqueue [maven-release-plugin] prepare for next development iteration 2018-10-29 15:38:51 +00:00
transport-native-unix-common [maven-release-plugin] prepare for next development iteration 2018-10-29 15:38:51 +00:00
transport-native-unix-common-tests [maven-release-plugin] prepare for next development iteration 2018-10-29 15:38:51 +00:00
transport-rxtx [maven-release-plugin] prepare for next development iteration 2018-10-29 15:38:51 +00:00
transport-sctp [maven-release-plugin] prepare for next development iteration 2018-10-29 15:38:51 +00:00
transport-udt [maven-release-plugin] prepare for next development iteration 2018-10-29 15:38:51 +00:00
.fbprefs Updated Find Bugs configuration 2009-03-04 10:33:09 +00:00
.gitattributes Include mvn wrapper to make setup of development env easier 2018-01-26 08:13:17 +01:00
.gitignore Exclude mainframer related files from git 2018-10-14 13:20:18 +02:00
CONTRIBUTING.md Move the pull request guide to the developer guide 2014-03-12 13:13:58 +09:00
LICENSE.txt Relicensed to Apache License v2 2009-08-28 07:15:49 +00:00
mvnw Include mvn wrapper to make setup of development env easier 2018-01-26 08:13:17 +01:00
mvnw.cmd Include mvn wrapper to make setup of development env easier 2018-01-26 08:13:17 +01:00
NOTICE.txt Add the NOTICE of the forked portion of Apache Harmony 2018-01-30 11:22:51 +01:00
pom.xml Override and so delegate all methods in OpenSslX509Certificate (#8472) 2018-11-07 12:16:04 +01:00
README.md Provide an Automatic-Module-Name for the netty-all artifact fixes #7644 2018-01-27 20:31:16 +01:00
run-example.sh Add UptimeServer and adjust UptimeClient's code style. 2017-04-28 07:41:07 +02:00

Netty Project

Netty is an asynchronous event-driven network application framework for rapid development of maintainable high performance protocol servers & clients.

How to build

For the detailed information about building and developing Netty, please visit the developer guide. This page only gives very basic information.

You require the following to build Netty:

Note that this is build-time requirement. JDK 5 (for 3.x) or 6 (for 4.0+) is enough to run your Netty-based application.

Branches to look

Development of all versions takes place in each branch whose name is identical to <majorVersion>.<minorVersion>. For example, the development of 3.9 and 4.0 resides in the branch '3.9' and the branch '4.0' respectively.

Usage with JDK 9

Netty can be used in modular JDK9 applications as a collection of automatic modules. The module names follow the reverse-DNS style, and are derived from subproject names rather than root packages due to historical reasons. They are listed below:

  • io.netty.all
  • io.netty.buffer
  • io.netty.codec
  • io.netty.codec.dns
  • io.netty.codec.haproxy
  • io.netty.codec.http
  • io.netty.codec.http2
  • io.netty.codec.memcache
  • io.netty.codec.mqtt
  • io.netty.codec.redis
  • io.netty.codec.smtp
  • io.netty.codec.socks
  • io.netty.codec.stomp
  • io.netty.codec.xml
  • io.netty.common
  • io.netty.handler
  • io.netty.handler.proxy
  • io.netty.resolver
  • io.netty.resolver.dns
  • io.netty.transport
  • io.netty.transport.epoll (native omitted - reserved keyword in Java)
  • io.netty.transport.kqueue (native omitted - reserved keyword in Java)
  • io.netty.transport.unix.common (native omitted - reserved keyword in Java)
  • io.netty.transport.rxtx
  • io.netty.transport.sctp
  • io.netty.transport.udt

Automatic modules do not provide any means to declare dependencies, so you need to list each used module separately in your module-info file.