a6b3fd8a72
Motivation: The WebSocketClientProtocolHandshakeHandler never releases the received handshake response. Modification: Release the message in a finally block. Result: No more leak
69 lines
2.6 KiB
Java
69 lines
2.6 KiB
Java
/*
|
|
* Copyright 2013 The Netty Project
|
|
*
|
|
* The Netty Project licenses this file to you under the Apache License,
|
|
* version 2.0 (the "License"); you may not use this file except in compliance
|
|
* with the License. You may obtain a copy of the License at:
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
* License for the specific language governing permissions and limitations
|
|
* under the License.
|
|
*/
|
|
package io.netty.handler.codec.http.websocketx;
|
|
|
|
import io.netty.channel.ChannelFuture;
|
|
import io.netty.channel.ChannelFutureListener;
|
|
import io.netty.channel.ChannelHandlerContext;
|
|
import io.netty.channel.ChannelInboundHandlerAdapter;
|
|
import io.netty.handler.codec.http.FullHttpResponse;
|
|
|
|
class WebSocketClientProtocolHandshakeHandler extends ChannelInboundHandlerAdapter {
|
|
private final WebSocketClientHandshaker handshaker;
|
|
|
|
WebSocketClientProtocolHandshakeHandler(WebSocketClientHandshaker handshaker) {
|
|
this.handshaker = handshaker;
|
|
}
|
|
|
|
@Override
|
|
public void channelActive(final ChannelHandlerContext ctx) throws Exception {
|
|
super.channelActive(ctx);
|
|
handshaker.handshake(ctx.channel()).addListener(new ChannelFutureListener() {
|
|
@Override
|
|
public void operationComplete(ChannelFuture future) throws Exception {
|
|
if (!future.isSuccess()) {
|
|
ctx.fireExceptionCaught(future.cause());
|
|
} else {
|
|
ctx.fireUserEventTriggered(
|
|
WebSocketClientProtocolHandler.ClientHandshakeStateEvent.HANDSHAKE_ISSUED);
|
|
}
|
|
}
|
|
});
|
|
}
|
|
|
|
@Override
|
|
public void channelRead(ChannelHandlerContext ctx, Object msg) throws Exception {
|
|
if (!(msg instanceof FullHttpResponse)) {
|
|
ctx.fireChannelRead(msg);
|
|
return;
|
|
}
|
|
|
|
FullHttpResponse response = (FullHttpResponse) msg;
|
|
try {
|
|
if (!handshaker.isHandshakeComplete()) {
|
|
handshaker.finishHandshake(ctx.channel(), response);
|
|
ctx.fireUserEventTriggered(
|
|
WebSocketClientProtocolHandler.ClientHandshakeStateEvent.HANDSHAKE_COMPLETE);
|
|
ctx.pipeline().remove(this);
|
|
return;
|
|
}
|
|
throw new IllegalStateException("WebSocketClientHandshaker should have been non finished yet");
|
|
} finally {
|
|
response.release();
|
|
}
|
|
}
|
|
}
|