1fb6c7e115
Motivation: This AE was seen in the wild at a non-negligible rate among AeroFS clients (JDK 8, TLS 1.2, mutual auth with RSA certs). Upon examination of SslHandler's code a few things became apparent: - the AE is unnecessary given the contract of decode() - the AE was introduced between 3.8 and 3.9 - the AE is no longer present in in 4.x and master - branches that do not have the AE skip all the bytes being fed to unwrap() It is not entirely clear what sequence of SSL records can trip the assert but it seems to happen before the handshake is completed. The little detailed data we've been able to gather shows the assert being triggered when - SSLEngine.unwrap returns NEED_WRAP - the remaining buffer is a TLS heartbeat record Likewise, it is not entirely clear if skipping the remaining bytes is the right thing to do or if they should be fed back to unwrap. Modifications: Mirror behavior in newer versions by removing the assert and skipping bytes fed to unwrap() Add logging in an effort to get a better understanding of this corner case. Result: Avoid crashes |
||
|---|---|---|
| license | ||
| src | ||
| .fbfilter.xml | ||
| .fbprefs | ||
| .gitignore | ||
| CONTRIBUTING.md | ||
| LICENSE.txt | ||
| NOTICE.txt | ||
| pom.xml | ||
| README.md | ||
| run-example.sh | ||
Netty Project
Netty is an asynchronous event-driven network application framework for rapid development of maintainable high performance protocol servers & clients.
Links
How to build
For the detailed information about building and developing Netty, please visit the developer guide. This page only gives very basic information.
You require the following to build Netty:
- Latest stable Oracle JDK 7
- Latest stable Apache Maven
Note that this is build-time requirement. JDK 5 (for 3.x) or 6 (for 4.0+) is enough to run your Netty-based application.
Branches to look
The 'master' branch is where the development of the latest major version lives on. The development of all other versions takes place in each branch whose name is identical to <majorVersion>.<minorVersion>. For example, the development of 3.9 and 4.0 resides in the branch '3.9' and the branch '4.0' respectively.