2854c2c473
Motivation: Netty is an asynchronous framework. If somebody uses a blocking call inside Netty's event loops, it may lead to a severe performance degradation. BlockHound is a tool that helps detecting such calls. Modifications: This change adds a BlockHound's SPI integration that marks threads created by Netty (`FastThreadLocalThread`s) as non-blocking. It also marks some of Netty's internal methods as whitelisted as they are required to run the event loops. Result: When BlockHound is installed, any blocking call inside event loops is intercepted and reported (by default an error will be thrown).
56 lines
1.8 KiB
Java
56 lines
1.8 KiB
Java
/*
|
|
* Copyright 2019 The Netty Project
|
|
|
|
* The Netty Project licenses this file to you under the Apache License,
|
|
* version 2.0 (the "License"); you may not use this file except in compliance
|
|
* with the License. You may obtain a copy of the License at:
|
|
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
* License for the specific language governing permissions and limitations
|
|
* under the License.
|
|
*/
|
|
package io.netty.util.internal;
|
|
|
|
import io.netty.util.concurrent.GlobalEventExecutor;
|
|
import org.junit.BeforeClass;
|
|
import org.junit.Test;
|
|
import reactor.blockhound.BlockHound;
|
|
|
|
import java.util.concurrent.ExecutionException;
|
|
import java.util.concurrent.FutureTask;
|
|
import java.util.concurrent.TimeUnit;
|
|
|
|
import static org.junit.Assert.assertNotNull;
|
|
import static org.junit.Assert.assertTrue;
|
|
import static org.junit.Assert.fail;
|
|
|
|
public class NettyBlockHoundIntegrationTest {
|
|
|
|
@BeforeClass
|
|
public static void setUpClass() {
|
|
BlockHound.install();
|
|
}
|
|
|
|
@Test
|
|
public void testBlockingCallsInNettyThreads() throws Exception {
|
|
final FutureTask<Void> future = new FutureTask<>(() -> {
|
|
Thread.sleep(0);
|
|
return null;
|
|
});
|
|
GlobalEventExecutor.INSTANCE.execute(future);
|
|
|
|
try {
|
|
future.get(5, TimeUnit.SECONDS);
|
|
fail("Expected an exception due to a blocking call but none was thrown");
|
|
} catch (ExecutionException e) {
|
|
Throwable throwable = e.getCause();
|
|
assertNotNull("An exception was thrown", throwable);
|
|
assertTrue("Blocking call was reported", throwable.getMessage().contains("Blocking call"));
|
|
}
|
|
}
|
|
}
|