Go to file
Ngoc Dao 2b4f667791 Fix DefaultHttpDataFactory cleanup bug
Motivation:

DefaultHttpDataFactory uses HttpRequest as map keys.

Because of the implementation of "hashCode"" and "equals" in DefaultHttpRequest,
if we use normal maps, HttpDatas of different requests may end up in the same map entry,
causing cleanup bug.

Consider this example:
- Suppose that request1 is equal to request2, causing their HttpDatas to be stored in one single map entry.
- request1 is cleaned up first, while request2 is still being decoded.
- Consequently request2's HttpDatas are suddenly gone, causing NPE, or worse loss of data.

This bug can be reproduced by starting the HttpUploadServer example,
then run this command:
ab -T 'application/x-www-form-urlencoded' -n 100 -c 5 -p post.txt http://localhost:8080/form

post.txt file content:
a=1&b=2

There will be errors like this:
java.lang.NullPointerException
        at io.netty.handler.codec.http.multipart.MemoryAttribute.getValue(MemoryAttribute.java:64)
        at io.netty.handler.codec.http.multipart.MixedAttribute.getValue(MixedAttribute.java:243)
        at io.netty.example.http.upload.HttpUploadServerHandler.writeHttpData(HttpUploadServerHandler.java:271)
        at io.netty.example.http.upload.HttpUploadServerHandler.readHttpDataChunkByChunk(HttpUploadServerHandler.java:230)
        at io.netty.example.http.upload.HttpUploadServerHandler.channelRead0(HttpUploadServerHandler.java:193)
        at io.netty.example.http.upload.HttpUploadServerHandler.channelRead0(HttpUploadServerHandler.java:66)
        at io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:105)
        at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362)
        at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348)
        at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:340)
        at io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:102)
        at io.netty.handler.codec.MessageToMessageCodec.channelRead(MessageToMessageCodec.java:111)
        at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362)
        at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348)
        at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:340)
        at io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:310)
        at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:284)
        at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362)
        at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348)
        at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:340)
        at io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1412)
        at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362)
        at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348)
        at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:943)
        at io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:141)
        at io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:645)
        at io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:580)
        at io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:497)
        at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:459)
        at io.netty.util.concurrent.SingleThreadEventExecutor$5.run(SingleThreadEventExecutor.java:886)
        at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
        at java.lang.Thread.run(Thread.java:748)

Modifications:

Keep identity of requests by using IdentityHashMap

Result:

DefaultHttpDataFactory is fixed.

The ConcurrentHashMap is replaced with a synchronized map, but I think the performance won't be affected much in real web apps.
2017-12-28 07:40:17 +01:00
.github Use GitHub Issue/PR Template Feature 2016-12-07 11:40:26 -08:00
all [maven-release-plugin] prepare for next development iteration 2017-12-15 13:10:54 +00:00
bom [maven-release-plugin] prepare for next development iteration 2017-12-15 13:10:54 +00:00
buffer Introduce ObjectCleaner and use it in FastThreadLocal to ensure FastThreadLocal.onRemoval(...) is called 2017-12-21 07:34:44 +01:00
codec The constants calculation in compile-time 2017-12-21 07:41:38 +01:00
codec-dns [maven-release-plugin] prepare for next development iteration 2017-12-15 13:10:54 +00:00
codec-haproxy [maven-release-plugin] prepare for next development iteration 2017-12-15 13:10:54 +00:00
codec-http Fix DefaultHttpDataFactory cleanup bug 2017-12-28 07:40:17 +01:00
codec-http2 Http2FrameCodecTest increase timeout 2017-12-22 19:32:18 +01:00
codec-memcache [maven-release-plugin] prepare for next development iteration 2017-12-15 13:10:54 +00:00
codec-mqtt [maven-release-plugin] prepare for next development iteration 2017-12-15 13:10:54 +00:00
codec-redis [maven-release-plugin] prepare for next development iteration 2017-12-15 13:10:54 +00:00
codec-smtp [maven-release-plugin] prepare for next development iteration 2017-12-15 13:10:54 +00:00
codec-socks [maven-release-plugin] prepare for next development iteration 2017-12-15 13:10:54 +00:00
codec-stomp [maven-release-plugin] prepare for next development iteration 2017-12-15 13:10:54 +00:00
codec-xml [maven-release-plugin] prepare for next development iteration 2017-12-15 13:10:54 +00:00
common FastThreadLocal#set remove duplicate isIndexedVariableSet call 2017-12-22 09:41:57 -08:00
dev-tools [maven-release-plugin] prepare for next development iteration 2017-12-15 13:10:54 +00:00
example [maven-release-plugin] prepare for next development iteration 2017-12-15 13:10:54 +00:00
handler [maven-release-plugin] prepare for next development iteration 2017-12-15 13:10:54 +00:00
handler-proxy [maven-release-plugin] prepare for next development iteration 2017-12-15 13:10:54 +00:00
license Remove reference to akka code and ArrayDeque which is not part of netty anymore 2017-03-07 21:30:51 +01:00
microbench Fixed JMH ByteBuf benchmark to avoid dead code elimination 2017-12-19 14:09:18 +01:00
resolver [maven-release-plugin] prepare for next development iteration 2017-12-15 13:10:54 +00:00
resolver-dns [maven-release-plugin] prepare for next development iteration 2017-12-15 13:10:54 +00:00
tarball [maven-release-plugin] prepare for next development iteration 2017-12-15 13:10:54 +00:00
testsuite Use 198.51.100.254 as BAD_HOST for tests. 2017-12-22 19:32:56 +01:00
testsuite-autobahn [maven-release-plugin] prepare for next development iteration 2017-12-15 13:10:54 +00:00
testsuite-http2 Add h2spec test suite module to check if netty http2 implementation conforms with the specification 2017-12-16 13:18:19 +01:00
testsuite-osgi [maven-release-plugin] prepare for next development iteration 2017-12-15 13:10:54 +00:00
transport Add a hint of ownership transfer when calling EmbeddedChannel.read*() methods. 2017-12-20 07:44:25 +01:00
transport-native-epoll [maven-release-plugin] prepare for next development iteration 2017-12-15 13:10:54 +00:00
transport-native-kqueue [maven-release-plugin] prepare for next development iteration 2017-12-15 13:10:54 +00:00
transport-native-unix-common [maven-release-plugin] prepare for next development iteration 2017-12-15 13:10:54 +00:00
transport-native-unix-common-tests [maven-release-plugin] prepare for next development iteration 2017-12-15 13:10:54 +00:00
transport-rxtx [maven-release-plugin] prepare for next development iteration 2017-12-15 13:10:54 +00:00
transport-sctp [maven-release-plugin] prepare for next development iteration 2017-12-15 13:10:54 +00:00
transport-udt [maven-release-plugin] prepare for next development iteration 2017-12-15 13:10:54 +00:00
.fbprefs Updated Find Bugs configuration 2009-03-04 10:33:09 +00:00
.gitignore Use shaded dependency on JCTools instead of copy and paste 2016-06-10 13:19:45 +02:00
.travis.yml Travis CI branch whitelisting 2013-03-11 09:55:43 +09:00
CONTRIBUTING.md Move the pull request guide to the developer guide 2014-03-12 13:13:58 +09:00
LICENSE.txt Relicensed to Apache License v2 2009-08-28 07:15:49 +00:00
NOTICE.txt Remove reference to akka code and ArrayDeque which is not part of netty anymore 2017-03-07 21:30:51 +01:00
pom.xml Test output should include GC details 2017-12-22 19:31:20 +01:00
README.md Adding stable JDK9 module names that follow reverse-DNS style 2017-11-29 11:50:24 +01:00
run-example.sh Add UptimeServer and adjust UptimeClient's code style. 2017-04-28 07:41:07 +02:00

Netty Project

Netty is an asynchronous event-driven network application framework for rapid development of maintainable high performance protocol servers & clients.

How to build

For the detailed information about building and developing Netty, please visit the developer guide. This page only gives very basic information.

You require the following to build Netty:

Note that this is build-time requirement. JDK 5 (for 3.x) or 6 (for 4.0+) is enough to run your Netty-based application.

Branches to look

Development of all versions takes place in each branch whose name is identical to <majorVersion>.<minorVersion>. For example, the development of 3.9 and 4.0 resides in the branch '3.9' and the branch '4.0' respectively.

Usage with JDK 9

Netty can be used in modular JDK9 applications as a collection of automatic modules. The module names follow the reverse-DNS style, and are derived from subproject names rather than root packages due to historical reasons. They are listed below:

  • io.netty.buffer
  • io.netty.codec
  • io.netty.codec.dns
  • io.netty.codec.haproxy
  • io.netty.codec.http
  • io.netty.codec.http2
  • io.netty.codec.memcache
  • io.netty.codec.mqtt
  • io.netty.codec.redis
  • io.netty.codec.smtp
  • io.netty.codec.socks
  • io.netty.codec.stomp
  • io.netty.codec.xml
  • io.netty.common
  • io.netty.handler
  • io.netty.handler.proxy
  • io.netty.resolver
  • io.netty.resolver.dns
  • io.netty.transport
  • io.netty.transport.epoll (native omitted - reserved keyword in Java)
  • io.netty.transport.kqueue (native omitted - reserved keyword in Java)
  • io.netty.transport.unix.common (native omitted - reserved keyword in Java)
  • io.netty.transport.rxtx
  • io.netty.transport.sctp
  • io.netty.transport.udt

Automatic modules do not provide any means to declare dependencies, so you need to list each used module separately in your module-info file.