Go to file
Nick Hill 2e5dd28800 Fix DnsNameResolver TCP fallback test and message leaks (#9647)
Motivation

A memory leak related to DNS resolution was reported in #9634,
specifically linked to the TCP retry fallback functionality that was
introduced relatively recently. Upon inspection it's apparent that there
are some error paths where the original UDP response might not be fully
released, and more significantly the TCP response actually leaks every
time on the fallback success path.

It turns out that a bug in the unit test meant that the intended TCP
fallback path was not actually exercised, so it did not expose the main
leak in question.

Modifications

- Fix DnsNameResolverTest#testTruncated0 dummy server fallback logic to
first read transaction id of retried query and use it in replayed
response
- Adjust semantic of internal DnsQueryContext#finish method to always
take refcount ownership of passed in envelope
- Reorder some logic in DnsResponseHandler fallback handling to verify
the context of the response is expected, and ensure that the query
response are either released or propagated in all cases. This also
reduces a number of redundant retain/release pairings

Result

Fixes #9634
2019-10-14 16:10:15 +02:00
.github Change the netty.io homepage scheme(http -> https) (#9344) 2019-07-09 21:09:42 +02:00
.mvn support publishing snapshots from docker based ci (#8634) 2018-12-07 05:43:06 +01:00
all [maven-release-plugin] prepare for next development iteration 2019-09-25 06:15:31 +00:00
bom [maven-release-plugin] prepare for next development iteration 2019-09-25 06:15:31 +00:00
buffer [maven-release-plugin] prepare for next development iteration 2019-09-25 06:15:31 +00:00
codec Use @SuppressJava6Requirement for animal sniffer plugin to ensure we always guard correctly (#9655) 2019-10-14 15:54:49 +02:00
codec-dns [maven-release-plugin] prepare for next development iteration 2019-09-25 06:15:31 +00:00
codec-haproxy Fix typos in javadocs (#9527) 2019-10-09 17:12:52 +04:00
codec-http Use @SuppressJava6Requirement for animal sniffer plugin to ensure we always guard correctly (#9655) 2019-10-14 15:54:49 +02:00
codec-http2 Fix typos in javadocs (#9527) 2019-10-09 17:12:52 +04:00
codec-memcache [maven-release-plugin] prepare for next development iteration 2019-09-25 06:15:31 +00:00
codec-mqtt [maven-release-plugin] prepare for next development iteration 2019-09-25 06:15:31 +00:00
codec-redis [maven-release-plugin] prepare for next development iteration 2019-09-25 06:15:31 +00:00
codec-smtp [maven-release-plugin] prepare for next development iteration 2019-09-25 06:15:31 +00:00
codec-socks [maven-release-plugin] prepare for next development iteration 2019-09-25 06:15:31 +00:00
codec-stomp [maven-release-plugin] prepare for next development iteration 2019-09-25 06:15:31 +00:00
codec-xml [maven-release-plugin] prepare for next development iteration 2019-09-25 06:15:31 +00:00
common Use @SuppressJava6Requirement for animal sniffer plugin to ensure we always guard correctly (#9655) 2019-10-14 15:54:49 +02:00
dev-tools [maven-release-plugin] prepare for next development iteration 2019-09-25 06:15:31 +00:00
docker Use adopt@1.13.0-0 when building with Java 13 (#9641) 2019-10-09 17:10:37 +04:00
example Fix typos in javadocs (#9527) 2019-10-09 17:12:52 +04:00
handler Use @SuppressJava6Requirement for animal sniffer plugin to ensure we always guard correctly (#9655) 2019-10-14 15:54:49 +02:00
handler-proxy [maven-release-plugin] prepare for next development iteration 2019-09-25 06:15:31 +00:00
license Use Table lookup for HPACK decoder (#9307) 2019-07-02 20:09:44 +02:00
microbench Fix typos in javadocs (#9527) 2019-10-09 17:12:52 +04:00
resolver [maven-release-plugin] prepare for next development iteration 2019-09-25 06:15:31 +00:00
resolver-dns Fix DnsNameResolver TCP fallback test and message leaks (#9647) 2019-10-14 16:10:15 +02:00
tarball [maven-release-plugin] prepare for next development iteration 2019-09-25 06:15:31 +00:00
testsuite Use @SuppressJava6Requirement for animal sniffer plugin to ensure we always guard correctly (#9655) 2019-10-14 15:54:49 +02:00
testsuite-autobahn [maven-release-plugin] prepare for next development iteration 2019-09-25 06:15:31 +00:00
testsuite-http2 Fix typos in javadocs (#9527) 2019-10-09 17:12:52 +04:00
testsuite-native-image [maven-release-plugin] prepare for next development iteration 2019-09-25 06:15:31 +00:00
testsuite-osgi [maven-release-plugin] prepare for next development iteration 2019-09-25 06:15:31 +00:00
testsuite-shading [maven-release-plugin] prepare for next development iteration 2019-09-25 06:15:31 +00:00
transport Use @SuppressJava6Requirement for animal sniffer plugin to ensure we always guard correctly (#9655) 2019-10-14 15:54:49 +02:00
transport-native-epoll Avoid unnecessary epoll event loop wake-ups (#9605) 2019-10-12 20:16:16 +02:00
transport-native-kqueue Fix event loop shutdown timing fragility (#9616) 2019-10-07 11:06:01 +04:00
transport-native-unix-common Enable Netty on a big endian platform 2019-09-27 12:27:37 +02:00
transport-native-unix-common-tests [maven-release-plugin] prepare for next development iteration 2019-09-25 06:15:31 +00:00
transport-rxtx [maven-release-plugin] prepare for next development iteration 2019-09-25 06:15:31 +00:00
transport-sctp [maven-release-plugin] prepare for next development iteration 2019-09-25 06:15:31 +00:00
transport-udt [maven-release-plugin] prepare for next development iteration 2019-09-25 06:15:31 +00:00
.fbprefs Updated Find Bugs configuration 2009-03-04 10:33:09 +00:00
.gitattributes Include mvn wrapper to make setup of development env easier 2018-01-26 08:13:17 +01:00
.gitignore Add vscode specific files / directory to .gitignore (#9652) 2019-10-10 09:35:08 +04:00
CONTRIBUTING.md Change the netty.io homepage scheme(http -> https) (#9344) 2019-07-09 21:09:42 +02:00
LICENSE.txt Relicensed to Apache License v2 2009-08-28 07:15:49 +00:00
mvnw Include mvn wrapper to make setup of development env easier 2018-01-26 08:13:17 +01:00
mvnw.cmd Include mvn wrapper to make setup of development env easier 2018-01-26 08:13:17 +01:00
NOTICE.txt Change the netty.io homepage scheme(http -> https) (#9344) 2019-07-09 21:09:42 +02:00
pom.xml Use @SuppressJava6Requirement for animal sniffer plugin to ensure we always guard correctly (#9655) 2019-10-14 15:54:49 +02:00
README.md Change the netty.io homepage scheme(http -> https) (#9344) 2019-07-09 21:09:42 +02:00
run-example.sh Add UptimeServer and adjust UptimeClient's code style. 2017-04-28 07:41:07 +02:00

Netty Project

Netty is an asynchronous event-driven network application framework for rapid development of maintainable high performance protocol servers & clients.

How to build

For the detailed information about building and developing Netty, please visit the developer guide. This page only gives very basic information.

You require the following to build Netty:

Note that this is build-time requirement. JDK 5 (for 3.x) or 6 (for 4.0+) is enough to run your Netty-based application.

Branches to look

Development of all versions takes place in each branch whose name is identical to <majorVersion>.<minorVersion>. For example, the development of 3.9 and 4.0 resides in the branch '3.9' and the branch '4.0' respectively.

Usage with JDK 9

Netty can be used in modular JDK9 applications as a collection of automatic modules. The module names follow the reverse-DNS style, and are derived from subproject names rather than root packages due to historical reasons. They are listed below:

  • io.netty.all
  • io.netty.buffer
  • io.netty.codec
  • io.netty.codec.dns
  • io.netty.codec.haproxy
  • io.netty.codec.http
  • io.netty.codec.http2
  • io.netty.codec.memcache
  • io.netty.codec.mqtt
  • io.netty.codec.redis
  • io.netty.codec.smtp
  • io.netty.codec.socks
  • io.netty.codec.stomp
  • io.netty.codec.xml
  • io.netty.common
  • io.netty.handler
  • io.netty.handler.proxy
  • io.netty.resolver
  • io.netty.resolver.dns
  • io.netty.transport
  • io.netty.transport.epoll (native omitted - reserved keyword in Java)
  • io.netty.transport.kqueue (native omitted - reserved keyword in Java)
  • io.netty.transport.unix.common (native omitted - reserved keyword in Java)
  • io.netty.transport.rxtx
  • io.netty.transport.sctp
  • io.netty.transport.udt

Automatic modules do not provide any means to declare dependencies, so you need to list each used module separately in your module-info file.