322f75c5a2
Motivation: This fixes a bug that would result in an `io.netty.channel.unix.Errors$NativeIoException: connectx(..) failed: Address family not supported by protocol family` error. This happens when the connecting socket is configured to use IPv6 but the address being connected to is IPv4. This can occur because, for instance, Netty and `InetAddress.getLoopbackAddress()` have different preferences for IPv6 vs. IPv4. Modification: Pass the correct ipv6 or ipv4 flags to connectx, depending on whether the socket was created for AF_INET or AF_INET6, rather than relying on the IP version of the destination address. Result: No more issue with TCP FastOpen on MacOS when using addresses of the "wrong" IP version.
117 lines
4.5 KiB
Java
117 lines
4.5 KiB
Java
/*
|
|
* Copyright 2015 The Netty Project
|
|
*
|
|
* The Netty Project licenses this file to you under the Apache License,
|
|
* version 2.0 (the "License"); you may not use this file except in compliance
|
|
* with the License. You may obtain a copy of the License at:
|
|
*
|
|
* https://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
* License for the specific language governing permissions and limitations
|
|
* under the License.
|
|
*/
|
|
package io.netty.channel.epoll;
|
|
|
|
import io.netty.bootstrap.Bootstrap;
|
|
import io.netty.bootstrap.ServerBootstrap;
|
|
import io.netty.channel.Channel;
|
|
import io.netty.channel.ChannelFuture;
|
|
import io.netty.channel.ChannelFutureListener;
|
|
import io.netty.channel.ChannelHandlerContext;
|
|
import io.netty.channel.ChannelInboundHandlerAdapter;
|
|
import io.netty.channel.unix.DomainSocketReadMode;
|
|
import io.netty.channel.unix.FileDescriptor;
|
|
import io.netty.testsuite.transport.TestsuitePermutation;
|
|
import io.netty.testsuite.transport.socket.AbstractSocketTest;
|
|
import org.junit.jupiter.api.Test;
|
|
import org.junit.jupiter.api.TestInfo;
|
|
import org.junit.jupiter.api.Timeout;
|
|
|
|
import java.net.SocketAddress;
|
|
import java.util.List;
|
|
import java.util.concurrent.BlockingQueue;
|
|
import java.util.concurrent.LinkedBlockingQueue;
|
|
import java.util.concurrent.TimeUnit;
|
|
|
|
import static org.junit.jupiter.api.Assertions.assertFalse;
|
|
import static org.junit.jupiter.api.Assertions.assertNull;
|
|
import static org.junit.jupiter.api.Assertions.assertTrue;
|
|
|
|
public class EpollDomainSocketFdTest extends AbstractSocketTest {
|
|
@Override
|
|
protected SocketAddress newSocketAddress() {
|
|
return EpollSocketTestPermutation.newDomainSocketAddress();
|
|
}
|
|
|
|
@Override
|
|
protected List<TestsuitePermutation.BootstrapComboFactory<ServerBootstrap, Bootstrap>> newFactories() {
|
|
return EpollSocketTestPermutation.INSTANCE.domainSocket();
|
|
}
|
|
|
|
@Test
|
|
@Timeout(value = 30000, unit = TimeUnit.MILLISECONDS)
|
|
public void testSendRecvFd(TestInfo testInfo) throws Throwable {
|
|
run(testInfo, new Runner<ServerBootstrap, Bootstrap>() {
|
|
@Override
|
|
public void run(ServerBootstrap serverBootstrap, Bootstrap bootstrap) throws Throwable {
|
|
testSendRecvFd(serverBootstrap, bootstrap);
|
|
}
|
|
});
|
|
}
|
|
|
|
public void testSendRecvFd(ServerBootstrap sb, Bootstrap cb) throws Throwable {
|
|
final BlockingQueue<Object> queue = new LinkedBlockingQueue<Object>(1);
|
|
sb.childHandler(new ChannelInboundHandlerAdapter() {
|
|
@Override
|
|
public void channelActive(ChannelHandlerContext ctx) throws Exception {
|
|
// Create new channel and obtain a file descriptor from it.
|
|
final EpollDomainSocketChannel ch = new EpollDomainSocketChannel();
|
|
|
|
ctx.writeAndFlush(ch.fd()).addListener(new ChannelFutureListener() {
|
|
@Override
|
|
public void operationComplete(ChannelFuture future) throws Exception {
|
|
if (!future.isSuccess()) {
|
|
Throwable cause = future.cause();
|
|
queue.offer(cause);
|
|
}
|
|
}
|
|
});
|
|
}
|
|
});
|
|
cb.handler(new ChannelInboundHandlerAdapter() {
|
|
@Override
|
|
public void channelRead(ChannelHandlerContext ctx, Object msg) throws Exception {
|
|
FileDescriptor fd = (FileDescriptor) msg;
|
|
queue.offer(fd);
|
|
}
|
|
|
|
@Override
|
|
public void exceptionCaught(ChannelHandlerContext ctx, Throwable cause) throws Exception {
|
|
queue.add(cause);
|
|
ctx.close();
|
|
}
|
|
});
|
|
cb.option(EpollChannelOption.DOMAIN_SOCKET_READ_MODE,
|
|
DomainSocketReadMode.FILE_DESCRIPTORS);
|
|
Channel sc = sb.bind().sync().channel();
|
|
Channel cc = cb.connect(sc.localAddress()).sync().channel();
|
|
|
|
Object received = queue.take();
|
|
cc.close().sync();
|
|
sc.close().sync();
|
|
|
|
if (received instanceof FileDescriptor) {
|
|
FileDescriptor fd = (FileDescriptor) received;
|
|
assertTrue(fd.isOpen());
|
|
fd.close();
|
|
assertFalse(fd.isOpen());
|
|
assertNull(queue.poll());
|
|
} else {
|
|
throw (Throwable) received;
|
|
}
|
|
}
|
|
}
|