a1b5b5dcca
Motivation: EpollRecvByteAllocatorHandle intends to override the meaning of "maybe more data to read" which is a concept also used in all existing implementations of RecvByteBufAllocator$Handle but the interface doesn't support overriding. Because the interfaces lack the ability to propagate this computation EpollRecvByteAllocatorHandle attempts to implement a heuristic on top of the delegate which may lead to reading when we shouldn't or not reading data. Modifications: - Create a new interface ExtendedRecvByteBufAllocator and ExtendedHandle which allows the "maybe more data to read" between interfaces - Deprecate RecvByteBufAllocator and change all existing implementations to extend ExtendedRecvByteBufAllocator - transport-native-epoll should require ExtendedRecvByteBufAllocator so the "maybe more data to read" can be propagated to the ExtendedHandle Result: Fixes https://github.com/netty/netty/issues/6303.
57 lines
1.7 KiB
Java
57 lines
1.7 KiB
Java
/*
|
|
* Copyright 2012 The Netty Project
|
|
*
|
|
* The Netty Project licenses this file to you under the Apache License,
|
|
* version 2.0 (the "License"); you may not use this file except in compliance
|
|
* with the License. You may obtain a copy of the License at:
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
* License for the specific language governing permissions and limitations
|
|
* under the License.
|
|
*/
|
|
package io.netty.channel;
|
|
|
|
/**
|
|
* The {@link RecvByteBufAllocator} that always yields the same buffer
|
|
* size prediction. This predictor ignores the feed back from the I/O thread.
|
|
*/
|
|
public class FixedRecvByteBufAllocator extends DefaultMaxMessagesRecvByteBufAllocator {
|
|
|
|
private final int bufferSize;
|
|
|
|
private final class HandleImpl extends MaxMessageHandle {
|
|
private final int bufferSize;
|
|
|
|
public HandleImpl(int bufferSize) {
|
|
this.bufferSize = bufferSize;
|
|
}
|
|
|
|
@Override
|
|
public int guess() {
|
|
return bufferSize;
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Creates a new predictor that always returns the same prediction of
|
|
* the specified buffer size.
|
|
*/
|
|
public FixedRecvByteBufAllocator(int bufferSize) {
|
|
if (bufferSize <= 0) {
|
|
throw new IllegalArgumentException(
|
|
"bufferSize must greater than 0: " + bufferSize);
|
|
}
|
|
this.bufferSize = bufferSize;
|
|
}
|
|
|
|
@SuppressWarnings("deprecation")
|
|
@Override
|
|
public Handle newHandle() {
|
|
return new HandleImpl(bufferSize);
|
|
}
|
|
}
|