andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
3a9f472161
netty5/codec-memcache/src/main/java/io/netty/handler/codec/memcache
History
Trustin Lee 3a9f472161 Make retained derived buffers recyclable 
Related: #4333 #4421 #5128

Motivation:

slice(), duplicate() and readSlice() currently create a non-recyclable
derived buffer instance. Under heavy load, an application that creates a
lot of derived buffers can put the garbage collector under pressure.

Modifications:

- Add the following methods which creates a non-recyclable derived buffer
  - retainedSlice()
  - retainedDuplicate()
  - readRetainedSlice()
- Add the new recyclable derived buffer implementations, which has its
  own reference count value
- Add ByteBufHolder.retainedDuplicate()
- Add ByteBufHolder.replace(ByteBuf) so that..
  - a user can replace the content of the holder in a consistent way
  - copy/duplicate/retainedDuplicate() can delegate the holder
    construction to replace(ByteBuf)
- Use retainedDuplicate() and retainedSlice() wherever possible
- Miscellaneous:
  - Rename DuplicateByteBufTest to DuplicatedByteBufTest (missing 'D')
  - Make ReplayingDecoderByteBuf.reject() return an exception instead of
    throwing it so that its callers don't need to add dummy return
    statement

Result:

Derived buffers are now recycled when created via retainedSlice() and
retainedDuplicate() and derived from a pooled buffer
2016-05-17 11:16:13 +02:00
..
binary Make retained derived buffers recyclable 2016-05-17 11:16:13 +02:00
AbstractMemcacheObject.java [#5088] Add annotation which marks packages/interfaces/classes as unstable 2016-05-09 15:16:35 +02:00
AbstractMemcacheObjectAggregator.java [#5088] Add annotation which marks packages/interfaces/classes as unstable 2016-05-09 15:16:35 +02:00
AbstractMemcacheObjectDecoder.java [#5088] Add annotation which marks packages/interfaces/classes as unstable 2016-05-09 15:16:35 +02:00
AbstractMemcacheObjectEncoder.java [#5088] Add annotation which marks packages/interfaces/classes as unstable 2016-05-09 15:16:35 +02:00
DefaultLastMemcacheContent.java Make retained derived buffers recyclable 2016-05-17 11:16:13 +02:00
DefaultMemcacheContent.java Make retained derived buffers recyclable 2016-05-17 11:16:13 +02:00
FullMemcacheMessage.java Make retained derived buffers recyclable 2016-05-17 11:16:13 +02:00
LastMemcacheContent.java Make retained derived buffers recyclable 2016-05-17 11:16:13 +02:00
MemcacheContent.java Make retained derived buffers recyclable 2016-05-17 11:16:13 +02:00
MemcacheMessage.java [#5088] Add annotation which marks packages/interfaces/classes as unstable 2016-05-09 15:16:35 +02:00
MemcacheObject.java [#5088] Add annotation which marks packages/interfaces/classes as unstable 2016-05-09 15:16:35 +02:00
package-info.java [#5088] Add annotation which marks packages/interfaces/classes as unstable 2016-05-09 15:16:35 +02:00